From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28375 invoked by alias); 15 Nov 2007 19:06:24 -0000 Received: (qmail 28366 invoked by uid 22791); 15 Nov 2007 19:06:23 -0000 X-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,DK_POLICY_SIGNSOME,SPF_HELO_PASS,SPF_PASS,TW_FH X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 15 Nov 2007 19:06:20 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.1) with ESMTP id lAFJ6Hk7026390; Thu, 15 Nov 2007 14:06:17 -0500 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [10.11.255.20]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id lAFJ6G2v014286; Thu, 15 Nov 2007 14:06:16 -0500 Received: from [127.0.0.1] (sebastian-int.corp.redhat.com [172.16.52.221]) by pobox.corp.redhat.com (8.13.1/8.13.1) with ESMTP id lAFJ6GC0028822; Thu, 15 Nov 2007 14:06:16 -0500 Message-ID: <473C985F.6010103@redhat.com> Date: Thu, 15 Nov 2007 19:06:00 -0000 From: Andrew Cagney User-Agent: Thunderbird 1.5.0.12 (X11/20070530) MIME-Version: 1.0 To: Mark Wielaard CC: Phil Muldoon , frysk@sourceware.org Subject: Re: fhpd vs RuntimeExceptions References: <1195050364.3027.24.camel@dijkstra.wildebeest.org> <473C7B74.6090109@redhat.com> <1195149852.3010.33.camel@dijkstra.wildebeest.org> In-Reply-To: <1195149852.3010.33.camel@dijkstra.wildebeest.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact frysk-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: frysk-owner@sourceware.org X-SW-Source: 2007-q4/txt/msg00142.txt.bz2 Mark Wielaard wrote: > Forgot: > > On Thu, 2007-11-15 at 17:01 +0000, Phil Muldoon wrote: > >> Pending a the full implementation of this it's a pain to see every >> single exception printed. >> > > Till there is a difference between fatal and user message "exceptions" > you can easily get the old behavior by tweaking CLI.flushMessages(): > > That unfortunatly isn't sufficient; the old code in CLI.java was differentiating between and NPE and other exceptions - dumping the stack when an NPE occured. I'll restore this behavior; so we're at least back to a usable status quo (and from a HPD user prospective in a better position - these back-traces plain suck) I'll also add a prototype version of CLI.printError() that we discussed; and have just EvalCommands use it; we can then refine it as needed. Andrew > --- a/frysk-core/frysk/hpd/CLI.java > +++ b/frysk-core/frysk/hpd/CLI.java > @@ -294,7 +294,7 @@ public class CLI { > outWriter.print(prefix); > outWriter.println(tempmsg.getMessage()); > Throwable exc = tempmsg.getException(); > - if (exc != null) > + if (exc != null && false) > exc.printStackTrace(outWriter); > iter.remove(); > } > > Or replace false with the heuristic you find acceptable of course. > > Cheers, > > Mark > >