From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16220 invoked by alias); 26 Nov 2007 16:52:35 -0000 Received: (qmail 16210 invoked by uid 22791); 26 Nov 2007 16:52:35 -0000 X-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,DK_POLICY_SIGNSOME,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 26 Nov 2007 16:52:18 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.1) with ESMTP id lAQGqErx016642; Mon, 26 Nov 2007 11:52:15 -0500 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [10.11.255.20]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id lAQGqDdH003523; Mon, 26 Nov 2007 11:52:13 -0500 Received: from [127.0.0.1] (sebastian-int.corp.redhat.com [172.16.52.221]) by pobox.corp.redhat.com (8.13.1/8.13.1) with ESMTP id lAQGqC6F007265; Mon, 26 Nov 2007 11:52:12 -0500 Message-ID: <474AF9C2.2080607@redhat.com> Date: Mon, 26 Nov 2007 16:52:00 -0000 From: Andrew Cagney User-Agent: Thunderbird 1.5.0.12 (X11/20070530) MIME-Version: 1.0 To: Mark Wielaard CC: Rick Moseley , frysk@sourceware.org Subject: Re: Quick pc hack for exe loading References: <1195817730.2981.21.camel@dijkstra.wildebeest.org> <47470A62.3070906@redhat.com> <47470E4C.5040307@redhat.com> <1196073636.3088.17.camel@dijkstra.wildebeest.org> In-Reply-To: <1196073636.3088.17.camel@dijkstra.wildebeest.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact frysk-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: frysk-owner@sourceware.org X-SW-Source: 2007-q4/txt/msg00180.txt.bz2 Mark Wielaard wrote: > Hi Andrew, > > On Fri, 2007-11-23 at 12:30 -0500, Andrew Cagney wrote: > >> Rick Moseley wrote: >> >>> Hi Mark, >>> >>> Cool. That ought to be fine. >>> >>> >> Yea, except this bit: >> >> + this.bankBuffers = sendrecRegisterBuffersFIXME(); >> >> the word "FIXME" should be a hint. >> > > Indeed, that was moved from the pre-cached function > sendrecRegisterBanks() to the cache in the constructor and also why I > added the XXX and comment. I assume this is because you are in the > middle of moving Isa and register related methods to their own package? > Or is that work finished now and these remaining FIXME() methods just > need to be cleaned up now? > > The XXX comment: + // Fake PC. XXX should be done in Proc instead of creating Elf + // object in the Task itself. seems unrelated. The comment for getRegisterBuffers notes: protected abstract ByteBuffer[] sendrecRegisterBuffersFIXME(); /** * Return the machine's register banks as an array. * * XXX: This is being replaced by "getRegisterBanks()" that returns * a class that abstracts the ByteArray[] + BankRegister * combination. */ public ByteBuffer[] getRegisterBuffersFIXME () what prevents the use of getRegisterBanks()? Andrew > Cheers, > > Mark > >