From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4630 invoked by alias); 27 Nov 2007 14:45:57 -0000 Received: (qmail 4615 invoked by uid 22791); 27 Nov 2007 14:45:56 -0000 X-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,DK_POLICY_SIGNSOME,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 27 Nov 2007 14:45:52 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.1) with ESMTP id lAREjE4a019102; Tue, 27 Nov 2007 09:45:14 -0500 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [10.11.255.20]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id lAREjERF011659; Tue, 27 Nov 2007 09:45:14 -0500 Received: from [127.0.0.1] (sebastian-int.corp.redhat.com [172.16.52.221]) by pobox.corp.redhat.com (8.13.1/8.13.1) with ESMTP id lAREj81o012160; Tue, 27 Nov 2007 09:45:09 -0500 Message-ID: <474C2D7A.8020109@redhat.com> Date: Tue, 27 Nov 2007 14:45:00 -0000 From: Andrew Cagney User-Agent: Thunderbird 1.5.0.12 (X11/20070530) MIME-Version: 1.0 To: pearly.zhao@oracle.com CC: frysk@sourceware.org Subject: Re: [SCM] master: Add a test testMemoryBufferCapacity() to TestByteBuffer.java References: <20071122090733.7335.qmail@sourceware.org> <4745B7E4.4090408@redhat.com> <1195791150.22218.13.camel@linux-pzhao.site> <47476AEF.4080900@redhat.com> <1196045768.3728.6.camel@linux-pzhao.site> In-Reply-To: <1196045768.3728.6.camel@linux-pzhao.site> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact frysk-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: frysk-owner@sourceware.org X-SW-Source: 2007-q4/txt/msg00183.txt.bz2 Zhao Shujing wrote: > Sorry, this test is added for bug 1538. I think .capacity() can use for > test if highWater mark is the top location when map memory to > ByteBuffer. > True; however did you see: > + = new ExecOffspring(new ExecCommand (new String[] { > + "/bin/rm", > + tmpFile.toString() > > > I'm not sure that ExecOffspring is what you need here as it doesn't put > the task into an attached/stopped state; I suspect: > Task = new DaemonBlockedAtEntry("funit-slave").getMainTask().getISA(); > be simpler? and: > + Task task = child.findTaskUsingRefresh(true); > + if (task.getISA() == ISA.IA32) > + assertEquals("Memory Buffer Capacity: ", 0xffffffffL, > + task.getMemory().capacity()); > + if (task.getISA() == ISA.X8664) > + assertEquals("Memory Buffer Capacity: ", > 0xffffffffffffffffL, > + task.getMemory().capacity()); > } > > > There is also the PPC; the attribute is dependent on the ISA's word > size, though, is something like: > switch (task.getISA().wordSize()) > case 4: assert ... ; break; > case 8: assert ... ; break; > default: fail("unknown word size"); > } > simplier? > > is the test passing or still being skipped? can we address these? Andrew