From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13501 invoked by alias); 4 Dec 2007 14:57:48 -0000 Received: (qmail 13494 invoked by uid 22791); 4 Dec 2007 14:57:48 -0000 X-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,DK_POLICY_SIGNSOME,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 04 Dec 2007 14:57:43 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.1) with ESMTP id lB4Evcg8022988; Tue, 4 Dec 2007 09:57:38 -0500 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [10.11.255.20]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id lB4Evc3S020533; Tue, 4 Dec 2007 09:57:38 -0500 Received: from [127.0.0.1] (sebastian-int.corp.redhat.com [172.16.52.221]) by pobox.corp.redhat.com (8.13.1/8.13.1) with ESMTP id lB4Evbwd020364; Tue, 4 Dec 2007 09:57:37 -0500 Message-ID: <47556AEE.50506@redhat.com> Date: Tue, 04 Dec 2007 14:57:00 -0000 From: Andrew Cagney User-Agent: Thunderbird 1.5.0.12 (X11/20070530) MIME-Version: 1.0 To: Mark Wielaard , Jose Flavio Aguilar Paulino CC: frysk@sourceware.org Subject: Re: [SCM] master: Updating register group names. References: <20071204110100.9581.qmail@sourceware.org> <1196775231.3808.2.camel@dijkstra.wildebeest.org> In-Reply-To: <1196775231.3808.2.camel@dijkstra.wildebeest.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact frysk-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: frysk-owner@sourceware.org X-SW-Source: 2007-q4/txt/msg00204.txt.bz2 Mark Wielaard wrote: > Hi Jose, > > On Tue, 2007-12-04 at 11:01 +0000, jflavio@sourceware.org wrote: > >> Author: Jose Flavio Aguilar Paulino >> Date: Tue Dec 4 08:45:03 2007 -0200 >> >> Updating register group names. >> > > This does break one test: > > testToString(frysk.isa.TestISA)junit.framework.ComparisonFailure: > toString expected:<...> but was:<...32BE> > > >> public static final ISA PPC32BE >> - = new ISA(ByteOrder.BIG_ENDIAN, 4, "PowerPC"); >> + = new ISA(ByteOrder.BIG_ENDIAN, 4, "PowerPC32BE"); >> public static final ISA PPC64BE >> - = new ISA(ByteOrder.BIG_ENDIAN, 8, "PowerPC"); >> + = new ISA(ByteOrder.BIG_ENDIAN, 8, "PowerPC64BE"); >> > > I am not sure what the right String is. But it should be similar in both > the isa and the test. > Just "PowerPC", the string specifies the the ISA family. Thing's like "big-endian" and 64-bit are derived from the other parameters. The test looks like this: public void testToString() { assertEquals("toString", "32-bit big-endian PowerPC", ISA.PPC32BE.toString()); } Andrew >