From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21290 invoked by alias); 12 Feb 2008 21:33:00 -0000 Received: (qmail 21134 invoked by uid 22791); 12 Feb 2008 21:32:41 -0000 X-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_34,J_CHICKENPOX_53,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 12 Feb 2008 21:32:24 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id m1CLWMH0011655 for ; Tue, 12 Feb 2008 16:32:22 -0500 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [10.11.255.20]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m1CLWMrU029716; Tue, 12 Feb 2008 16:32:22 -0500 Received: from localhost.localdomain (sebastian-int.corp.redhat.com [172.16.52.221]) by pobox.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m1CLWLa3003206; Tue, 12 Feb 2008 16:32:21 -0500 Message-ID: <47B2102D.2030804@redhat.com> Date: Tue, 12 Feb 2008 21:33:00 -0000 From: Andrew Cagney User-Agent: Thunderbird 2.0.0.9 (X11/20071115) MIME-Version: 1.0 To: Phil Muldoon CC: frysk@sourceware.org Subject: Re: [SCM] master: Add frysk.rsl loggin. References: <20080212200324.2256.qmail@sourceware.org> In-Reply-To: <20080212200324.2256.qmail@sourceware.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.58 on 172.16.52.254 X-IsSubscribed: yes Mailing-List: contact frysk-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: frysk-owner@sourceware.org X-SW-Source: 2008-q1/txt/msg00064.txt.bz2 Phil, There's a less leaky way to write this (if a specific sequence is missing in Log, just add it). > { > > + > + finest.log(this,"peek() address 0x" + Long.toHexString(address)); > finest.log(this, "peak() address", address); > byte[] buffer = new byte[1]; > MapAddressHeader metaLine = findMetaData(address); > > @@ -120,6 +125,10 @@ public class CorefileByteBuffer > StatelessFile temp = new StatelessFile(new File(metaLine.name)); > long offset = metaLine.solibOffset + (address - metaLine.vaddr); > temp.pread(offset, buffer,0,1); > + finest.log(this,"peek'ed() 0x"+Integer.toHexString(buffer[0] & 0xff) + > + " from address 0x"+Long.toHexString(address) + > + " offset 0x"+Long.toHexString(offset) + > + " from file: " +metaLine.name); > finest.log(this, "peek'ed ", (long)(buffer[0]&0xff), "from address", address, "offset", offset, "file", metaLine.name); and so on. All log functions take the consistent form: log(SELF, MESSAGE, OBJECT, MESSAGE, OBJECT, ....) Andrew