From: Phil Muldoon <pmuldoon@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Frysk Hackers <frysk@sourceware.org>
Subject: Re: Patch: Add Option Groups
Date: Wed, 19 Mar 2008 07:51:00 -0000 [thread overview]
Message-ID: <47E0C5E8.9010905@redhat.com> (raw)
In-Reply-To: <m3tzj4uea9.fsf@fleche.redhat.com>
Tom Tromey wrote:
> Yeah, this is a bit odd, but I guess harmless for the time being.
> Maybe it would be better to either push new functionality for this
> kind of thing into Parser, or to have users of frysk's
> CommandlineParser be a bit smarter about coordinating with the
> superclass.
>
>
A lot of the code in the bindir utilities is template code that all
utilities call. It saves a lot of work, but also takes away flexibility.
It's all a bit new to me too. But see my reply to Andrew for a few
thoughts there.
> Phil> There is a lot of weird
> Phil> indenting going on in the right help column, but this was happening
> Phil> beforehand and is another unrelated (but hopefully soon to be fixed)
> Phil> bug.
>
> Some of this is accounted for by rogue spaces, e.g.:
>
> Phil> + group.add(new Option( "allmaps", 'a',
> Phil> + " Include ALL process readable maps.")
>
>
Ack well spotted on that one.
> That space before "Include" is strange.
>
> Phil> + "=PATTERN") {
> Putting the "=" in here is wrong, fwiw.
>
>
I was trying to follow grep's help, but the only way I can get an
option=PATTERN is to put the = in there. Unless I am using the wrong
option type?
FWIW also it seems that classpath getopt is doing some funky indention
on help right hand column.
Thanks for the comments!
Regards
Phil
next prev parent reply other threads:[~2008-03-19 7:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-18 17:41 Phil Muldoon
2008-03-18 18:28 ` Tom Tromey
2008-03-19 7:51 ` Phil Muldoon [this message]
2008-03-19 13:23 ` Tom Tromey
2008-03-18 20:11 ` Andrew Cagney
2008-03-19 7:46 ` Phil Muldoon
2008-03-20 11:52 ` Andrew Cagney
2008-03-20 14:23 ` Tom Tromey
2008-03-20 16:09 ` Andrew Cagney
2008-03-20 18:06 ` Tom Tromey
2008-04-01 21:36 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47E0C5E8.9010905@redhat.com \
--to=pmuldoon@redhat.com \
--cc=frysk@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).