From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11380 invoked by alias); 19 Mar 2008 07:51:26 -0000 Received: (qmail 11371 invoked by uid 22791); 19 Mar 2008 07:51:26 -0000 X-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 19 Mar 2008 07:51:08 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id m2J7p7R5028366 for ; Wed, 19 Mar 2008 03:51:07 -0400 Received: from pobox-2.corp.redhat.com (pobox-2.corp.redhat.com [10.11.255.15]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m2J7p65p031071; Wed, 19 Mar 2008 03:51:06 -0400 Received: from localhost.localdomain (vpn-15-121.rdu.redhat.com [10.11.15.121]) by pobox-2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m2J7p58Z023913; Wed, 19 Mar 2008 03:51:06 -0400 Message-ID: <47E0C5E8.9010905@redhat.com> Date: Wed, 19 Mar 2008 07:51:00 -0000 From: Phil Muldoon User-Agent: Thunderbird 2.0.0.12 (X11/20080226) MIME-Version: 1.0 To: Tom Tromey CC: Frysk Hackers Subject: Re: Patch: Add Option Groups References: <47DFFE9D.80906@redhat.com> In-Reply-To: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.58 on 172.16.52.254 X-IsSubscribed: yes Mailing-List: contact frysk-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: frysk-owner@sourceware.org X-SW-Source: 2008-q1/txt/msg00166.txt.bz2 Tom Tromey wrote: > Yeah, this is a bit odd, but I guess harmless for the time being. > Maybe it would be better to either push new functionality for this > kind of thing into Parser, or to have users of frysk's > CommandlineParser be a bit smarter about coordinating with the > superclass. > > A lot of the code in the bindir utilities is template code that all utilities call. It saves a lot of work, but also takes away flexibility. It's all a bit new to me too. But see my reply to Andrew for a few thoughts there. > Phil> There is a lot of weird > Phil> indenting going on in the right help column, but this was happening > Phil> beforehand and is another unrelated (but hopefully soon to be fixed) > Phil> bug. > > Some of this is accounted for by rogue spaces, e.g.: > > Phil> + group.add(new Option( "allmaps", 'a', > Phil> + " Include ALL process readable maps.") > > Ack well spotted on that one. > That space before "Include" is strange. > > Phil> + "=PATTERN") { > Putting the "=" in here is wrong, fwiw. > > I was trying to follow grep's help, but the only way I can get an option=PATTERN is to put the = in there. Unless I am using the wrong option type? FWIW also it seems that classpath getopt is doing some funky indention on help right hand column. Thanks for the comments! Regards Phil