public inbox for frysk@sourceware.org
 help / color / mirror / Atom feed
* Re: [SCM]  master: Merge branch 'master' of ssh://sources.redhat.com/git/frysk
       [not found] <20080401122840.732.qmail@sourceware.org>
@ 2008-04-01 14:13 ` Phil Muldoon
  2008-04-02  7:59   ` Mark Wielaard
  0 siblings, 1 reply; 6+ messages in thread
From: Phil Muldoon @ 2008-04-01 14:13 UTC (permalink / raw)
  To: frysk

pmuldoon@sourceware.org wrote:

This commit build a dead simple watchpoint scenario. The assembly level 
program writes to a global and exits. For the time being it is a sanity 
tests for the upcoming Watchpoint observer code, and tests that 
watchpoints at the lowest and most simple level work.

Regards

Phil
> The branch, master has been updated
>        via  22a5428f36763f5bf81885fcc19f03104541c18c (commit)
>        via  0b3aa7428253d10407c79d4be51e02afcdf92952 (commit)
>       from  e1ebce24e45ed9778fa430444318ec8f92de1f5e (commit)
>
> Those revisions listed above that are new to this repository have
> not appeared on any other notification email.
>
> - Log -----------------------------------------------------------------
> commit 22a5428f36763f5bf81885fcc19f03104541c18c
> Merge: 0b3aa7428253d10407c79d4be51e02afcdf92952 e1ebce24e45ed9778fa430444318ec8f92de1f5e
> Author: Phil Muldoon <pmuldoon@redhat.com>
> Date:   Tue Apr 1 13:28:34 2008 +0100
>
>     Merge branch 'master' of ssh://sources.redhat.com/git/frysk
>
> commit 0b3aa7428253d10407c79d4be51e02afcdf92952
> Author: Phil Muldoon <pmuldoon@redhat.com>
> Date:   Tue Apr 1 13:27:36 2008 +0100
>
>     Add new assembler progream funit-watchpoint.S
>     
>     2008-04-01  Phil Muldoon  <pmuldoon@redhat.com>
>     
>             * funit-watchpoint.S: New.
>
> -----------------------------------------------------------------------
>
> Summary of changes:
>  frysk-core/frysk/pkglibdir/ChangeLog               |    4 ++
>  .../{funit-libcall.c => funit-watchpoint.S}        |   40 ++++++++++++--------
>  2 files changed, 28 insertions(+), 16 deletions(-)
>  copy frysk-core/frysk/pkglibdir/{funit-libcall.c => funit-watchpoint.S} (87%)
>
> First 500 lines of diff:
> diff --git a/frysk-core/frysk/pkglibdir/ChangeLog b/frysk-core/frysk/pkglibdir/ChangeLog
> index 7ec6e15..504e7f5 100644
> --- a/frysk-core/frysk/pkglibdir/ChangeLog
> +++ b/frysk-core/frysk/pkglibdir/ChangeLog
> @@ -1,3 +1,7 @@
> +2008-04-01  Phil Muldoon  <pmuldoon@redhat.com>
> +
> +	* funit-watchpoint.S: New.
> +
>  2008-03-18  Stan Cox  <scox@redhat.com>
>  
>  	* funit-quicksort.c (main): Make sortlist extern.
> diff --git a/frysk-core/frysk/pkglibdir/funit-libcall.c b/frysk-core/frysk/pkglibdir/funit-watchpoint.S
> similarity index 87%
> copy from frysk-core/frysk/pkglibdir/funit-libcall.c
> copy to frysk-core/frysk/pkglibdir/funit-watchpoint.S
> index 578b0a2..eb0863f 100644
> --- a/frysk-core/frysk/pkglibdir/funit-libcall.c
> +++ b/frysk-core/frysk/pkglibdir/funit-watchpoint.S
> @@ -37,22 +37,30 @@
>  // version and license this file solely under the GPL without
>  // exception.
>  
> -#include <stdlib.h>
> -#include <sys/time.h>
> +#include "frysk-asm.h"
>  
> -static volatile long tmp = 0;
> +FUNCTION_BEGIN(main,0)
> +MAIN_PROLOGUE(0)
> +NOP
> +	
> +LOAD_IMMED_BYTE (REG1, source)
> +LOAD_IMMED_BYTE (REG3, 0x77)
> +NOP
> +NOP
> +NOP
> +STORE(REG3, REG1)
> +NOP
> +NOP
> +NOP
> +
> +
> +MAIN_EPILOGUE(0)
> +FUNCTION_RETURN(main,0)
> +FUNCTION_END(main,0)
> +
> +.data
> +.globl source
> +source:						// Set up memory locations
> +	.byte 0x99
>  
> -void
> -foo ()
> -{
> -  struct timeval t;
> -  gettimeofday (&t, NULL); // _testIStepThrough_
> -  tmp += t.tv_usec;
> -}
>  
> -int
> -main (int argc, char **argv)
> -{
> -  foo ();
> -  exit (0);
> -}
>
>
> hooks/post-receive
> --
> frysk system monitor/debugger
>   

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [SCM]  master: Merge branch 'master' of  ssh://sources.redhat.com/git/frysk
  2008-04-01 14:13 ` [SCM] master: Merge branch 'master' of ssh://sources.redhat.com/git/frysk Phil Muldoon
@ 2008-04-02  7:59   ` Mark Wielaard
  2008-04-02  9:06     ` Phil Muldoon
  0 siblings, 1 reply; 6+ messages in thread
From: Mark Wielaard @ 2008-04-02  7:59 UTC (permalink / raw)
  To: Phil Muldoon; +Cc: frysk

Hi Phil,

On Tue, 2008-04-01 at 15:13 +0100, Phil Muldoon wrote:
> This commit build a dead simple watchpoint scenario. The assembly level 
> program writes to a global and exits. For the time being it is a sanity 
> tests for the upcoming Watchpoint observer code, and tests that 
> watchpoints at the lowest and most simple level work.

Thanks for commenting on what you work on and why you introduced what.
It really helps keeping an overview of what is happening with the code
base and the various changes made in general. And also thanks for adding
comments to this file in a later commit (my assembly is very rusty, so
reading what it is actually supposed to do is very appreciated).

Cheers,

Mark

P.S. The diffs on frysk-cvs look really strange at times. I always just
post the actual patches myself since it seems the git diff on sourceware
just scrambles them trying to be clever and associating random files
with each other and generating a diff of them instead of a real diff of
the original file :{

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [SCM]  master: Merge branch 'master' of ssh://sources.redhat.com/git/frysk
  2008-04-02  7:59   ` Mark Wielaard
@ 2008-04-02  9:06     ` Phil Muldoon
  2008-04-02 10:43       ` Mark Wielaard
  0 siblings, 1 reply; 6+ messages in thread
From: Phil Muldoon @ 2008-04-02  9:06 UTC (permalink / raw)
  To: Mark Wielaard; +Cc: frysk

Mark Wielaard wrote:
> Thanks for commenting on what you work on and why you introduced what.
> It really helps keeping an overview of what is happening with the code
> base and the various changes made in general. And also thanks for adding
> comments to this file in a later commit (my assembly is very rusty, so
> reading what it is actually supposed to do is very appreciated).
>
>   

The uncommented assembly was a mistake commit. Rather than retracting it 
and redoing it,  I just fixed it upstream.

> P.S. The diffs on frysk-cvs look really strange at times. I always just
> post the actual patches myself since it seems the git diff on sourceware
> just scrambles them trying to be clever and associating random files
> with each other and generating a diff of them instead of a real diff of
> the original file :{
>   

I'd really have this fixed on the git side, not mine. The copy detection 
has gone bonkers, and I think it should be just turned off completely. I 
could generate patches,  but if the diff email can do that properly it 
will save one more step. Another thing I keep doing is forgetting to add 
ais  header to the commit email, and forgetting to --amend the commit 
message of a merge conflict. Still in a learning pattern here I guess.

But please, ack, lets turn off the whacky copy detection that is almost 
always wrong ;)

Regards

4Phil

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [SCM]  master: Merge branch 'master'  of ssh://sources.redhat.com/git/frysk
  2008-04-02  9:06     ` Phil Muldoon
@ 2008-04-02 10:43       ` Mark Wielaard
  2008-04-03 13:51         ` Mark Wielaard
  0 siblings, 1 reply; 6+ messages in thread
From: Mark Wielaard @ 2008-04-02 10:43 UTC (permalink / raw)
  To: Phil Muldoon; +Cc: frysk, Tim Moore

Hi Phil,

On Wed, 2008-04-02 at 10:05 +0100, Phil Muldoon wrote:
> But please, ack, lets turn off the whacky copy detection that is almost 
> always wrong ;)

ACK! :)

I just don't know where the configuration files are stored. Tim do you
know where on sourceware this needs to be adjusted? There must be a
--find-copies-harder in there somewhere that really has to go (or maybe
just replaced with a plain -M -C).

Cheers,

Mark

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [SCM]  master: Merge branch 'master'  of ssh://sources.redhat.com/git/frysk
  2008-04-02 10:43       ` Mark Wielaard
@ 2008-04-03 13:51         ` Mark Wielaard
  2008-04-03 13:52           ` Mark Wielaard
  0 siblings, 1 reply; 6+ messages in thread
From: Mark Wielaard @ 2008-04-03 13:51 UTC (permalink / raw)
  To: Phil Muldoon; +Cc: frysk, Tim Moore

Hi,

On Wed, 2008-04-02 at 12:42 +0200, Mark Wielaard wrote:
> I just don't know where the configuration files are stored. Tim do you
> know where on sourceware this needs to be adjusted? There must be a
> --find-copies-harder in there somewhere that really has to go (or maybe
> just replaced with a plain -M -C).

Found them under gitfiles/.git/hooks/post-receive-email and made the
above change (replacing --find-copies-harder with -M -C). Simple commit
pushed and results look OK.

Cheers,

Mark

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [SCM]  master: Merge branch 'master'  of ssh://sources.redhat.com/git/frysk
  2008-04-03 13:51         ` Mark Wielaard
@ 2008-04-03 13:52           ` Mark Wielaard
  0 siblings, 0 replies; 6+ messages in thread
From: Mark Wielaard @ 2008-04-03 13:52 UTC (permalink / raw)
  To: Phil Muldoon; +Cc: frysk, Tim Moore

Hi,

On Wed, 2008-04-02 at 12:42 +0200, Mark Wielaard wrote:
> I just don't know where the configuration files are stored. Tim do you
> know where on sourceware this needs to be adjusted? There must be a
> --find-copies-harder in there somewhere that really has to go (or maybe
> just replaced with a plain -M -C).

Found them under gitfiles/.git/hooks/post-receive-email and made the
above change (replacing --find-copies-harder with -M -C). Simple commit
pushed and results look OK.

Cheers,

Mark

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2008-04-03 13:52 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20080401122840.732.qmail@sourceware.org>
2008-04-01 14:13 ` [SCM] master: Merge branch 'master' of ssh://sources.redhat.com/git/frysk Phil Muldoon
2008-04-02  7:59   ` Mark Wielaard
2008-04-02  9:06     ` Phil Muldoon
2008-04-02 10:43       ` Mark Wielaard
2008-04-03 13:51         ` Mark Wielaard
2008-04-03 13:52           ` Mark Wielaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).