public inbox for frysk@sourceware.org
 help / color / mirror / Atom feed
From: Phil Muldoon <pmuldoon@redhat.com>
To: Mark Wielaard <mark@klomp.org>
Cc: frysk@sourceware.org
Subject: Re: [SCM]  master: Merge branch 'master' of	ssh://sources.redhat.com/git/frysk
Date: Wed, 02 Apr 2008 09:06:00 -0000	[thread overview]
Message-ID: <47F34C73.7050405@redhat.com> (raw)
In-Reply-To: <1207123115.4953.32.camel@cc1341701-a.deven1.ov.home.nl>

Mark Wielaard wrote:
> Thanks for commenting on what you work on and why you introduced what.
> It really helps keeping an overview of what is happening with the code
> base and the various changes made in general. And also thanks for adding
> comments to this file in a later commit (my assembly is very rusty, so
> reading what it is actually supposed to do is very appreciated).
>
>   

The uncommented assembly was a mistake commit. Rather than retracting it 
and redoing it,  I just fixed it upstream.

> P.S. The diffs on frysk-cvs look really strange at times. I always just
> post the actual patches myself since it seems the git diff on sourceware
> just scrambles them trying to be clever and associating random files
> with each other and generating a diff of them instead of a real diff of
> the original file :{
>   

I'd really have this fixed on the git side, not mine. The copy detection 
has gone bonkers, and I think it should be just turned off completely. I 
could generate patches,  but if the diff email can do that properly it 
will save one more step. Another thing I keep doing is forgetting to add 
ais  header to the commit email, and forgetting to --amend the commit 
message of a merge conflict. Still in a learning pattern here I guess.

But please, ack, lets turn off the whacky copy detection that is almost 
always wrong ;)

Regards

4Phil

  reply	other threads:[~2008-04-02  9:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20080401122840.732.qmail@sourceware.org>
2008-04-01 14:13 ` Phil Muldoon
2008-04-02  7:59   ` Mark Wielaard
2008-04-02  9:06     ` Phil Muldoon [this message]
2008-04-02 10:43       ` Mark Wielaard
2008-04-03 13:51         ` Mark Wielaard
2008-04-03 13:52           ` Mark Wielaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47F34C73.7050405@redhat.com \
    --to=pmuldoon@redhat.com \
    --cc=frysk@sourceware.org \
    --cc=mark@klomp.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).