From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6130 invoked by alias); 2 Apr 2008 09:06:23 -0000 Received: (qmail 6105 invoked by uid 22791); 2 Apr 2008 09:06:18 -0000 X-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 02 Apr 2008 09:06:01 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id m3295v06011483; Wed, 2 Apr 2008 05:05:57 -0400 Received: from pobox-2.corp.redhat.com (pobox-2.corp.redhat.com [10.11.255.15]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m3295vac017484; Wed, 2 Apr 2008 05:05:57 -0400 Received: from localhost.localdomain (vpn-14-26.rdu.redhat.com [10.11.14.26]) by pobox-2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m3295tfb010620; Wed, 2 Apr 2008 05:05:56 -0400 Message-ID: <47F34C73.7050405@redhat.com> Date: Wed, 02 Apr 2008 09:06:00 -0000 From: Phil Muldoon User-Agent: Thunderbird 2.0.0.12 (X11/20080226) MIME-Version: 1.0 To: Mark Wielaard CC: frysk@sourceware.org Subject: Re: [SCM] master: Merge branch 'master' of ssh://sources.redhat.com/git/frysk References: <20080401122840.732.qmail@sourceware.org> <47F242FD.4030001@redhat.com> <1207123115.4953.32.camel@cc1341701-a.deven1.ov.home.nl> In-Reply-To: <1207123115.4953.32.camel@cc1341701-a.deven1.ov.home.nl> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.58 on 172.16.52.254 X-IsSubscribed: yes Mailing-List: contact frysk-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: frysk-owner@sourceware.org X-SW-Source: 2008-q2/txt/msg00007.txt.bz2 Mark Wielaard wrote: > Thanks for commenting on what you work on and why you introduced what. > It really helps keeping an overview of what is happening with the code > base and the various changes made in general. And also thanks for adding > comments to this file in a later commit (my assembly is very rusty, so > reading what it is actually supposed to do is very appreciated). > > The uncommented assembly was a mistake commit. Rather than retracting it and redoing it, I just fixed it upstream. > P.S. The diffs on frysk-cvs look really strange at times. I always just > post the actual patches myself since it seems the git diff on sourceware > just scrambles them trying to be clever and associating random files > with each other and generating a diff of them instead of a real diff of > the original file :{ > I'd really have this fixed on the git side, not mine. The copy detection has gone bonkers, and I think it should be just turned off completely. I could generate patches, but if the diff email can do that properly it will save one more step. Another thing I keep doing is forgetting to add ais header to the commit email, and forgetting to --amend the commit message of a merge conflict. Still in a learning pattern here I guess. But please, ack, lets turn off the whacky copy detection that is almost always wrong ;) Regards 4Phil