From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2857 invoked by alias); 14 Apr 2008 13:31:56 -0000 Received: (qmail 2827 invoked by uid 22791); 14 Apr 2008 13:31:52 -0000 X-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_34,J_CHICKENPOX_35,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 14 Apr 2008 13:31:35 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id m3EDVXeS018739 for ; Mon, 14 Apr 2008 09:31:33 -0400 Received: from pobox-2.corp.redhat.com (pobox-2.corp.redhat.com [10.11.255.15]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m3EDVX2H028837 for ; Mon, 14 Apr 2008 09:31:33 -0400 Received: from localhost.localdomain (vpn-14-80.rdu.redhat.com [10.11.14.80]) by pobox-2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m3EDVWH1010658 for ; Mon, 14 Apr 2008 09:31:32 -0400 Message-ID: <48035CB3.80704@redhat.com> Date: Tue, 15 Apr 2008 12:40:00 -0000 From: Phil Muldoon User-Agent: Thunderbird 2.0.0.12 (X11/20080226) MIME-Version: 1.0 To: frysk@sourceware.org Subject: Re: [SCM] master: Set hit.count to 2 in testWatchpointActionContinue. References: <20080414132412.31508.qmail@sourceware.org> In-Reply-To: <20080414132412.31508.qmail@sourceware.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.58 on 172.16.52.254 X-IsSubscribed: yes Mailing-List: contact frysk-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: frysk-owner@sourceware.org X-SW-Source: 2008-q2/txt/msg00053.txt.bz2 pmuldoon@sourceware.org wrote: This is a good example of an author being snared and told off by his own test. When I added the read_only test, I reused the source variable as place to "write to" from the read_only variable "read from". However this makes the source watchpoint fire twice in the testWatchpontActionContinue test (correctly) as it adds another "source" variable write. When watching the variable "source" two writes means two watchpoint triggers; this is because this particular always continues and never blocks. Regards Phil > The branch, master has been updated > via 59acb89f662cace8e7b3cb61f86c8c93f9b8cea1 (commit) > from dd89b9e98efbe563cef22c6b18b9b135523a8205 (commit) > > Those revisions listed above that are new to this repository have > not appeared on any other notification email. > > - Log ----------------------------------------------------------------- > commit 59acb89f662cace8e7b3cb61f86c8c93f9b8cea1 > Author: Phil Muldoon > Date: Mon Apr 14 14:20:49 2008 +0100 > > Set hit.count to 2 in testWatchpointActionContinue. > > 2008-04-14 Phil Muldoon > > * TestTaskObserverWatchpoint.java (testRunningAndReadOnlyWatchpoint): New. > (testWatchpointActionContinue): Change hit.code to 2,(test above adds another hit). > > ----------------------------------------------------------------------- > > Summary of changes: > frysk-core/frysk/proc/ChangeLog | 1 + > .../frysk/proc/TestTaskObserverWatchpoint.java | 2 +- > 2 files changed, 2 insertions(+), 1 deletions(-) > > First 500 lines of diff: > diff --git a/frysk-core/frysk/proc/ChangeLog b/frysk-core/frysk/proc/ChangeLog > index 63785a8..a671460 100644 > --- a/frysk-core/frysk/proc/ChangeLog > +++ b/frysk-core/frysk/proc/ChangeLog > @@ -1,6 +1,7 @@ > 2008-04-14 Phil Muldoon > > * TestTaskObserverWatchpoint.java (testRunningAndReadOnlyWatchpoint): New. > + (testWatchpointActionContinue): Change hit.code to 2,(test above adds another hit). > > 2008-04-10 Phil Muldoon > > diff --git a/frysk-core/frysk/proc/TestTaskObserverWatchpoint.java b/frysk-core/frysk/proc/TestTaskObserverWatchpoint.java > index 2fde8c2..6650fe3 100644 > --- a/frysk-core/frysk/proc/TestTaskObserverWatchpoint.java > +++ b/frysk-core/frysk/proc/TestTaskObserverWatchpoint.java > @@ -346,7 +346,7 @@ extends TestLib > > // Make sure it triggered. > assertTrue("added", watch.added); > - assertEquals("hit code", 1, watch.hit); > + assertEquals("hit code", 2, watch.hit); > assertEquals("Task terminated", 1, to.hit); > } > > > > hooks/post-receive > -- > frysk system monitor/debugger >