From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3474 invoked by alias); 16 Apr 2008 08:05:08 -0000 Received: (qmail 3465 invoked by uid 22791); 16 Apr 2008 08:05:07 -0000 X-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 16 Apr 2008 08:04:50 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id m3G84mtM009996 for ; Wed, 16 Apr 2008 04:04:48 -0400 Received: from pobox-2.corp.redhat.com (pobox-2.corp.redhat.com [10.11.255.15]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m3G84ltp023240 for ; Wed, 16 Apr 2008 04:04:47 -0400 Received: from localhost.localdomain (vpn-14-87.rdu.redhat.com [10.11.14.87]) by pobox-2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m3G84kCk017441 for ; Wed, 16 Apr 2008 04:04:46 -0400 Message-ID: <4805B31D.1020808@redhat.com> Date: Wed, 16 Apr 2008 13:13:00 -0000 From: Phil Muldoon User-Agent: Thunderbird 2.0.0.12 (X11/20080226) MIME-Version: 1.0 To: frysk@sourceware.org Subject: Re: [SCM] master: Untangle read_only and source variables. References: <20080415160124.21987.qmail@sourceware.org> In-Reply-To: <20080415160124.21987.qmail@sourceware.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.58 on 172.16.52.254 X-IsSubscribed: yes Mailing-List: contact frysk-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: frysk-owner@sourceware.org X-SW-Source: 2008-q2/txt/msg00057.txt.bz2 This commit untangles the read only, and write funit-watchpoint.S operations so it will not affect other tests. Also actually read the value in read_only. Because the operations are untangled, the Continue test should only be hit once. Regards Phil pmuldoon@sourceware.org wrote: > The branch, master has been updated > via 31ece4d92880db8625f44f94f09688bb2704e449 (commit) > from f456c6b56d21b6d9b2f6921103ee6b0515b2cd15 (commit) > > Those revisions listed above that are new to this repository have > not appeared on any other notification email. > > - Log ----------------------------------------------------------------- > commit 31ece4d92880db8625f44f94f09688bb2704e449 > Author: Phil Muldoon > Date: Tue Apr 15 17:00:07 2008 +0100 > > Untangle read_only and source variables. > > 2008-04-15 Phil Muldoon > > * TestTaskObserverWatchpoint.java (testWatchpointActionContinue): Reset > expected hit count to 1. > > 2008-04-15 Phil Muldoon > > * funit-watchpoint.S: Don't add read_only to > source. > > ----------------------------------------------------------------------- > > Summary of changes: > frysk-core/frysk/pkglibdir/ChangeLog | 5 +++++ > frysk-core/frysk/pkglibdir/funit-watchpoint.S | 5 ++--- > frysk-core/frysk/proc/ChangeLog | 5 +++++ > .../frysk/proc/TestTaskObserverWatchpoint.java | 2 +- > 4 files changed, 13 insertions(+), 4 deletions(-) > > First 500 lines of diff: > diff --git a/frysk-core/frysk/pkglibdir/ChangeLog b/frysk-core/frysk/pkglibdir/ChangeLog > index d0090ce..c01e980 100644 > --- a/frysk-core/frysk/pkglibdir/ChangeLog > +++ b/frysk-core/frysk/pkglibdir/ChangeLog > @@ -1,3 +1,8 @@ > +2008-04-15 Phil Muldoon > + > + * funit-watchpoint.S: Don't add read_only to > + source. > + > 2008-04-14 Phil Muldoon > > * funit-watchpoint.S: Add new read_only WORD > diff --git a/frysk-core/frysk/pkglibdir/funit-watchpoint.S b/frysk-core/frysk/pkglibdir/funit-watchpoint.S > index cfb0f39..a8b39ee 100644 > --- a/frysk-core/frysk/pkglibdir/funit-watchpoint.S > +++ b/frysk-core/frysk/pkglibdir/funit-watchpoint.S > @@ -64,10 +64,9 @@ NOP > STORE_WORD(REG3, REG1) > NOP > > -NOP > -// Read read_only memory, and copy it to source > +// Read read_only memory. > LOAD_IMMED_WORD(REG3, read_only) > -STORE_WORD(REG3, REG1) > +LOAD_WORD(REG3, REG3) > NOP > > > diff --git a/frysk-core/frysk/proc/ChangeLog b/frysk-core/frysk/proc/ChangeLog > index a671460..ce16160 100644 > --- a/frysk-core/frysk/proc/ChangeLog > +++ b/frysk-core/frysk/proc/ChangeLog > @@ -1,3 +1,8 @@ > +2008-04-15 Phil Muldoon > + > + * TestTaskObserverWatchpoint.java (testWatchpointActionContinue): Reset > + expected hit count to 1. > + > 2008-04-14 Phil Muldoon > > * TestTaskObserverWatchpoint.java (testRunningAndReadOnlyWatchpoint): New. > diff --git a/frysk-core/frysk/proc/TestTaskObserverWatchpoint.java b/frysk-core/frysk/proc/TestTaskObserverWatchpoint.java > index 6650fe3..2fde8c2 100644 > --- a/frysk-core/frysk/proc/TestTaskObserverWatchpoint.java > +++ b/frysk-core/frysk/proc/TestTaskObserverWatchpoint.java > @@ -346,7 +346,7 @@ extends TestLib > > // Make sure it triggered. > assertTrue("added", watch.added); > - assertEquals("hit code", 2, watch.hit); > + assertEquals("hit code", 1, watch.hit); > assertEquals("Task terminated", 1, to.hit); > } > > > > hooks/post-receive > -- > frysk system monitor/debugger >