* fix for fhpd buglet
@ 2007-05-16 17:18 Tom Tromey
2007-05-17 17:17 ` Stan Cox
0 siblings, 1 reply; 3+ messages in thread
From: Tom Tromey @ 2007-05-16 17:18 UTC (permalink / raw)
To: Frysk List
I tried fhpd today and I noticed that if I typed Control-D at the
prompt, it threw a null pointer exception. Patch appended.
Tom
Index: frysk-core/frysk/bindir/ChangeLog
from Tom Tromey <tromey@redhat.com>
* fhpd.java (main): Exit loop if line==null.
Index: frysk-core/frysk/bindir/fhpd.java
===================================================================
RCS file: /cvs/frysk/frysk-core/frysk/bindir/fhpd.java,v
retrieving revision 1.8
diff -u -r1.8 fhpd.java
--- frysk-core/frysk/bindir/fhpd.java 3 May 2007 20:29:39 -0000 1.8
+++ frysk-core/frysk/bindir/fhpd.java 16 May 2007 16:56:15 -0000
@@ -125,7 +125,7 @@
reader.addCompletor(fhpdCompletor);
try {
cli.execCommand(line);
- while (! (line.equals("quit") || line.equals("q")))
+ while (line != null && ! (line.equals("quit") || line.equals("q")))
{
line = reader.readLine(cli.getPrompt());
cli.execCommand(line);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: fix for fhpd buglet
2007-05-16 17:18 fix for fhpd buglet Tom Tromey
@ 2007-05-17 17:17 ` Stan Cox
2007-05-18 6:33 ` Andrew Cagney
0 siblings, 1 reply; 3+ messages in thread
From: Stan Cox @ 2007-05-17 17:17 UTC (permalink / raw)
To: tromey; +Cc: Frysk List
On Wed, 2007-05-16 at 10:41 -0600, Tom Tromey wrote:
> Patch appended.
Thanks Tom. Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: fix for fhpd buglet
2007-05-17 17:17 ` Stan Cox
@ 2007-05-18 6:33 ` Andrew Cagney
0 siblings, 0 replies; 3+ messages in thread
From: Andrew Cagney @ 2007-05-18 6:33 UTC (permalink / raw)
To: Stan Cox; +Cc: tromey, Frysk List
Stan, can we add a corresponding test-case?
Stan Cox wrote:
> On Wed, 2007-05-16 at 10:41 -0600, Tom Tromey wrote:
>
>> Patch appended.
>>
>
> Thanks Tom. Applied.
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-05-17 18:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-05-16 17:18 fix for fhpd buglet Tom Tromey
2007-05-17 17:17 ` Stan Cox
2007-05-18 6:33 ` Andrew Cagney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).