Re: Patch: Add Option Groups

[Tom Tromey <tromey@redhat.com>]

>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:

Phil> I wanted to add option groups to fcore, and also make sure that the
Phil> utility options come first.  I've included a draft patch.

Looks good.

A few nits.

Phil> this happen. I have not checked it in. Please pay special attention to
Phil> my comments around parse() as I am not sure this is the best place to
Phil> add the default options. They have to be added "late" otherwise they
Phil> will be added at the top of the --help output.

Yeah, this is a bit odd, but I guess harmless for the time being.
Maybe it would be better to either push new functionality for this
kind of thing into Parser, or to have users of frysk's
CommandlineParser be a bit smarter about coordinating with the
superclass.

Phil> There is a lot of weird
Phil> indenting going on in the right help column, but this was happening
Phil> beforehand and is another unrelated (but hopefully soon to be fixed)
Phil> bug.

Some of this is accounted for by rogue spaces, e.g.:

Phil> +      group.add(new Option( "allmaps", 'a',
Phil> +	                          " Include ALL process readable maps.")

That space before "Include" is strange.

Phil> +				 "=PATTERN") {

Putting the "=" in here is wrong, fwiw.

Tom