From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11514 invoked by alias); 18 Mar 2008 18:28:32 -0000 Received: (qmail 11507 invoked by uid 22791); 18 Mar 2008 18:28:32 -0000 X-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 18 Mar 2008 18:28:14 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id m2IISDDc010224 for ; Tue, 18 Mar 2008 14:28:13 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [10.11.255.20]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m2IISC4a030853; Tue, 18 Mar 2008 14:28:12 -0400 Received: from opsy.redhat.com (vpn-15-31.rdu.redhat.com [10.11.15.31]) by pobox.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m2IISCGV011549; Tue, 18 Mar 2008 14:28:12 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id D4E91C8803D; Tue, 18 Mar 2008 11:34:38 -0600 (MDT) To: Phil Muldoon Cc: Frysk Hackers Subject: Re: Patch: Add Option Groups References: <47DFFE9D.80906@redhat.com> From: Tom Tromey Reply-To: Tom Tromey X-Attribution: Tom Date: Tue, 18 Mar 2008 18:28:00 -0000 In-Reply-To: <47DFFE9D.80906@redhat.com> (Phil Muldoon's message of "Tue\, 18 Mar 2008 17\:40\:45 +0000") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Scanned-By: MIMEDefang 2.58 on 172.16.52.254 X-IsSubscribed: yes Mailing-List: contact frysk-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: frysk-owner@sourceware.org X-SW-Source: 2008-q1/txt/msg00163.txt.bz2 >>>>> "Phil" == Phil Muldoon writes: Phil> I wanted to add option groups to fcore, and also make sure that the Phil> utility options come first. I've included a draft patch. Looks good. A few nits. Phil> this happen. I have not checked it in. Please pay special attention to Phil> my comments around parse() as I am not sure this is the best place to Phil> add the default options. They have to be added "late" otherwise they Phil> will be added at the top of the --help output. Yeah, this is a bit odd, but I guess harmless for the time being. Maybe it would be better to either push new functionality for this kind of thing into Parser, or to have users of frysk's CommandlineParser be a bit smarter about coordinating with the superclass. Phil> There is a lot of weird Phil> indenting going on in the right help column, but this was happening Phil> beforehand and is another unrelated (but hopefully soon to be fixed) Phil> bug. Some of this is accounted for by rogue spaces, e.g.: Phil> + group.add(new Option( "allmaps", 'a', Phil> + " Include ALL process readable maps.") That space before "Include" is strange. Phil> + "=PATTERN") { Putting the "=" in here is wrong, fwiw. Tom