From: Ian Lance Taylor <ian@cygnus.com>
To: joel@merlin.gcs.redstone.army.mil
Cc: gas2@cygnus.com
Subject: Re: gas dumps core
Date: Tue, 07 May 1996 08:24:00 -0000 [thread overview]
Message-ID: <199605071523.LAA12776@sanguine.cygnus.com> (raw)
In-Reply-To: <Pine.SV4.3.91.960507083045.7954E-100000@merlin>
Date: Tue, 7 May 1996 08:51:03 -0500 (CDT)
From: Joel Sherrill <joel@merlin.gcs.redstone.army.mil>
Here is all I know with a test case.
Snapshot: gas-960503
Configuration: m68k-coff
Test file (Yes it is the one line starting with a "#"):
# 1 ""
I've checked in this patch to fix this problem.
Ian
Index: config/obj-coff.c
===================================================================
RCS file: /cvs/cvsfiles/devo/gas/config/obj-coff.c,v
retrieving revision 1.114
diff -u -r1.114 obj-coff.c
--- obj-coff.c 1996/05/04 01:00:04 1.114
+++ obj-coff.c 1996/05/07 15:21:13
@@ -2726,7 +2726,8 @@
{
/* If the filename was too long to fit in the
auxent, put it in the string table */
- if (SA_GET_FILE_FNAME_ZEROS (symbolP) == 0)
+ if (SA_GET_FILE_FNAME_ZEROS (symbolP) == 0
+ && SA_GET_FILE_FNAME_OFFSET (symbolP) != 0)
{
SA_SET_FILE_FNAME_OFFSET (symbolP, string_byte_count);
string_byte_count += strlen (filename_list_scan->filename) + 1;
@@ -2978,7 +2979,8 @@
where += size;
}
if (S_GET_STORAGE_CLASS (symbolP) == C_FILE
- && SA_GET_FILE_FNAME_ZEROS (symbolP) == 0)
+ && SA_GET_FILE_FNAME_ZEROS (symbolP) == 0
+ && SA_GET_FILE_FNAME_OFFSET (symbolP) != 0)
{
size = strlen (filename_list_scan->filename) + 1;
memcpy (where, filename_list_scan->filename, size);
@@ -3535,7 +3537,7 @@
f->next = 0;
SA_SET_FILE_FNAME_ZEROS (symbolP, 0);
- SA_SET_FILE_FNAME_OFFSET (symbolP, 0);
+ SA_SET_FILE_FNAME_OFFSET (symbolP, 1);
if (filename_list_tail)
filename_list_tail->next = f;
prev parent reply other threads:[~1996-05-07 8:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
1996-05-07 7:11 Joel Sherrill
1996-05-07 8:24 ` Ian Lance Taylor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=199605071523.LAA12776@sanguine.cygnus.com \
--to=ian@cygnus.com \
--cc=gas2@cygnus.com \
--cc=joel@merlin.gcs.redstone.army.mil \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).