public inbox for gas2@sourceware.org
 help / color / mirror / Atom feed
From: Ian Lance Taylor <ian@cygnus.com>
To: joel@OARcorp.com
Cc: gas2@cygnus.com
Subject: Re: binutils 2.8.1 cpu32 bug
Date: Wed, 24 Sep 1997 10:42:00 -0000	[thread overview]
Message-ID: <199709241742.NAA05637@subrogation.cygnus.com> (raw)
In-Reply-To: <Pine.BSF.3.96.970915140301.341C-100000@vespucci.advicom.net>

   Date: Mon, 15 Sep 1997 14:05:26 -0500 (CDT)
   From: Joel Sherrill <joel@OARcorp.com>

   Here is a fix I received from an RTEMS user.  This was in binutils 2.8.1
   and I am not sure whether or not it has been fixed since.

   --joel

   =====================================================================
   *** binutils-2.8.1/opcodes/m68k-opc.c   Wed Aug  6 09:47:31 1997
   --- /usr/src/local/gnu/src/binutils-2.8.1.0.1/opcodes/m68k-opc.c      
      Wed Jul 23 21:09:13 1997
   ***************
   *** 1760,1766 ****

     #define TBL1(name,signed,round,size)                                  \
       {name, two(0174000, (signed<<11)|(!round<<10)|(size<<6)|0000400),   \
   !      two(0177700,0107777), "`sD1", cpu32 },                           \
       {name, two(0174000, (signed<<11)|(!round<<10)|(size<<6)),           \
	  two(0177770,0107770), "DsD3D1", cpu32 }
     #define TBL(name1, name2, name3, s, r) \
   --- 1760,1766 ----

     #define TBL1(name,signed,round,size)                                  \
       {name, two(0174000, (signed<<11)|(!round<<10)|(size<<6)|0000400),   \
   !      two(0177700,0107777), "@lD1", cpu32 },                           \
       {name, two(0174000, (signed<<11)|(!round<<10)|(size<<6)),           \
	  two(0177770,0107770), "DsD3D1", cpu32 }
     #define TBL(name1, name2, name3, s, r) \

I don't understand this patch, and I would need more information.  My
m680x0 book indicates that the original value is correct, since the
set of operands permitted for the tbl instructions are very limited.

   ***************
   *** 1825,1837 ****

     {"trapv",     one(0047166),   one(0177777), "", m68000up },

   ! {"tstb",      one(0045000),   one(0177700), ";b", m68020up | mcf5200 },
     {"tstb",      one(0045000),   one(0177700), "@b", m68000up },
   ! {"tstw",      one(0045100),   one(0177700), "*w", m68020up | mcf5200 },
   ! {"tstw",      one(0045110),   one(0177700), "As", cpu32 },
     {"tstw",      one(0045100),   one(0177700), "@w", m68000up },
   ! {"tstl",      one(0045200),   one(0177700), "*l", m68020up | mcf5200 },
   ! {"tstl",      one(0045210),   one(0177700), "As", cpu32 },
     {"tstl",      one(0045200),   one(0177700), "@l", m68000up },

     {"unlk",      one(0047130),   one(0177770), "As", m68000up | mcf5200 },
   --- 1825,1835 ----

     {"trapv",     one(0047166),   one(0177777), "", m68000up },

   ! {"tstb",      one(0045000),   one(0177700), ";b", m68020up |  
   mcf5200 | cpu32 },
     {"tstb",      one(0045000),   one(0177700), "@b", m68000up },
   ! {"tstw",      one(0045100),   one(0177700), "*w", m68020up |  
   mcf5200 | cpu32 },
     {"tstw",      one(0045100),   one(0177700), "@w", m68000up },
   ! {"tstl",      one(0045200),   one(0177700), "*l", m68020up |  
   mcf5200 | cpu32 },
     {"tstl",      one(0045200),   one(0177700), "@l", m68000up },

     {"unlk",      one(0047130),   one(0177770), "As", m68000up | mcf5200 },

I checked in a version of this patch.  Oddly, the original source does
not appear in my sources.  Thanks for sending it.

Ian

  reply	other threads:[~1997-09-24 10:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1997-09-15 12:05 Joel Sherrill
1997-09-24 10:42 ` Ian Lance Taylor [this message]
1997-09-24 14:08   ` Joel Sherrill
1997-09-24 15:42     ` Ian Lance Taylor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=199709241742.NAA05637@subrogation.cygnus.com \
    --to=ian@cygnus.com \
    --cc=gas2@cygnus.com \
    --cc=joel@OARcorp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).