public inbox for
 help / color / mirror / Atom feed
From: Doug Evans <>
Subject: ANSI strings, comment style, ...
Date: Tue, 04 Nov 1997 15:39:00 -0000	[thread overview]
Message-ID: <> (raw)

I'm working on adding this patch, but a few comments.

You're using ANSI C facilities to stop strings from running past
80 columns.  Someone correct me if I'm wrong but I believe
that's a no-no.  [Is it written down somewhere what, if any,
of ANSI C facilities one can use for GAS?  Should we set a timeframe for
when we'll start allowing such things?]

Also, I couldn't find a passage in the GNU coding conventions that explicitly
says so, but I think it's prefered that one write comments like this:

foo ()
  /* this is variable a, blah blah blah */
  int a;
  /* this is variable b, blah blah blah */
  int b;
  /* this is variable c, blah blah blah */
  int c;


rather than this:

foo ()
  int a;   /* this is variable a, blah blah blah */
  int b;   /* this is variable b, blah blah blah */
  int c;   /* this is variable c, blah blah blah */


[i.e. write comments on a line by themselves, above what they refer to,
rather than beside]

I've applied your commenting changes as is [the ones that reduce the
column width] but you may wish to switch over instead.

Mon Oct 27 21:44:30 1997  Ian Dall  <>

	* write.h (struct fix): comment fx_pcrel_adjust field.

	* write.c (print_fixup): Use TC_FIX_DATA_PRINT (if defined) to
	print out MD fields of fix.

	* frags.c (frag_var, frag_variant): Use TC_FRAG_INIT macro (if
 	defined) to initialize MD fields in frag.

	* doc/internals.texi (Frags): document fr_opcode_frag and
 	fr_opcode_offset fields. Documetn TC_PCREL_ADJUST macro.

	* config/tc-ns32k.h: Add comments. Remove obsolete
 	BFD_FAST_SECTION_FILL definition, change prototypes for
 	fix_new_ns32k and fix_new_ns32k_exp to add new arguments
 	opcode_frag and opcode_offset and remove
 	pcrel_adjust. (TC_FIX_TYPE): add opcode_fragP and opcode_offset
	(TC_FIX_DATA_PRINT): new macro to print out TC_FIX_TYPE.
	(TC_FRAG_INIT): new macro to initialize machine dependent field in
	(frag_opcode_frag, frag_opcode_offset, frag_bsr): macros to access
 	MD fields in frag structure.
	(fix_im_disp, fix_bit_fixP, fix_opcode_frag, fix_opcode_offset,
 	fix_bsr): macros to access MD fields in fix structure.

	* config/tc-ns32k.c: Avoid overlength lines. Align comments.  Don't
 	use struct opcode_location as these fields are now in the frag
 	structure. (convert_iif): Call frag_more as it is needed instead
 	of trying to allocate for the whole insn. Avoid call of frag_more
 	with negative argument. (md_pcrel_adjust, md_fix_pcrel_adjust,
 	md_apply_fix, md_estimate_size_before_relax, md_pcrel_from,
 	tc_aout_fix_to_chars): use accessor macros to get md fields in fix
 	and frag structures. (fix_new_ns32k, fix_new_ns32k_exp): add new
 	arguments opcode_frag and opcode_offset and remove pcrel_adjust.
	(convert_iif, cons_fix_new_ns32k): call fix_new_ns32k,
 	fix_new_ns32k_exp with changed arguments.

	* as.h: Move fragS typdef to before struct frag definition.
	Remove ns32k frag substructure and add fr_ns32k substructure.

             reply	other threads:[~1997-11-04 15:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1997-11-04 15:39 Doug Evans [this message]
1997-11-04 15:46 ` Ian Lance Taylor
1997-11-04 16:43   ` Ian Dall
1997-11-04 16:43     ` Ian Lance Taylor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).