From: Ian Lance Taylor <ian@cygnus.com>
To: hjl@lucon.org
Cc: rth@cygnus.com, gas2@cygnus.com
Subject: Re: An EH patch for gas
Date: Sat, 29 Aug 1998 12:13:00 -0000 [thread overview]
Message-ID: <199808291913.PAA16004@subrogation.cygnus.com> (raw)
In-Reply-To: <m0zClxj-000395C@ocean.lucon.org>
From: hjl@lucon.org (H.J. Lu)
Date: Sat, 29 Aug 1998 07:26:42 -0700 (PDT)
It is wrong to treat all 0x4 as DW_CFA_advance_loc4. .eh_frame can have
...
.byte 0x9a
.byte 0x4
.align 3
.4byte length
...
0x4 here is LEB128 for 0x9a. I believe this patch fixes the bug. Do you
have a better one?
Could you please send a complete test case? Your last test case was
only a partial file.
I don't know what the alignment is doing there, unless the 4 is at the
very end of an FDE. If that is the case, the correct patch is not the
look for .align directives, but instead to pay attention to the length
of the FDE.
Ian
prev parent reply other threads:[~1998-08-29 12:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
1998-08-29 7:27 H.J. Lu
1998-08-29 12:13 ` Ian Lance Taylor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=199808291913.PAA16004@subrogation.cygnus.com \
--to=ian@cygnus.com \
--cc=gas2@cygnus.com \
--cc=hjl@lucon.org \
--cc=rth@cygnus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).