From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Lance Taylor To: hjl@lucon.org Cc: rth@cygnus.com, gas2@cygnus.com Subject: Re: An EH patch for gas Date: Sat, 29 Aug 1998 12:13:00 -0000 Message-id: <199808291913.PAA16004@subrogation.cygnus.com> References: X-SW-Source: 1998/msg00213.html From: hjl@lucon.org (H.J. Lu) Date: Sat, 29 Aug 1998 07:26:42 -0700 (PDT) It is wrong to treat all 0x4 as DW_CFA_advance_loc4. .eh_frame can have ... .byte 0x9a .byte 0x4 .align 3 .4byte length ... 0x4 here is LEB128 for 0x9a. I believe this patch fixes the bug. Do you have a better one? Could you please send a complete test case? Your last test case was only a partial file. I don't know what the alignment is doing there, unless the 4 is at the very end of an FDE. If that is the case, the correct patch is not the look for .align directives, but instead to pay attention to the length of the FDE. Ian