public inbox for gas2@sourceware.org
 help / color / mirror / Atom feed
From: Franz Sirl <Franz.Sirl-kernel@lauterbach.com>
To: Ian Lance Taylor <ian@zembu.com>
Cc: gas2@sourceware.cygnus.com
Subject: Re: strip looses original file ownership and file permissions
Date: Thu, 06 May 1999 09:54:00 -0000	[thread overview]
Message-ID: <4.2.0.37.19990506183739.0372b0e0@mail.lauterbach.com> (raw)
In-Reply-To: <19990506162706.1409.qmail@daffy.airs.com>

At 18:27 06.05.99 , Ian Lance Taylor wrote:
>    Date: Thu, 06 May 1999 13:44:47 +0200
>    From: Franz Sirl <Franz.Sirl-kernel@lauterbach.com>
>
>    >I just verified that strip out of gas-990418 looses original 
> ownership and
>    >permissions of a file.
>    >This is on glibc-2.1.1pre2, Linux-2.2.6 (PPC).
>    >
>    >Is this platform specific or does anybody else notice this?
>
>    After a quick browse through the source I came up with the following
>    untested patch. Does it look right?
>
>It doesn't look right to me.
>
>We need to rename the file FROM to TO.  In the normal case of strip,
>FROM is a temporary file, and TO is the original file which we are
>stripping.  However, this function is also used in other cases.
>
>If TO does not exist, we should just use rename.  This is not the
>normal case of strip, but it happens in other cases.  Your patch
>breaks that.  That seems to be only significant change in your patch.
>Perhaps I am missing something.
>
>I think the only way to reliably preserve ownership is to avoid using
>rename.  Perhaps the code should be changed to call simple_copy when
>the owner of the file differs from the effective uid.

I think my patch produces the behavior that the comments are suggesting. 
The old code was bogus anyway, cause it tried to chmod/chown "to" after 
rename with values from a non-existing (exists != 0, this is really a 
bad-named variable, it's named the opposite of it's meaning) file.

Franz.

  reply	other threads:[~1999-05-06  9:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1999-05-06  3:48 Franz Sirl
1999-05-06  4:45 ` Franz Sirl
1999-05-06  9:27   ` Ian Lance Taylor
1999-05-06  9:54     ` Franz Sirl [this message]
1999-05-06 11:03       ` Ian Lance Taylor
1999-05-06 11:43         ` Franz Sirl
1999-05-06 13:57           ` Ian Lance Taylor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4.2.0.37.19990506183739.0372b0e0@mail.lauterbach.com \
    --to=franz.sirl-kernel@lauterbach.com \
    --cc=gas2@sourceware.cygnus.com \
    --cc=ian@zembu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).