Bug in gas line no. info, --target=iris

Bug in gas line no. info, --target=iris

[David Johnson]

Problem
-------

Gas appears to get the line number debugging information wrong for the
last ".loc" pseudo-op in a source file.

Also, if there's only one ".loc" pseudo-op in a file, it does not
appear in the line number information.

Version
-------

GNU assembler version 940706 (iris), using BFD version cygnus-2.3
(also apparent in gas-2.3)

Test program
------------

        .file   1 "test.s"
        .text
        .ent    test
test:
        .loc    1 1
        li      $2, 1
        .loc    1 2
        li      $2, 2
        .end    test

Output (Using IRIX 4.0.5H)
--------------------------

% as -g test.s -o test.o 
% mips-tdump -l test.o

.
.
        There are 2 bytes holding line numbers, starting at 220.
            Line           1,   delta     0,   count  1
            Line           2,   delta     1,   count  1
.
.

% gas -g test.s -o test.o
% mips-tdump -l test.o
.
.
        There are 2 bytes holding line numbers, starting at 320.
            Line           1,   delta     0,   count  1
            Line           1,   delta     0,   count 16
.
.

----------------------------------------------------------------
David Johnson
International Computer Science Institute

Bug in gas line no. info, --target=iris

[Ian Lance Taylor]

   From: davidj@ICSI.Berkeley.EDU (David Johnson)
   Date: Fri, 8 Jul 1994 17:50:37 -0700

   Gas appears to get the line number debugging information wrong for the
   last ".loc" pseudo-op in a source file.

Thanks for the bug report.  I believe this this patch will fix the
problem.

Ian

Index: ecoff.c
===================================================================
RCS file: /rel/cvsfiles/devo/gas/ecoff.c,v
retrieving revision 1.16
diff -p -r1.16 ecoff.c
*** ecoff.c	1994/07/08 19:37:57	1.16
--- ecoff.c	1994/07/09 04:04:51
*************** ecoff_build_lineno (backend, buf, bufend
*** 3600,3606 ****
  	 (in words).  Do this first, so that we can skip ahead to the
  	 next useful line number entry.  */
        if (l->next == (lineno_list_t *) NULL)
! 	count = 0;
        else
  	{
  	  count = ((l->next->frag->fr_address + l->next->paddr
--- 3600,3610 ----
  	 (in words).  Do this first, so that we can skip ahead to the
  	 next useful line number entry.  */
        if (l->next == (lineno_list_t *) NULL)
! 	{
! 	  /* We want a count of zero, but it will be decremented
! 	     before it is used.  */
! 	  count = 1;
! 	}
        else
  	{
  	  count = ((l->next->frag->fr_address + l->next->paddr