From: hjl@nynexst.com (H.J. Lu)
To: ian@cygnus.com (Ian Lance Taylor)
Cc: gas2@cygnus.com
Subject: Re: An old gas bug
Date: Wed, 17 Aug 1994 14:36:00 -0000 [thread overview]
Message-ID: <9408172135.AA21607@titanic.nynexst.com> (raw)
In-Reply-To: <199408171947.PAA12811@sanguine.cygnus.com>
> gas isn't my responsibility, but I think this fix is wrong. It
> appears to assume that the field holds a signed value. You can't make
> that assumption in the machine independent file write.c. Suppose the
> field were intended to hold an unsigned value, and the user tried to
> put 0x80 in it?
>
That is true. But, at least my patch won't generate bogus code :-(.
> I think this sort of thing needs to be checked in md_apply_fix.
>
> Ian
>
--
H.J. Lu
NYNEX Science and Technology, Inc. hjl@nynexst.com
next parent reply other threads:[~1994-08-17 14:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <199408171947.PAA12811@sanguine.cygnus.com>
1994-08-17 14:36 ` H.J. Lu [this message]
1994-08-16 16:04 H.J. Lu
1994-08-17 6:08 ` Michael Meissner
1994-08-17 6:16 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9408172135.AA21607@titanic.nynexst.com \
--to=hjl@nynexst.com \
--cc=gas2@cygnus.com \
--cc=ian@cygnus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).