From mboxrd@z Thu Jan  1 00:00:00 1970
From: hjl@nynexst.com (H.J. Lu)
To: ian@cygnus.com (Ian Lance Taylor)
Cc: gas2@cygnus.com
Subject: Re: An old gas bug
Date: Wed, 17 Aug 1994 14:36:00 -0000
Message-id: <9408172135.AA21607@titanic.nynexst.com>
References: <199408171947.PAA12811@sanguine.cygnus.com>
X-SW-Source: 1994/msg00072.html

> gas isn't my responsibility, but I think this fix is wrong.  It
> appears to assume that the field holds a signed value.  You can't make
> that assumption in the machine independent file write.c.  Suppose the
> field were intended to hold an unsigned value, and the user tried to
> put 0x80 in it?
> 

That is true. But, at least my patch won't generate bogus code :-(.

> I think this sort of thing needs to be checked in md_apply_fix.
> 
> Ian
> 


-- 
H.J. Lu
NYNEX Science and Technology, Inc.			hjl@nynexst.com