From: hjl@nynexst.com (H.J. Lu)
To: ian@sanguine.cygnus.com
Cc: gas2@cygnus.com
Subject: Typo in Fri Sep 23 15:15:31 1994 changes for elfcode.h
Date: Sun, 25 Sep 1994 17:37:00 -0000 [thread overview]
Message-ID: <9409260036.AA07497@titanic.nynexst.com> (raw)
Hi,
--
H.J. Lu
NYNEX Science and Technology, Inc. hjl@nynexst.com
---
Fri Sep 23 15:15:31 1994 Ian Lance Taylor (ian@sanguine.cygnus.com)
* elfcode.h (map_program_segments): Don't abort if we allocated
too much space for the program header, only if we allocated too
little.
(assign_file_positions_except_relocs): Similar change.
diff -u -r --new-file --show-function-line=^[A-Za-z_] /cygint/s1/users/raeburn/offsite/snap/old/gas-940923/bfd/elfcode.h ./bfd/elfcode.h
--- /cygint/s1/users/raeburn/offsite/snap/old/gas-940923/bfd/elfcode.h Wed Sep 14 12:08:35 1994
+++ ./bfd/elfcode.h Fri Sep 23 12:53:51 1994
@@ -1924,8 +1924,9 @@ map_program_segments (abfd, off, first,
}
/* Make sure the return value from get_program_header_size matches
- what we computed here. */
- if (phdr_count != phdr_size / sizeof (Elf_External_Phdr))
+ what we computed here. Actually, it's OK if we allocated too
+ much space in the program header. */
+ if (phdr_count > phdr_size / sizeof (Elf_External_Phdr))
abort ();
/* Set up program header information. */
@@ -2102,7 +2103,7 @@ assign_file_positions_except_relocs (abf
phdr_map = map_program_segments (abfd, phdr_off, first, phdr_size);
if (phdr_map == (file_ptr) -1)
return false;
- BFD_ASSERT (phdr_map == phdr_off + phdr_size);
+ BFD_ASSERT (phdr_map < phdr_off + phdr_size);
^^^
Should that be
+ BFD_ASSERT (phdr_map <= phdr_off + phdr_size);
}
/* Place the section headers. */
next reply other threads:[~1994-09-25 17:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
1994-09-25 17:37 H.J. Lu [this message]
1994-09-25 19:49 ` Ian Lance Taylor
1994-09-25 20:05 ` H.J. Lu
1994-09-25 23:25 ` Ken Raeburn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9409260036.AA07497@titanic.nynexst.com \
--to=hjl@nynexst.com \
--cc=gas2@cygnus.com \
--cc=ian@sanguine.cygnus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).