public inbox for gas2@sourceware.org
 help / color / mirror / Atom feed
From: hjl@nynexst.com (H.J. Lu)
To: davem@caip.rutgers.edu (David S. Miller)
Cc: ian@cygnus.com (Ian Lance Taylor), gas2@cygnus.com
Subject: A bug fix for common symbol in the ELF linker?
Date: Tue, 03 Oct 1995 19:26:00 -0000	[thread overview]
Message-ID: <9510040226.AA04911@nynexst.com> (raw)
In-Reply-To: <199510031557.LAA00698@huahaga.rutgers.edu>

Hi,

This is the patch for the common symbol bug in ELF I reported
earlier. I hope it won't break anything.

Thanks.

H.J.
===================================================================
RCS file: /home/cvs/gnu/binutils/bfd/elflink.h,v
retrieving revision 1.3
diff -c -r1.3 elflink.h
*** 1.3	1995/08/24 01:32:34
--- elflink.h	1995/10/04 02:15:07
***************
*** 153,159 ****
  				    false, false, false);
  	  if (h == (struct elf_link_hash_entry *) NULL)
  	    continue;
! 	  if (h->root.type != bfd_link_hash_undefined)
  	    {
  	      if (h->root.type != bfd_link_hash_undefweak)
  		defined[i] = true;
--- 153,161 ----
  				    false, false, false);
  	  if (h == (struct elf_link_hash_entry *) NULL)
  	    continue;
! 	  /* We should check both undef and common symbols. H.J. */
! 	  if (h->root.type != bfd_link_hash_undefined &&
! 		h->root.type != bfd_link_hash_common)
  	    {
  	      if (h->root.type != bfd_link_hash_undefweak)
  		defined[i] = true;


       reply	other threads:[~1995-10-03 19:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <199510031557.LAA00698@huahaga.rutgers.edu>
1995-10-03 19:26 ` H.J. Lu [this message]
1995-10-03 19:33   ` Ian Lance Taylor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9510040226.AA04911@nynexst.com \
    --to=hjl@nynexst.com \
    --cc=davem@caip.rutgers.edu \
    --cc=gas2@cygnus.com \
    --cc=ian@cygnus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).