public inbox for
 help / color / mirror / Atom feed
From: Philip Blundell <>
Subject: small patch for objdump
Date: Tue, 27 Oct 1998 08:47:00 -0000	[thread overview]
Message-ID: <> (raw)

I just found this change in my tree.  I made it some months ago to fix a 
problem with addresses above 0x80000000 being reported incorrectly when 
disassembling code.  Although I haven't tested versions later than the 2.9.1
release it looks like the problem is still there; would someone like to 
take a look?  Thanks.


1998-10-27  Philip Blundell  <>

	* objdump.c (disassemble_bytes): Make address variables unsigned
	to avoid problems when disassembling code at high-bit-set

diff -u --recursive --exclude CVS --new-file clean/binutils- binutils/binutils/objdump.c
--- clean/binutils-	Fri Apr 17 11:36:02 1998
+++ binutils/binutils/objdump.c	Mon Aug 17 11:28:40 1998
@@ -178,7 +178,7 @@
 static void
 disassemble_bytes PARAMS ((struct disassemble_info *, disassembler_ftype,
-			   boolean, bfd_byte *, long, long, arelent ***,
+			   boolean, bfd_byte *, unsigned long, unsigned long, arelent ***,
 			   arelent **));
 static void
@@ -1155,8 +1155,8 @@
      disassembler_ftype disassemble_fn;
      boolean insns;
      bfd_byte *data;
-     long start;
-     long stop;
+     unsigned long start;
+     unsigned long stop;
      arelent ***relppp;
      arelent **relppend;
@@ -1165,7 +1165,7 @@
   int bytes_per_line;
   boolean done_dot;
   int skip_addr_chars;
-  long i;
+  unsigned long i;
   aux = (struct objdump_disasm_info *) info->application_data;
   section = aux->sec;
@@ -1202,7 +1202,7 @@
   i = start;
   while (i < stop)
-      long z;
+      unsigned long z;
       int bytes;
       boolean need_nl = false;

             reply	other threads:[~1998-10-27  8:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1998-10-27  8:47 Philip Blundell [this message]
1998-10-27 14:42 Nick Clifton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).