public inbox for gas2@sourceware.org
 help / color / mirror / Atom feed
From: hjl@lucon.org (H.J. Lu)
To: ian@cygnus.com (Ian Lance Taylor)
Cc: gas2@cygnus.com, kunimart@pit.ktu.lt
Subject: Re: A PREFIX_SEPARATOR bug in binutils 2.9
Date: Tue, 21 Apr 1998 12:39:00 -0000	[thread overview]
Message-ID: <m0yRieU-00058vC@ocean.lucon.org> (raw)
In-Reply-To: <199804211911.PAA05010@subrogation.cygnus.com>

> Evidently gcc does not generate code of this form, or this would have
> been noticed long ago.
> 
> Note that there is another way to accomplish this:
> 	data16
> 	mov 	foo,%eax
> 
> I tried the test case
> 	data16/mov foo,%eax
> on the UnixWare assembler, and it failed there as well.  In fact, the
> reason gas uses '/' to start a comment for i386 ELF is because that is
> how the UnixWare assembler behaves.
> 
> Putting data16 on a separate line, as above, works with both gas and
> the UnixWare assembler.
> 
> I don't know if the UnixWare assembler permits you to specify a prefix
> on the same line as an instruction.  I tried a few other characters,
> but I couldn't find anything that worked.
> 
> So I'm not sure whether we need to change anything here.
> 

If we don't change, PREFIX_SEPARATOR is just a dummy for x86/ELF. If
someone writes some asm code for both ELF/a.out and use '/' as
PREFIX_SEPARATOR, the error may not be discovered at the assembly time.

Martynas Kunigelis <kunimart@pit.ktu.lt> found this while working on
16bit support in gas. Since PREFIX_SEPARATOR has never really been used
and has never worked, I suggest we change it to somethin else. Martynas
used '\\' for x86/ELF. But I don't like it. On the other hand, I haven't
found one I really like. I guess I can live with '\\'. We can just
define PREFIX_SEPARATOR as '\\' for all x86. At least, it will work
if someone really wants to use it.

Thanks.


-- 
H.J. Lu (hjl@gnu.org)

  reply	other threads:[~1998-04-21 12:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1998-04-21 11:41 H.J. Lu
1998-04-21 11:54 ` Ian Lance Taylor
1998-04-21 12:32   ` H.J. Lu
1998-04-21 12:39     ` Ian Lance Taylor
1998-04-21 12:39       ` H.J. Lu [this message]
1998-04-21 12:39         ` Ian Lance Taylor
1998-04-21 12:32           ` Martynas Kunigelis
1998-04-21 12:34             ` Ian Lance Taylor
1998-04-21 12:34           ` H.J. Lu
1998-04-21 12:39             ` Ian Lance Taylor
1998-04-21 17:45               ` Alan Modra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m0yRieU-00058vC@ocean.lucon.org \
    --to=hjl@lucon.org \
    --cc=gas2@cygnus.com \
    --cc=ian@cygnus.com \
    --cc=kunimart@pit.ktu.lt \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).