[Bug target/11229] New: pure-1.c fails on powerpc64-linux with -O1

[Bug target/11229] New: pure-1.c fails on powerpc64-linux with -O1

[janis187 at us dot ibm dot com]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11229

           Summary: pure-1.c fails on powerpc64-linux with -O1
           Product: gcc
           Version: 3.4
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: target
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: janis187@us.ibm.com
                CC: amodra@bigpond.net.au,gcc-bugs@gcc.gnu.org
GCC target triplet: powerpc64-unknown-linux-gnu

The test gcc.c-torture/execute/pure-1.c fails on
powerpc64-unknown-linux-gnu with -O1 and higher levels of optimization.
This happens with mainline, 3.3, and 3.2; I've never been able to build
earlier versions of GCC for this target.

Alan Modra described the problem and proposed a patch in
http://gcc.gnu.org/ml/gcc-patches/2003-03/msg02371.html; that patch
has never been reviewed.

This was tested with a cross compiler from powerpc-linux on a
powerpc64-linux system, which is the usual way to use GCC for this
target.

[Bug target/11229] pure-1.c fails on powerpc64-linux with -O1

[pinskia at physics dot uc dot edu]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11229


pinskia at physics dot uc dot edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2003-06-25 13:31:29
               date|                            |


------- Additional Comments From pinskia at physics dot uc dot edu  2003-06-25 13:31 -------
I can confirm on the mainline (20030625), this still happens.

[Bug target/11229] pure-1.c fails on powerpc64-linux with -O1

[dje at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11229



------- Additional Comments From dje at gcc dot gnu dot org  2003-07-12 23:51 -------
The patch should be reposted to gcc-patches as an "unreviewed" patch.

[Bug target/11229] pure-1.c fails on powerpc64-linux with -O1

[dhazeghi at yahoo dot com]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11229


dhazeghi at yahoo dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|3.4                         |---

[Bug target/11229] pure-1.c fails on powerpc64-linux with -O1

[amodra at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11229


amodra at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |amodra at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED
   Target Milestone|---                         |3.4

[Bug target/11229] pure-1.c fails on powerpc64-linux with -O1

[zack at gcc dot gnu dot org]

------- Additional Comments From zack at gcc dot gnu dot org  2003-12-02 00:22 -------
I would like to know for sure whether src_eqv_elt should have been set earlier.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11229

[Bug target/11229] pure-1.c fails on powerpc64-linux with -O1

[amodra at gcc dot gnu dot org]

------- Additional Comments From amodra at gcc dot gnu dot org  2003-12-02 02:28 -------
Probably not.  Looking over the code again, it appears to me that src_eqv_elt
should only be set when there is a REG_EQUAL note on an insn.

See also http://gcc.gnu.org/ml/gcc-patches/2003-08/msg01695.html

And what looks like a different approach to fixing the same problem:
http://gcc.gnu.org/ml/gcc-patches/2003-11/msg01611.html
I'm doing a build now to see if that's the case.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11229

[Bug target/11229] pure-1.c fails on powerpc64-linux with -O1

[amodra at gcc dot gnu dot org]

------- Additional Comments From amodra at gcc dot gnu dot org  2003-12-02 02:35 -------
Yes, http://gcc.gnu.org/ml/gcc-patches/2003-11/msg01611.html also fixes the
powerpc64-linux pure-1.c failures.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11229

[Bug target/11229] pure-1.c fails on powerpc64-linux with -O1

[amodra at gcc dot gnu dot org]

------- Additional Comments From amodra at gcc dot gnu dot org  2003-12-02 03:25 -------
Hmm, there are some interesting differences in the behaviour of the two patches.
 My patch allows cse to remove the dead calls to link_error*.  With Fariborz's
patch, the calls stay until combine cleans things up.  Also, -O1 code is better
with my patch as it allows life analysis to remove stores to i[0..7].


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11229

[Bug target/11229] pure-1.c fails on powerpc64-linux with -O1

[zack at gcc dot gnu dot org]

------- Additional Comments From zack at gcc dot gnu dot org  2003-12-02 04:19 -------
I think this patch is correct -- the ideal solution may be more complicated, but
let's not worry about that in stage 3.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11229

[Bug target/11229] pure-1.c fails on powerpc64-linux with -O1

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2003-12-03 11:10 -------
Subject: Bug 11229

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	amodra@gcc.gnu.org	2003-12-03 11:09:56

Modified files:
	gcc            : ChangeLog cse.c 

Log message:
	PR target/11229
	* cse.c (cse_insn): Set classp using src_const_elt if
	src_eqv_elt is NULL.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&r1=2.1899&r2=2.1900
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cse.c.diff?cvsroot=gcc&r1=1.276&r2=1.277



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11229

[Bug target/11229] pure-1.c fails on powerpc64-linux with -O1

[amodra at gcc dot gnu dot org]

------- Additional Comments From amodra at gcc dot gnu dot org  2003-12-03 11:13 -------
Patch committed for gcc-3.4

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11229

[Bug target/11229] pure-1.c fails on powerpc64-linux with -O1

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-01-31 12:38 -------
Subject: Bug 11229

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	hammer-3_3-branch
Changes by:	amodra@gcc.gnu.org	2004-01-31 12:38:28

Modified files:
	gcc            : ChangeLog.hammer cse.c 

Log message:
	Backport from mainline.
	2003-12-03  Alan Modra  <amodra@bigpond.net.au>
	PR target/11229
	* cse.c (cse_insn): Set classp using src_const_elt if
	src_eqv_elt is NULL.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.hammer.diff?cvsroot=gcc&only_with_tag=hammer-3_3-branch&r1=1.1.2.300&r2=1.1.2.301
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cse.c.diff?cvsroot=gcc&only_with_tag=hammer-3_3-branch&r1=1.243.2.7&r2=1.243.2.8



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11229