[Bug bootstrap/10129] Ada bootstrap fails on powerpc-apple-darwin6.4 - invalid assembler emitted

[Bug bootstrap/10129] Ada bootstrap fails on powerpc-apple-darwin6.4 - invalid assembler emitted

[dhazeghi@yahoo.com]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10129


dhazeghi@yahoo.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   GCC host triplet|                            |powerpc-apple-darwin6.4
 GCC target triplet|                            |powerpc-apple-darwin6.4


------- Additional Comments From dhazeghi@yahoo.com  2003-06-01 08:57 -------
Hello,

I can confirm that this problem is still present on gcc 3.3 branch and mainline (20030531).

Dara



------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug bootstrap/10129] Ada bootstrap fails on powerpc-apple-darwin6.4 - invalid assembler emitted

[dhazeghi@yahoo.com]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10129


dhazeghi@yahoo.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |shrao@nyx.net


------- Additional Comments From dhazeghi@yahoo.com  2003-06-01 23:16 -------
*** Bug 11046 has been marked as a duplicate of this bug. ***



------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

[Bug bootstrap/10129] Ada bootstrap fails on powerpc-apple-darwin6.4 - invalid assembler emitted

[bosch@gcc.gnu.org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10129


bosch@gcc.gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|shebs@gcc.gnu.org           |geoffk@gcc.gnu.org
           Severity|major                       |critical
             Status|ASSIGNED                    |NEW
   Target Milestone|---                         |3.3.1


------- Additional Comments From bosch@gcc.gnu.org  2003-06-09 18:34 -------
Geoff,

You seemed to have some insight in how this bug could be fixed. Could you see if you could 
produce a patch along the lines of what you described?

I'd be glad to do the testing etc. for you. This bug really hinders my work on GCC as my
laptop runs this configuration and I can't use it anymore for builds.

  -Geert

[Bug bootstrap/10129] Ada bootstrap fails on powerpc-apple-darwin6.4 - invalid assembler emitted

[bosch at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10129


bosch at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
   Last reconfirmed|0000-00-00 00:00:00         |2003-06-21 00:56:44
               date|                            |

[Bug bootstrap/10129] Ada bootstrap fails on powerpc-apple-darwin6.4 - invalid assembler emitted

[pinskia at physics dot uc dot edu]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10129



------- Additional Comments From pinskia at physics dot uc dot edu  2003-06-21 04:44 -------
A work around for the mainline is to compile gcc with -mdynamic-no-pic as I said in my email but 
I also wantted to put here so that someone else looking for the bug can see the workaround.

[Bug target/10129] Ada bootstrap fails on PPC-Darwin - invalid assembler emitted - PIC related

[pinskia at physics dot uc dot edu]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10129



------- Additional Comments From pinskia at physics dot uc dot edu  2003-07-02 05:00 -------
I was looking into this bug and it seems some how 
ada__exceptions__subprogram_descriptors is being marked as being defined (prefix of 
!D__) so the symbol is being used instead of a lazy pointer one being created and that 
one being used. Checking more to see it gets set as being defined.

[Bug target/10129] Ada bootstrap fails on PPC-Darwin - invalid assembler emitted - PIC related

[pinskia at physics dot uc dot edu]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10129



------- Additional Comments From pinskia at physics dot uc dot edu  2003-07-02 05:18 -------
The problem is that the Ada front end is marking 
ada__exceptions__subprogram_descriptors as common and having a DECL_INITIAL 
and that is what is causing it to be marked as defined which is wrong.
Fix in the works.

[Bug target/10129] Ada bootstrap fails on PPC-Darwin - invalid assembler emitted - PIC related

[pinskia at physics dot uc dot edu]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10129



------- Additional Comments From pinskia at physics dot uc dot edu  2003-07-02 14:28 -------
Okay, this cannot be reproduced at all with a C example.  The Ada Front-end converts its 
functions interweaved.  I think the fix here is to have a hashtable in 
machopic_function_base_name with each of the functions and the PIC strings.

[Bug target/10129] Ada bootstrap fails on PPC-Darwin - invalid assembler emitted - PIC related

[bosch at gnat dot com]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10129



------- Additional Comments From bosch at gnat dot com  2003-07-02 16:28 -------
Subject: Re:  Ada bootstrap fails on PPC-Darwin - invalid assembler emitted - PIC related

On Wednesday, Jul 2, 2003, at 10:28 America/New_York, pinskia at 
physics dot uc dot edu wrote:

> Okay, this cannot be reproduced at all with a C example.  The Ada 
> Front-end converts its functions interweaved.  I think the fix here is 
> to
> have a hashtable in machopic_function_base_name with each of the
> functions and the PIC strings.

Thanks a lot for your investigations, Andrew. That explains why all my
attempts to distill a C example for Geoffrey failed. What I don't
understand is whether this very target-specific bug has anything to
do with problems in the Ada front end, is a bug in the back end that
only gets triggered by Ada, or is a result of unclear back end / front 
end
interface. From your description so far, the problem seems to be in
the third category, but if that's the case we probably should also
strengthen the documentation (including comments) a bit.

Also, I think it would be useful at this point if we would be able to
add Ada tests to the GCC test suite, but I have absolutely no clue on
how to do that.

   -Geert

[Bug target/10129] Ada bootstrap fails on PPC-Darwin - invalid assembler emitted - PIC related

[pinskia at physics dot uc dot edu]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10129



------- Additional Comments From pinskia at physics dot uc dot edu  2003-07-02 16:43 -------
I think the reason why machopic_function_base_name was done the way without a hashtable was 
because the frontend Apple supported had the conversion to rtl interwoven so Apple only tested it 
with c, objective-c and c++.  But as we saw other frontends the conversion to rtl is interwoven but 
I do not really know if the Ada frontend is right to do this but I only working around the problem in 
Darwin's backend and removing the constraint of the rtl have been not interwoven.  
I wish someone figure out who is right here, I think the Ada frontend is right at what it is doing.

In fact I download the Ada compiler yesterday and get the first patch done within a hour.
The second one I had to figure out why the PIC labels were different between the one in the restore 
from the setjmp and the one in the function and that was just having gdb stop inside 
machopic_function_base_name when a label was generated and I say ali_scan_ali came up twice 
with another in between so I knew something was wrong (or right in the case for Ada) so I saw I 
could just store the function name and the label in a hashtable and lookup it up and see if there 
was alreay one there, I left the old way of finding the pic label so that the speed of gcc would not 
slow down too far.  I am running bootstrap right now on the patch but it should be past the old 
place of failure soon.

[Bug target/10129] Ada bootstrap fails on PPC-Darwin - invalid assembler emitted - PIC related

[pinskia at physics dot uc dot edu]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10129



------- Additional Comments From pinskia at physics dot uc dot edu  2003-07-02 16:57 -------
There is still more do to as it gets passed ali.adb were it was failing last time but now fails on 
atree, I will look into it some more.  This one might be caused by the inliner though.

[Bug target/10129] Ada bootstrap fails on PPC-Darwin - invalid assembler emitted - PIC related

[bosch at gnat dot com]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10129



------- Additional Comments From bosch at gnat dot com  2003-07-02 17:03 -------
Subject: Re:  Ada bootstrap fails on PPC-Darwin - invalid assembler emitted - PIC related


On Wednesday, Jul 2, 2003, at 12:57 America/New_York, pinskia at 
physics dot uc dot edu wrote:

> There is still more do to as it gets passed ali.adb were it was 
> failing last time but now fails on  atree, I will look into it some 
> more.
> This one might be caused by the inliner though.

Is this an assembler error too?

   -Geert

[Bug target/10129] Ada bootstrap fails on PPC-Darwin - invalid assembler emitted - PIC related

[pinskia at physics dot uc dot edu]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10129



------- Additional Comments From pinskia at physics dot uc dot edu  2003-07-02 17:05 -------
Yes this is another asm error:
atree.s:43299:non-relocatable subtraction expression, "L00000000617$pb" minus "LSJR2316"
atree.s:43299:symbol: "L00000000617$pb" can't be undefined in a subtraction expression
atree.s:43298:non-relocatable subtraction expression, "L00000000617$pb" minus "LSJR2316"
atree.s:43298:symbol: "L00000000617$pb" can't be undefined in a subtraction expression
atree.s:42878:non-relocatable subtraction expression, "L00000000614$pb" minus "LSJR2302"
atree.s:42878:symbol: "L00000000614$pb" can't be undefined in a subtraction expression
atree.s:42877:non-relocatable subtraction expression, "L00000000614$pb" minus "LSJR2302"
atree.s:42877:symbol: "L00000000614$pb" can't be undefined in a subtraction expression
atree.s:unknown:Undefined local symbol L00000000614$pb
atree.s:unknown:Undefined local symbol L00000000617$pb

[Bug target/10129] Ada bootstrap fails on PPC-Darwin - invalid assembler emitted - PIC related

[pinskia at physics dot uc dot edu]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10129



------- Additional Comments From pinskia at physics dot uc dot edu  2003-07-02 17:17 -------
Okay I think I figured out how this one is happening, now the problem is figuring out how to fix it.
The problem is the Darwin's backend depends on current_function_decl which Ada changes the 
name inside it for some reason to be one with a .n (where n is an integer). So the problem is the 
hashtable will not caught every thing so on when the setjmp is generated, current_function_decl is 
without the .n but when the function is generated it has a .n, so this is confusing Darwin's 
backend.  Now I do not know the currect fix at all and this problem seems to be needed to be fixed 
in the Ada frontend.

[Bug target/10129] Ada bootstrap fails on PPC-Darwin - invalid assembler emitted - PIC related

[geoffk at geoffk dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10129



------- Additional Comments From geoffk at geoffk dot org  2003-07-02 18:49 -------
Subject: Re:  Ada bootstrap fails on PPC-Darwin - invalid assembler emitted - PIC related

> Date: 2 Jul 2003 14:28:29 -0000
> From: "pinskia at physics dot uc dot edu" <gcc-bugzilla@gcc.gnu.org>

> Okay, this cannot be reproduced at all with a C example.  The Ada
> Front-end converts its functions interweaved.  I think the fix here
> is to have a hashtable in machopic_function_base_name with each of
> the functions and the PIC strings.

If you're going to touch that code at all, it would be better to just
defer the choosing of the name until the string is actually output
during final; make the name something like '<pic offset>', and
recognize that string during ASM_OUTPUT_*.  This code is already
horribly ugly and broken.

You can't keep the 'strings' in the hash table, because there is only
one; the entire design of the function relies on there being one
string that it changes.  Did I mention that it was horribly ugly and
broken?

[Bug target/10129] Ada bootstrap fails on PPC-Darwin - invalid assembler emitted - PIC related

[pinskia at physics dot uc dot edu]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10129


pinskia at physics dot uc dot edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|geoffk at gcc dot gnu dot   |pinskia at physics dot uc
                   |org                         |dot edu
   Target Milestone|3.3.1                       |3.3.2


------- Additional Comments From pinskia at physics dot uc dot edu  2003-07-10 03:14 -------
Moving to 3.3.2 because I will not get copyright assignments in time (I sent them in 
yesterday, 20030708) and taking over the bug because I have several patches which I 
am going to submit as I now have a working Ada compiler on my computer, one more 
patch than that is listed here and has been accepted which also fixes some C++ 
problems.

[Bug target/10129] Ada bootstrap fails on PPC-Darwin - invalid assembler emitted - PIC related

[pinskia at physics dot uc dot edu]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10129



------- Additional Comments From pinskia at physics dot uc dot edu  2003-07-16 19:56 -------
This is almost fixed on the mainline (one more patch needs to be accepted), I will ask again about 
it.  It was the first patch I submitted.

[Bug target/10129] Ada bootstrap fails on PPC-Darwin - invalid assembler emitted - PIC related

[pinskia at physics dot uc dot edu]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10129


pinskia at physics dot uc dot edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|critical                    |normal

[Bug target/10129] Ada bootstrap fails on PPC-Darwin - invalid assembler emitted - PIC related

[mmitchel at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10129


mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|3.3.2                       |---


------- Additional Comments From mmitchel at gcc dot gnu dot org  2003-09-05 06:54 -------
Ada bugs are not release critical; removing target milestone.

[Bug target/10129] Ada bootstrap fails on PPC-Darwin - invalid assembler emitted - PIC related

[pinskia at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10129


pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch
   Target Milestone|---                         |3.4


------- Additional Comments From pinskia at gcc dot gnu dot org  2003-10-30 07:17 -------
The patch needed to fix this is here: <http://gcc.gnu.org/ml/gcc-patches/2003-07/
msg00171.html>.

[Bug target/10129] Ada bootstrap fails on PPC-Darwin - invalid assembler emitted - PIC related

[bhunt at mac dot com]

------- Additional Comments From bhunt at mac dot com  2003-11-13 20:27 -------
The patches pointed to by this bug patch version 1.38 of darwin.c which is NOT the version 
released with gcc-3.3.2.  Would it be possible to get a patch for gcc-3.3.2 as I am hitting this 
problem when compiling c code with gcc 3.3.2.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10129

[Bug target/10129] Ada bootstrap fails on PPC-Darwin - invalid assembler emitted - PIC related

[dhazeghi at yahoo dot com]

------- Additional Comments From dhazeghi at yahoo dot com  2003-11-14 23:55 -------
Just to make clear: the fixes for this have not been applied to cvs yet. If somebody would review 
and apply them, that would of course be greatly appreciated :-)

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10129

[Bug target/10129] Ada bootstrap fails on PPC-Darwin - invalid assembler emitted - PIC related

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|3.4                         |3.5


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10129

[Bug target/10129] Ada bootstrap fails on PPC-Darwin - invalid assembler emitted - PIC related

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-02-08 06:34 -------
No longer mine (Ada might not be in 3.5.0 anyways).

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|pinskia at gcc dot gnu dot  |unassigned at gcc dot gnu
                   |org                         |dot org
             Status|ASSIGNED                    |NEW
   Target Milestone|3.5.0                       |---


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10129

[Bug target/10129] Ada bootstrap fails on PPC-Darwin - invalid assembler emitted - PIC related

[charlet at act-europe dot fr]

------- Additional Comments From charlet at act-europe dot fr  2004-02-08 12:43 -------
Subject: Re:  Ada bootstrap fails on PPC-Darwin - invalid assembler emitted - PIC related

> No longer mine (Ada might not be in 3.5.0 anyways).

It is fine to unassign bugs, however the 'anyways' should not be used as an
excuse for current bugs with current sources.

I'll do my best to have Ada included in 3.5.0, so please do not start
using this argument as an excuse for not looking at failures/regressions,
thanks :-)

Arno


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10129

[Bug target/10129] Ada bootstrap fails on PPC-Darwin - invalid assembler emitted - PIC related

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-04-08 17:17 -------
Subject: Bug 10129

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	pinskia@gcc.gnu.org	2004-04-08 17:17:27

Modified files:
	gcc            : ChangeLog 

Log message:
	2004-04-08  Andrew Pinski  <pinskia@physics.uc.edu>
	
	PR target/10129
	* config/darwin.c (darwin_encode_section_info): When the decl has
	a DECL_INITIAL, it is only defined also when it is not a common.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&r1=2.3362&r2=2.3363



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10129

[Bug target/10129] [3.4 only] Ada bootstrap fails on PPC-Darwin - invalid assembler emitted - PIC related

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-04-08 17:19 -------
Fix was applied to 3.5.0 currently queued for 3.4.1 as 3.4.0 is frozen right now.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |pinskia at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED
            Summary|Ada bootstrap fails on PPC- |[3.4 only] Ada bootstrap
                   |Darwin - invalid assembler  |fails on PPC-Darwin -
                   |emitted - PIC related       |invalid assembler emitted -
                   |                            |PIC related
   Target Milestone|---                         |3.4.1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10129

[Bug target/10129] [3.4 only] Ada bootstrap fails on PPC-Darwin - invalid assembler emitted - PIC related

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-04-22 16:36 -------
Mark, this is patch okay for the 3.4 branch, it has already been applied to the mainline, it 
fixes build Ada on powerpc-apple-darwin and has been in my tree for a long time.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mmitchel at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10129

[Bug target/10129] [3.4 only] Ada bootstrap fails on PPC-Darwin - invalid assembler emitted - PIC related

[mark at codesourcery dot com]

------- Additional Comments From mark at codesourcery dot com  2004-04-22 17:32 -------
Subject: Re:  [3.4 only] Ada bootstrap fails on PPC-Darwin
 - invalid assembler emitted - PIC related

pinskia at gcc dot gnu dot org wrote:

>------- Additional Comments From pinskia at gcc dot gnu dot org  2004-04-22 16:36 -------
>Mark, this is patch okay for the 3.4 branch, it has already been applied to the mainline, it 
>fixes build Ada on powerpc-apple-darwin and has been in my tree for a long time.
>  
>
Where is the version of the patch that was committed to mainline?  Is it 
the same patch that is in the PR?

That patch has a coding-style problem:

+      if (pic_labels_htab == NULL)
+        {
+          pic_labels_htab = htab_create_ggc (31, pic_named_entry_hash,
+                                          pic_entry_eq, NULL);
+        }

There should be no braces since there is only one dependent statement.

Furthermore:

+          /* I did not find the function in the hashtable, create a new label. */

is not a good comment; we avoid using "I" in comments in favor of "we".  
Or, even better, just say "The function was not in the hash table so a 
new label must be created."

As for applying the patch to the 3.4 branch, I will leave that up to a 
Darwin maintainer.  I'd probably be inclined not to apply it, but if a 
Darwin maintainer thinks it's worthwhile, that's OK with me.

Thanks,



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10129

[Bug target/10129] [3.4 only] Ada bootstrap fails on PPC-Darwin - invalid assembler emitted - PIC related

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-04-22 17:48 -------
Mark sorry not being clear on this one, the patch is which needed to checked in was at:
<http://gcc.gnu.org/ml/gcc-patches/2003-07/msg00171.html>.   The reason why I asking you 
because for the darwin maintainers are not as responsive as you are, as you can see that the patch was 
from july of last year but only got applied this month to the mainline.

The patch which you looked over was superseded by a different patch which was applied already to the 
mainline when it was 3.4.0.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10129

[Bug target/10129] [3.4 only] Ada bootstrap fails on PPC-Darwin - invalid assembler emitted - PIC related

[mark at codesourcery dot com]

------- Additional Comments From mark at codesourcery dot com  2004-04-22 17:59 -------
Subject: Re:  [3.4 only] Ada bootstrap fails on PPC-Darwin
 - invalid assembler emitted - PIC related

pinskia at gcc dot gnu dot org wrote:

>------- Additional Comments From pinskia at gcc dot gnu dot org  2004-04-22 17:48 -------
>Mark sorry not being clear on this one, the patch is which needed to checked in was at:
><http://gcc.gnu.org/ml/gcc-patches/2003-07/msg00171.html>.   The reason why I asking you 
>because for the darwin maintainers are not as responsive as you are, as you can see that the patch was 
>from july of last year but only got applied this month to the mainline.
>
>The patch which you looked over was superseded by a different patch which was applied already to the 
>mainline when it was 3.4.0.
>  
>
That's a simpler patch, certainly.  However, I still think a Darwin 
maintainer should sign off, since this is not a regression.  I am not 
enough of a Darwin expert to make a good determination.



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10129

[Bug target/10129] [3.4 only] Ada bootstrap fails on PPC-Darwin - invalid assembler emitted - PIC related

[bosch at gnat dot com]

------- Additional Comments From bosch at gnat dot com  2004-04-27 23:52 -------
Subject: Re:  [3.4 only] Ada bootstrap fails on PPC-Darwin - invalid assembler emitted - PIC related


On Apr 22, 2004, at 13:59, mark at codesourcery dot com wrote:
> That's a simpler patch, certainly.  However, I still think a Darwin
> maintainer should sign off, since this is not a regression.  I am not
> enough of a Darwin expert to make a good determination.

This is a regression, as explained in the beginning of the bug
report. Geoff checked in a change in the handling of PIC that broke
the Ada bootstrap. Since then various people, Andrew Pinsky most of
all, spent a lot of time trying to analyze/fix the issue. We really
should fix this regression, so Darwin will have a 3.4 based compiler
that includes Ada.

   -Geert



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10129

[Bug target/10129] [3.4 only] Ada bootstrap fails on PPC-Darwin - invalid assembler emitted - PIC related

[bhunt at mac dot com]

------- Additional Comments From bhunt at mac dot com  2004-04-28 00:00 -------
Note that the problem of generating invalid assembly on darwin is NOT ada specific.  I've run into the 
problem using the C++ compiler.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10129

[Bug target/10129] [3.4 only] Ada bootstrap fails on PPC-Darwin - invalid assembler emitted - PIC related

[mmitchel at gcc dot gnu dot org]

------- Additional Comments From mmitchel at gcc dot gnu dot org  2004-06-18 23:40 -------
Ada bugs are not showstoppers.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|3.4.1                       |---


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10129

[Bug target/10129] [3.4 only] Ada bootstrap fails on PPC-Darwin - invalid assembler emitted - PIC related

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-06-19 00:56 -------
Sp just closing as fixed for 3.5.0 then :(.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |3.5.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10129

Re: [Bug target/10129] [3.4 only] Ada bootstrap fails on PPC-Darwin - invalid assembler emitted - PIC related

[Geert Bosch]

It's really unfortunate as this bug is a regression reported
more than a year ago. September last year, the bug had been fixed,
but the fix went unreviewed and not approved for 3.3 as "Ada is not
release critical".

Now the same thing happens with 3.4. What criteria are being used
here to accept patches to fix Ada regressions? At 3.4 you said
wait for 3.4.1, now you're saying wait until... what time?

Basically, the message seems to be that if Geoffrey Keating breaks
Ada bootstrap that's fine. However, fixes to restore bootstrapping
cannot go in for another two major releases? Please explain.

There's a whole lot of difference between bugs
being release-critical and refusing to accept fixes
to restore bootstrap on a certain target.

   -Geert

On Jun 18, 2004, at 19:40, mmitchel at gcc dot gnu dot org wrote:
> ------- Additional Comments From mmitchel at gcc dot gnu dot org   
> 2004-06-18 23:40 -------
> Ada bugs are not showstoppers.
>
> --  
>            What    |Removed                     |Added
> ----------------------------------------------------------------------- 
> -----
>    Target Milestone|3.4.1                       |---
>
>
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10129
>
> ------- You are receiving this mail because: -------
> You reported the bug, or are watching the reporter.
> You are on the CC list for the bug, or are watching someone who is.
>

Re: [Bug target/10129] [3.4 only] Ada bootstrap fails on PPC-Darwin - invalid assembler emitted - PIC related

[Mark Mitchell]

Geert Bosch wrote:

> It's really unfortunate as this bug is a regression reported
> more than a year ago. September last year, the bug had been fixed,
> but the fix went unreviewed and not approved for 3.3 as "Ada is not
> release critical".
...
> Basically, the message seems to be that if Geoffrey Keating breaks
> Ada bootstrap that's fine. However, fixes to restore bootstrapping
> cannot go in for another two major releases? Please explain.

No, that's not the situation.  Here are my thoughts:

(1) Assuming that it was Geoff who broke the bootstrap (and I have not 
investigated, so I cannot say) then he has a responsibility to fix the 
problem.  The best mechanism we have is to make sure that Geoff knows 
about the problem and demonstrate that the problem was caused by his 
patch.  Usually, when it's obvious that a particular patch caused the 
problem, the person who committed that patch feels obligated to fix the 
problem, as that is the implicit oglibation of patch committers.

If you feel that a particular person is not doing enough to fix a 
problem that he or she caused, then you should contact that person, and, 
if absolutely necessary, contact the Steering Committee.

In this particular case, I don't see in the PR that anybody attributed 
the problem directly to one of Geoff's patches, so it's entirely 
possible that even if his patch was the cause, he had no knowledge of it.

(2) If there is a patch that solves the problem, then it would be good 
if that patch could be reviewed and committed.  However, there are some 
patches that I do not have the knowledge to review, and I have limited 
time; I do not consider it my obligation to review all patches.  If youi 
feel a patch is not being reviewed, the best thing you can do is contact 
the maintainers of that part of the compiler and ask them for a review, 
or, if absolutely necessary, contact the Steering Committee.

In Comment #30 in the PR trail, I specifically said the patch was OK for 
3.4.x if a Darwin maintainer would review it.  Apparently, that hasn't 
happened.  Did you contact them directly to ask for a review?

(3) The fact that I'm not holding up the release for this PR doesn't 
mean that I'm rejecting the patch; it just means that I'm not going to 
hold up the release for it.

-- 
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com

Re: [Bug target/10129] [3.4 only] Ada bootstrap fails on PPC-Darwin - invalid assembler emitted - PIC related

[Geert Bosch]

On Jun 19, 2004, at 00:05, Mark Mitchell wrote:
> In this particular case, I don't see in the PR that anybody attributed 
> the problem directly to one of Geoff's patches, so it's entirely 
> possible that even if his patch was the cause, he had no knowledge of 
> it.

It's all in the PR. My initial bug report has links to the original
patch that broke the bootstrap back in 2002, my initial report and
an analysis of the problem by Geoff.

Andrew Pinski has spent quite a bit of time on fixing the bug,
for which many thanks. He has sent many pings and I have done too.
Finally, the required patches are now on mainline, and I thought
you were the person to approve patches for 3.4.x.

   -Geert

Re: [Bug target/10129] [3.4 only] Ada bootstrap fails on PPC-Darwin - invalid assembler emitted - PIC related

[Mark Mitchell]

Geert Bosch wrote:

> Andrew Pinski has spent quite a bit of time on fixing the bug,
> for which many thanks. He has sent many pings and I have done too.
> Finally, the required patches are now on mainline, and I thought
> you were the person to approve patches for 3.4.x.

In the PR, I indicated that the patches are OK for 3.4.x if they were 
approved for mainline.

If Andrew, Geoff, or yourself will backport the patches to 3.4.x, that 
will be fine for 3.4.1 -- or, if that doesn't happen in time, 3.4.2.

-- 
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com

Re: [Bug target/10129] [3.4 only] Ada bootstrap fails on PPC-Darwin

[Andrew Pinski]

> 
> Geert Bosch wrote:
> 
> > Andrew Pinski has spent quite a bit of time on fixing the bug,
> > for which many thanks. He has sent many pings and I have done too.
> > Finally, the required patches are now on mainline, and I thought
> > you were the person to approve patches for 3.4.x.
> 
> In the PR, I indicated that the patches are OK for 3.4.x if they were 
> approved for mainline.
> 
> If Andrew, Geoff, or yourself will backport the patches to 3.4.x, that 
> will be fine for 3.4.1 -- or, if that doesn't happen in time, 3.4.2.

I must have misread what you wrote as I thought you wrote you wantted
explicant approval for 3.4.0 by a Darwin maintainter and not if it is
okayed for the mainline and it is okayed for 3.4, so I am just going
to apply the patch as I just bootstrapped 3.4 with it.

Sorry for misunderstanding,
Andrew Pinski

[Bug target/10129] [3.4 only] Ada bootstrap fails on PPC-Darwin - invalid assembler emitted - PIC related

[giovannibajo at libero dot it]

------- Additional Comments From giovannibajo at libero dot it  2004-06-19 12:03 -------
I can't understand. This bug is obviously a regression, there is an easy and 
simple patch which already went to mainline, so it should go to the branch 
automatically. You asked for further approval from Mark, and he deferred this 
to the Darwin maintainers.

Why did you close this bug as fixed? I would think the Darwin maintainers would 
like to have this regression fixed in 3.4 as well.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |giovannibajo at libero dot
                   |                            |it


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10129

[Bug target/10129] [3.4 only] Ada bootstrap fails on PPC-Darwin - invalid assembler emitted - PIC related

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-06-19 17:52 -------
Subject: Bug 10129

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	gcc-3_4-branch
Changes by:	pinskia@gcc.gnu.org	2004-06-19 17:52:43

Modified files:
	gcc            : ChangeLog 
	gcc/config     : darwin.c 

Log message:
	2004-06-19  Andrew Pinski  <pinskia@physics.uc.edu>
	
	PR target/10129
	* config/darwin.c (darwin_encode_section_info): When the decl has
	a DECL_INITIAL, it is only defined also when it is not a common.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=2.2326.2.512&r2=2.2326.2.513
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/config/darwin.c.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.55&r2=1.55.6.1



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10129

[Bug target/10129] [3.4 only] Ada bootstrap fails on PPC-Darwin - invalid assembler emitted - PIC related

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-06-19 17:53 -------
Fixed now for 3.4.1 sorry for the miss reading.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|3.5.0                       |3.4.1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10129