[Bug java/11502] New: fastjar error: "Error in JAR file format. zip-style comment?"

[Bug java/11502] New: fastjar error: "Error in JAR file format. zip-style comment?"

[dog at gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11502

           Summary: fastjar error: "Error in JAR file format. zip-style
                    comment?"
           Product: gcc
           Version: 3.3
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: java
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: dog at gnu dot org
                CC: gcc-bugs at gcc dot gnu dot org

When trying to extract or list the directory of a JAR file created by Eclipse
(among others), fastjar fails with the above message ("Error in JAR file format.
zip-style comment?").

jar --version :
jar (fastjar) 0.92-gcc

gcc -v :
Reading specs from /usr/local/lib/gcc-lib/powerpc-apple-darwin6.6/3.3/specs
Configured with: ../configure  : (reconfigured) ../configure --enable-libgcj
Thread model: single
gcc version 3.3

compiled for local host (mac os x 10.2.3).

[Bug java/11502] fastjar error: "Error in JAR file format. zip-style comment?"

[dog at gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11502



------- Additional Comments From dog at gnu dot org  2003-07-11 16:59 -------
Created an attachment (id=4390)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=4390&action=view)
GNU JavaMail (classpathx) mail.jar file generated by Eclipse

This jar file causes fastjar in gcc 3.3 to fail

[Bug java/11502] fastjar error: "Error in JAR file format. zip-style comment?"

[green at redhat dot com]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11502



------- Additional Comments From green at redhat dot com  2003-07-20 15:52 -------
Could you please double check mail.jar?

I am able to list and extract the contents of mail.jar with the fastjar in GCC
3.2, 3.3 and HEAD.   Perhaps this is a darwin specific problem.

[Bug java/11502] fastjar error: "Error in JAR file format. zip-style comment?"

[pinskia at physics dot uc dot edu]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11502


pinskia at physics dot uc dot edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |WAITING


------- Additional Comments From pinskia at physics dot uc dot edu  2003-07-20 16:03 -------
I could not reproduce it on the mainline (20030720) on powerpc-apple-darwin6.6 either:
jar --version
jar (fastjar) 0.92-gcc

Can you test it again?

[Bug java/11502] fastjar error: "Error in JAR file format. zip-style comment?"

[dog at gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11502



------- Additional Comments From dog at gnu dot org  2003-07-27 19:45 -------
Subject: Re:  fastjar error: "Error in JAR file format. zip-style comment?"

green at redhat dot com wrote:
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11502
> 
> 
> 
> ------- Additional Comments From green at redhat dot com  2003-07-20 15:52 -------
> Could you please double check mail.jar?
> 
> I am able to list and extract the contents of mail.jar with the fastjar in GCC
> 3.2, 3.3 and HEAD.   Perhaps this is a darwin specific problem.

pinskia at physics dot uc dot edu wrote:
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11502
> 
> 
> pinskia at physics dot uc dot edu changed:
> 
>            What    |Removed                     |Added
> ----------------------------------------------------------------------------
>              Status|UNCONFIRMED                 |WAITING
> 
> 
> ------- Additional Comments From pinskia at physics dot uc dot edu  2003-07-20 16:03 -------
> I could not reproduce it on the mainline (20030720) on powerpc-apple-darwin6.6 either:
> jar --version
> jar (fastjar) 0.92-gcc
> 
> Can you test it again?

tested again with same mail.jar, same result. sorry for the delay in
responding.

[Bug libgcj/11502] fastjar error: "Error in JAR file format. zip-style comment?"

[pinskia at physics dot uc dot edu]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11502



------- Additional Comments From pinskia at physics dot uc dot edu  2003-07-27 19:47 -------
What compiler are you using to bootstrap with?

[Bug libgcj/11502] fastjar error: "Error in JAR file format. zip-style comment?"

[dog at bluezoo dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11502



------- Additional Comments From dog at bluezoo dot org  2003-07-27 21:03 -------
Subject: Re:  fastjar error: "Error in JAR file format. zip-style comment?"

pinskia at physics dot uc dot edu wrote:
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11502
> 
> 
> 
> ------- Additional Comments From pinskia at physics dot uc dot edu  2003-07-27 19:47 -------
> What compiler are you using to bootstrap with?

apple's version of gcc for mac os x 10.2:

/usr/bin/gcc --version
gcc (GCC) 3.1 20020420 (prerelease)

[Bug libgcj/11502] fastjar error: "Error in JAR file format. zip-style comment?"

[pinskia at physics dot uc dot edu]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11502



------- Additional Comments From pinskia at physics dot uc dot edu  2003-07-27 21:06 -------
I think the problem looks like apple's gcc is producing wrong code so it is miscompiling jar.
Can you rebootstrap using the 3.3 compiler you already created and try again?

[Bug libgcj/11502] fastjar error: "Error in JAR file format. zip-style comment?"

[dog at bluezoo dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11502



------- Additional Comments From dog at bluezoo dot org  2003-07-29 20:03 -------
Subject: Re:  fastjar error: "Error in JAR file format. zip-style comment?"

pinskia at physics dot uc dot edu wrote:
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11502
> 
> 
> 
> ------- Additional Comments From pinskia at physics dot uc dot edu  2003-07-27 21:06 -------
> I think the problem looks like apple's gcc is producing wrong code so it is miscompiling jar.
> Can you rebootstrap using the 3.3 compiler you already created and try again?

i've done a clean build using the gcc build from 3.3 release. the built
(fast)jar still exhibits the same problem.

[Bug libgcj/11502] fastjar error: "Error in JAR file format. zip-style comment?"

[pinskia at physics dot uc dot edu]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11502



------- Additional Comments From pinskia at physics dot uc dot edu  2003-08-01 04:37 -------
Can you download the file which you attached and try it and make sure we have the 
same file?

[Bug libgcj/11502] fastjar error: "Error in JAR file format. zip-style comment?"

[dog at bluezoo dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11502



------- Additional Comments From dog at bluezoo dot org  2003-08-01 18:20 -------
Subject: Re:  fastjar error: "Error in JAR file format. zip-style comment?"

pinskia at physics dot uc dot edu wrote:
> Can you download the file which you attached and try it and make sure we have the 
> same file?

yup, same file.

are you using darwin or mac os x? could there be a difference?

[Bug libgcj/11502] fastjar error: "Error in JAR file format. zip-style comment?"

[pinskia at physics dot uc dot edu]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11502



------- Additional Comments From pinskia at physics dot uc dot edu  2003-08-01 18:23 -------
I am using Mac OS X 10.2.6.

[Bug libgcj/11502] fastjar error: "Error in JAR file format. zip-style comment?"

[pinskia at physics dot uc dot edu]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11502


pinskia at physics dot uc dot edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|3.4                         |---

[Bug libgcj/11502] fastjar error: "Error in JAR file format. zip-style comment?"

[dog at bluezoo dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11502



------- Additional Comments From dog at bluezoo dot org  2003-08-21 15:47 -------
Subject: Re:  fastjar error: "Error in JAR file format. zip-style comment?"

i have been experimenting a little more with this. these work:

  jar xvf mail.jar
  jar -xvf mail.jar

these don't:

  jar tvf mail.jar
  jar -tvf mail.jar

but these all do:

  jar tv <mail.jar
  jar -tv <mail.jar
  cat mail.jar | jar t

i am currently using fastjar 0.92-gcc from gcc-3.3.1 on
powerpc-apple-darwin6.6.

i can also reproduce the problem using fastjar 0.92-gcc from gcc-3.3.2
20030812 (Debian prerelease) on powerpc-unknown-linux-gnu, with exactly
the same failure pattern.

in all failure cases (darwin or linux) i have the same message.

[Bug libgcj/11502] fastjar error: "Error in JAR file format. zip-style comment?"

[pinskia at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11502



------- Additional Comments From pinskia at gcc dot gnu dot org  2003-08-21 16:01 -------
These all work for me on the mainline on powerpc-apple-darwin6.6 so I still cannot reproduce it.
I also cannot reproduce it on 3.3.1 (20030707) on i686-pc-linux-gnu.

[Bug libgcj/11502] fastjar error: "Error in JAR file format. zip-style comment?"

[dog at bluezoo dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11502



------- Additional Comments From dog at bluezoo dot org  2003-08-22 17:36 -------
Subject: Re:  fastjar error: "Error in JAR file format. zip-style comment?"

pinskia at gcc dot gnu dot org wrote:
> These all work for me on the mainline on powerpc-apple-darwin6.6 so I still cannot reproduce it.

the code where it fails (fastjar/jartool.c:1587-1594) goes:

  #ifdef WORDS_BIGENDIAN
    tmp = L2BI(tmp);
  #endif

  if(tmp != 0x06054b50){
    fprintf(stderr, "Error in JAR file format. zip-style comment?\n");
    exit(1);
  }

i have tested the value of tmp. it is 0x504b0506. WORDS_BIGENDIAN has
not been defined, and therefore L2BI is never called (it is never
even declared). however it seems relatively clear to me that it /should/
have been called, as powerpc is a bigendian architecture.

surely the Makefile for fastjar needs to define (or not)
WORDS_BIGENDIAN, as appropriate?

> I also cannot reproduce it on 3.3.1 (20030707) on i686-pc-linux-gnu.  

as far as i know it has always worked on i386, which is a little-endian
architecture in any case.

[Bug libgcj/11502] fastjar error: "Error in JAR file format. zip-style comment?"

[pinskia at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11502


pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |RESOLVED
         Resolution|                            |FIXED


------- Additional Comments From pinskia at gcc dot gnu dot org  2003-08-22 17:53 -------
WORDS_BIGENDIAN gets set by configure and put into config.h (at least in the mainline).

I think I know what is causing this: fastjar_AC_COMPILE_C_BIGENDIAN is not working correctly.
This is fixed on the mainline by using AC_C_BIGENDIAN_CROSS instead.
Which was this patch:
fastjar/

2002-11-22  H.J. Lu

        * acinclude.m4: Include ../config/accross.m4.
        (gcc_AC_COMPILE_CHECK_SIZEOF): Removed.
        (gcc_AC_EXAMINE_OBJECT): Removed.
        (gcc_AC_C_COMPILE_ENDIAN): Removed.
        * aclocal.m4; Rebuild.

2002-07-04  H.J. Lu

        * acinclude.m4: New.
        * configure.in: Replace AC_C_BIGENDIAN with AC_C_BIGENDIAN_CROSS.
        Replace AC_CHECK_SIZEOF with AC_COMPILE_CHECK_SIZEOF.
        * aclocal.m4; Rebuild.
        * configure: Likewise.

Since this is not a regression and it is fixed on the mainline and since libgcj was not really 
supported before 3.4 I am closing this as fixed.

[Bug libgcj/11502] fastjar error: "Error in JAR file format. zip-style comment?"

[pinskia at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11502


pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |3.4