[Bug c++/11493] New: [3.4 regression] tree check ICE in error.c

[Bug c++/11493] New: [3.4 regression] tree check ICE in error.c

[mueller at kde dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11493

           Summary: [3.4 regression] tree check ICE in error.c
           Product: gcc
           Version: 3.4
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: c++
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: mueller at kde dot org
                CC: gcc-bugs at gcc dot gnu dot org
 GCC build triplet: i686-pc-linux-gnu
  GCC host triplet: i686-pc-linux-gnu
GCC target triplet: i686-pc-linux-gnu

this is apparently a new regression introduced recently.  
 
output of g++ -v -c testcase.cpp : 
 
GNU C++ version 3.4 20030710 (experimental) (i686-pc-linux-gnu) 
        compiled by GNU C version 3.4 20030709 (experimental). 
GGC heuristics: --param ggc-min-expand=36 --param ggc-min-heapsize=11250 
kdirlister.cpp: In constructor `A<K>::A() [with K = N::C]': 
kdirlister.cpp:23:   instantiated from here 
kdirlister.cpp:16: internal compiler error: tree check: expected class 'd',  
   have 'r' (component_ref) in location_of, at cp/error.c:2156

[Bug c++/11493] [3.4 regression] tree check ICE in error.c

[mueller at kde dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11493


mueller at kde dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |ice-on-valid-code

[Bug c++/11493] [3.4 regression] tree check ICE in error.c

[mueller at kde dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11493



------- Additional Comments From mueller at kde dot org  2003-07-10 20:32 -------
Created an attachment (id=4380)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=4380&action=view)
testcase showing the problem.

[Bug c++/11493] [3.4 regression] tree check ICE in error.c

[pinskia at physics dot uc dot edu]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11493


pinskia at physics dot uc dot edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2003-07-10 20:39:18
               date|                            |


------- Additional Comments From pinskia at physics dot uc dot edu  2003-07-10 20:39 -------
I can confirm this in 3.4 (20030708)  but in 3.4 (20030131), it does not ICE in error.c (or cause 
retentry of the error routines) so this is a regression.

>From Phil's regression hunter:
: Search converges between 2003-07-07-trunk (#237) and 2003-07-08-trunk (#238)

[Bug c++/11493] [3.4 regression] tree check ICE in error.c

[mueller at kde dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11493


mueller at kde dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mark at codesourcery dot com


------- Additional Comments From mueller at kde dot org  2003-07-10 20:56 -------
most likely this commit is producing the regression. Currently testing without 
it to be sure.  
 
2003-07-08  Mark Mitchell  <mark@codesourcery.com> 
 
        * cp-tree.def (NON_DEPENDENT_EXPR): New node. 
        * cp-tree.h (build_call_from_tree): Remove. 
        (build_member_call): Likewise. 
        (dependent_template_arg_p): Remove. 
        (any_dependent_template_arguments_p): New function. 
        (dependent_template_id_p): Likewise. 
        (any_type_dependent_arguments_p): Likewise. 
        (build_non_dependent_expr): Likewise. 
        (build_non_dependent_args): Likewise. 
        (build_x_compound_expr): Adjust prototype. 
        * call.c (build_new_method_call): Handle non-dependent expressions 
        correctly. 
        * decl2.c (grok_array_decl): Likewise. 
        (build_offset_ref_call_from_tree): Likewise. 
        (build_call_from_tree): Remove. 
        * error.c (dump_decl): Handle NON_DEPENDENT_EXPR. 
        (dump_expr): Likewise. 
        * init.c (build_member_call): Remove. 
        * mangle.c (write_expression): Update handling for template-ids. 
        * parser.c (cp_parser_primary_expression): Use 
        any_dependent_template_arguments_p.  Update constant-expression 
        handling. 
        (cp_parser_postfix_expression): Use 
        any_type_dependent_arguments_p.  Simplify call processing. 
        (cp_parser_unary_expression): Simplify. 
        (cp_parser_expression): Adjust for changes to 
        build_x_compound_expr. 
        (cp_parser_template_argument): Implement standard-conforming 
        parsing of non-type template arguments. 
        (cp_parser_direct_declarator): Use 
        cp_parser_fold_non_dependent_expr. 
        (cp_parser_fold_non_dependent_expr): New function. 
        (cp_parser_next_token_ends_template_argument_p): Likewise. 
        * pt.c (convert_template_argument): Do not call 
        maybe_fold_nontype_arg. 
        (tsubst_baselink): Likewise. 
        (tsubst_copy_and_build): Share common code.  Make sizeof/alignof 
        processing work correctly for non-dependent expressions.  Adjust 
        handling of COMPOUND_EXPR.  Simplify call processing. 
        (value_dependent_expression_p): Deal with functional casts and 
        sizeof/alignof correctly. 
        (type_dependent_expression_p): Handle overloaded functions. 
        (any_type_dependent_arguments_p): New function. 
        (any_dependent_template_arguments_p): Likewise. 
        (dependent_template_p): Treat SCOPE_REFs as dependent. 
        (dependent_template_id_p): Simplify. 
        (build_non_dependent_expr): New function. 
        (build_non_dependent_args): Likewise. 
        * semantics.c (finish_stmt_expr): Don't make dependent 
        statement-expresions have void type. 
        (finish_call_expr): Handle non-dependent expressions 
        correctly. 
        * tree.c (lvalue_p_1): Treat NON_DEPENDENT_EXPRs as lvalues. 
        * typeck.c (cxx_sizeof_or_alignof_type): Give the expression 
        type size_t, even in templates. 
        (expr_sizeof): Likewise. 
        (finish_class_member_access_expr): Handle non-dependent expressions 
        correctly. 
        (build_x_indirect_ref): Likewise. 
        (build_x_binary_op): Likewise. 
        (build_x_unary_op): Likewise. 
        (build_x_conditional_expr): Likewise. 
        (build_x_compound_expr): Likewise. 
        * typeck2.c (build_x_arrow): Likewise.

[Bug c++/11493] [3.4 regression] tree check ICE in error.c

[bangerth at dealii dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11493



------- Additional Comments From bangerth at dealii dot org  2003-07-10 21:04 -------
Confirmed, too. I initially though it might have something to do with the
fact that the namespace and the local typedef have the same name. This
is not the case, as this example shows:
------------------------------
namespace NS {
    struct C {};
    void foo();
}

template <class T> struct X {};

template <class T> struct A {
    A() { foo (X<T>()); }
    void foo(X<T>);
};
template struct A<NS::C>;
------------------------------

This gives the same ICE. I think it has something to do with Koenig lookup,
though, and I think the compiler wants to tell us that the call to foo is
ambiguous (both of the foo functions are candidates, although only one has
the right signature for the call), since if I remove the foo in NS or rename
it, the problem goes away. Of course, the call is not ambiguous.

W.

[Bug c++/11493] [3.4 regression] tree check ICE in error.c

[bangerth at dealii dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11493



------- Additional Comments From bangerth at dealii dot org  2003-07-10 21:09 -------
I just filed another problem of which I believe it is related as PR 11495.

W.

[Bug c++/11493] [3.4 regression] tree check ICE in error.c

[mueller at kde dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11493



------- Additional Comments From mueller at kde dot org  2003-07-10 21:15 -------
oh, yeah. sorry. I was not checking closely about clashes during creating the 
testcase (stripping down from > 5000 lines of template code. ugh).  
 
the problem is the copy() function in the two different namespaces (with two 
different signatures). if you rename one the problem disappears.

[Bug c++/11493] [3.4 regression] tree check ICE in error.c

[pinskia at physics dot uc dot edu]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11493


pinskia at physics dot uc dot edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |critical
           Priority|P2                          |P1


------- Additional Comments From pinskia at physics dot uc dot edu  2003-07-10 21:31 -------
This is an ICE-on-valid-code regression and should be fixed before 3.4 is released.

[Bug c++/11493] [3.4 regression] tree check ICE in error.c

[mueller at kde dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11493



------- Additional Comments From mueller at kde dot org  2003-07-11 16:46 -------
ok, further testing showed it was this patch that broke it: 
 
2003-07-07  Mark Mitchell  <mark@codesourcery.com> 
 
        * cp-tree.h (build_scoped_method_call): Remove. 
        (lookup_qualified_name): Remove parameter. 
        (tsubst_copy_and_build): Declare. 
        (finish_qualified_object_call_expr): Remove. 
        (check_accessibility_of_qualified_id): New function. 
        (finish_qualified_id_expr): Likewise. 
        (non_reference): Likewise. 
        (build_expr_from-tree): Remove. 
        * call.c (non_reference): Remove. 
        (build_scoped_method_call): Likewise. 
        (build_method_call): Use error_operand_p.  Assert that we are not 
        processing a template. 
        (standard_conversion): Use non_reference. 
        * class.c (build_vtbl_entry_ref): Likewise. 
        (build_vtbl_ref_1): Likewise. 
        * cvt.c (build_expr_type_conversion): Use non_reference. 
        * decl.c (lookup_qualified_name): Remove flags parameter. 
        (grok_op_properties): Use non_reference. 
        * decl2.c (grok_array_decl): Likewise. 
        (build_expr_from_tree): Remove. 
        (build_offset_ref_call_from_tree): Update comment. 
        * error.c (parm_to_string): Call reinit_global_formatting_buffer. 
        * except.c (prepare_eh_types): Use non_reference. 
        (can_convert_eh): Likewise. 
        * init.c (build_dtor_call): Avoid using build_method_call. 
        * mangle.c (write_template_param): Remove misleading comment. 
        * method.c (locate_copy): Use non_reference. 
        * parser.c (cp_parser_scope_through_which_access_occurs): Remove. 
        (cp_parser_primary_expression): Do not create SCOPE_REFs is 
        non-dependent contexts. 
        (cp_parser_postfix_expression): Use finish_qualified_id_expr. 
        (cp_parser_direct_declarator): Use tsubst_copy_and_build, not 
        build_expr_from_tree. 
        (cp_parser_lookup_name): Adjust call to lookup_qualified_name. 
        Use check_accessibility_of_qualified_id. 
        * pt.c (maybe_fold_nontype_arg): Use tsubst_copy_and_build, not 
        build_expr_from_tree. 
        (tsubst_baselink): New function. 
        (tsubst_qualified_id): Likewise. 
        (tsubst_copy): Use them.  Remove support for METHOD_CALL_EXPR. 
        (tsubst_expr): Adjust call to lookup_qualified_name. 
        (tsubst_copy_and_build): Handle SCOPE_REFs specially.  Adjust 
        handling of CALL_EXPRs. 
        (value_dependent_expression_p): Use INTEGRAL_OR_ENUMERATION_TYPE_P. 
        * rtti.c (get_tinfo_decl_dynamic): Use non_reference. 
        * search.c (check_final_overrider): Likewise. 
        * semantics.c (check_accessibility_of_qualified_id): New function. 
        (finish_qualified_object_call_expr): Remove. 
        * typeck.c (target_type): Use non_reference. 
        (cxx_sizeof_or_alignof_type): Likewise. 
        (dubious_conversion_warnings): Likewise. 
        (convert_for_initialization): Likewise. 
        (non_reference): New function.

[Bug c++/11493] [3.4 regression] tree check ICE in error.c

[cvs-commit at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11493



------- Additional Comments From cvs-commit at gcc dot gnu dot org  2003-07-14 03:04 -------
Subject: Bug 11493

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	mmitchel@gcc.gnu.org	2003-07-14 03:04:29

Modified files:
	gcc/cp         : ChangeLog call.c cp-tree.h decl.c lex.c 
	                 parser.c pt.c semantics.c 
	gcc/testsuite  : ChangeLog 
	gcc/testsuite/g++.old-deja/g++.benjamin: tem03.C tem06.C 
	gcc/testsuite/g++.old-deja/g++.jason: overload33.C template36.C 
	gcc/testsuite/g++.old-deja/g++.mike: p1989.C 
	gcc/testsuite/g++.old-deja/g++.pt: lookup2.C ttp20.C ttp21.C 
	                                   typename13.C union2.C 
Added files:
	gcc/testsuite/g++.dg/parse: template9.C 
	gcc/testsuite/g++.dg/template: crash4.C koenig1.C 

Log message:
	* cp-tree.h (cp_id_kind): New type.
	(unqualified_name_lookup_error): Change prototype.
	(unqualified_fn_lookup_error): New function.
	(do_identifier): Remove.
	(do_scoped_id): Likewise.
	(tsubst_copy_and_build): Change prototype.
	(reregister_specialization): New function.
	(perform_koenig_lookup): Likewise.
	(finish_id_expression): Likewise.
	* call.c (build_method_call): Adjust call to
	unqualified_name_lookup_error.
	* decl.c (duplicate_decls): Use reregister_specialization.
	* lex.c (is_global): Remove.
	(unqualified_name_lookup_error): Return a value.
	(do_identifier): Remove.
	(do_scoped_id): Likewise.
	(identifier_typedecl_value): Remove.
	(unqualified_fn_lookup_error): New function.
	* parser.c (cp_parser_id_kind): Remove.
	(cp_parser_non_constant_id_expression): Remove.
	(cp_parser_primary_expression): Use finish_id_expression.
	(cp_parser_class_or_namespace_name): Use cp_id_kind, not
	cp_parser_id_kind.
	(cp_parser_postfix_expression): Use perform_koenig_lookup.
	(cp_parser_template_argument): Use cp_id_kind.
	(cp_parser_fold_non_dependent_expr): Adjust call to
	tsubst_copy_and_build.
	* pt.c (unregister_specialization): Rename to ...
	(reregister_specialization): This.
	(tsubst_friend_function): Use it.
	(maybe_fold_nontype_arg): Adjust call to tsubst_copy_and_build.
	(tsubst_qualified_id): Likewise.
	(tsubst_expr): Likewise.
	(tsubst_copy_and_build): Add function_p parameter.  Use
	finish_id_expression.  Introduce RECUR macro.
	(tsubst_non_call_postfix_expression): New function.
	(regenerate_decl_from_template): Use reregister_specialization.
	* semantics.c (perform_koenig_lookup): New function.
	(finish_id_expression): Likewise.
	
	PR c++/11493
	PR c++/11495
	* g++.dg/parse/template9.C: Likewise.
	* g++.dg/template/crash4.C: New test.
	* g++.dg/template/koenig1.C: Likewise.
	* g++.old-deja/g++.benjamin/tem03.C: Adjust error markers.
	* g++.old-deja/g++.benjamin/tem06.C: Declare "x".
	* g++.old-deja/g++.jason/overload33.C: Use this-> when calling
	functions.
	* g++.old-deja/g++.jason/template36.C: Likewise.
	* g++.old-deja/g++.mike/p1989.C: Likewise.
	* g++.old-deja/g++.pt/lookup2.C: Use -fpermissive when compiling.
	* g++.old-deja/g++.pt/ttp20.C: Use this->.
	* g++.old-deja/g++.pt/ttp21.C: Use this->.
	* g++.old-deja/g++.pt/typename13.C: Use -fpermissive when
	compiling.
	* g++.old-deja/g++.pt/union2.C: Use this->.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/ChangeLog.diff?cvsroot=gcc&r1=1.3514&r2=1.3515
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/call.c.diff?cvsroot=gcc&r1=1.404&r2=1.405
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/cp-tree.h.diff?cvsroot=gcc&r1=1.873&r2=1.874
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/decl.c.diff?cvsroot=gcc&r1=1.1087&r2=1.1088
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/lex.c.diff?cvsroot=gcc&r1=1.309&r2=1.310
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/parser.c.diff?cvsroot=gcc&r1=1.81&r2=1.82
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/pt.c.diff?cvsroot=gcc&r1=1.721&r2=1.722
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/semantics.c.diff?cvsroot=gcc&r1=1.325&r2=1.326
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&r1=1.2869&r2=1.2870
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/parse/template9.C.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/template/crash4.C.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/template/koenig1.C.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.old-deja/g++.benjamin/tem03.C.diff?cvsroot=gcc&r1=1.8&r2=1.9
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.old-deja/g++.benjamin/tem06.C.diff?cvsroot=gcc&r1=1.5&r2=1.6
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.old-deja/g++.jason/overload33.C.diff?cvsroot=gcc&r1=1.3&r2=1.4
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.old-deja/g++.jason/template36.C.diff?cvsroot=gcc&r1=1.4&r2=1.5
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.old-deja/g++.mike/p1989.C.diff?cvsroot=gcc&r1=1.6&r2=1.7
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.old-deja/g++.pt/lookup2.C.diff?cvsroot=gcc&r1=1.3&r2=1.4
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.old-deja/g++.pt/ttp20.C.diff?cvsroot=gcc&r1=1.3&r2=1.4
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.old-deja/g++.pt/ttp21.C.diff?cvsroot=gcc&r1=1.3&r2=1.4
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.old-deja/g++.pt/typename13.C.diff?cvsroot=gcc&r1=1.4&r2=1.5
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.old-deja/g++.pt/union2.C.diff?cvsroot=gcc&r1=1.3&r2=1.4

[Bug c++/11493] [3.4 regression] tree check ICE in error.c

[mmitchel at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11493


mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


------- Additional Comments From mmitchel at gcc dot gnu dot org  2003-07-14 03:05 -------
Fixed in GCC 3.4.