[Bug bootstrap/11516] New: [regression 3.4] ld: Unsatisfied symbol "get_attr_pa_combine_type" in file libbackend.a[pa.o]

[Bug bootstrap/11516] New: [regression 3.4] ld: Unsatisfied symbol "get_attr_pa_combine_type" in file libbackend.a[pa.o]

[danglin at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11516

           Summary: [regression 3.4] ld: Unsatisfied symbol
                    "get_attr_pa_combine_type" in file libbackend.a[pa.o]
           Product: gcc
           Version: 3.4
            Status: UNCONFIRMED
          Severity: critical
          Priority: P3
         Component: bootstrap
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: danglin at gcc dot gnu dot org
                CC: gcc-bugs at gcc dot gnu dot org
 GCC build triplet: hppa64-hppa-hpux11.11
  GCC host triplet: hppa64-hppa-hpux11.11
GCC target triplet: hppa64-hppa-hpux11.11

stage1/xgcc -Bstage1/ -B/opt/gnu64/hppa64-hp-hpux11.11/bin/   -g -O2 -DIN_GCC
-W -Wall -Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes -pedantic -Wno
-long-long -Werror -fno-common   -DHAVE_CONFIG_H  -o cc1 \
        c-parse.o c-lang.o c-pretty-print.o attribs.o c-errors.o c-lex.o c-pragm
a.o c-decl.o c-typeck.o c-convert.o c-aux-info.o c-common.o c-opts.o c-format.o
c-semantics.o c-incpath.o cppdefault.o c-ppoutput.o c-cppbuiltin.o prefix.o c-ob
jc-common.o c-dump.o c-pch.o libcpp.a  main.o libbackend.a ../libiberty/libibert
y.a
ld: Unsatisfied symbol "get_attr_pa_combine_type" in file libbackend.a[pa.o]
ld: Unsatisfied symbol "get_attr_type" in file libbackend.a[pa.o]
2 errors.
collect2: ld returned 1 exit status

[Bug bootstrap/11516] [3.4 egression] ld: Unsatisfied symbol "get_attr_pa_combine_type" in file libbackend.a[pa.o]

[pinskia at physics dot uc dot edu]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11516


pinskia at physics dot uc dot edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[regression 3.4] ld:        |[3.4 egression] ld:
                   |Unsatisfied symbol          |Unsatisfied symbol
                   |"get_attr_pa_combine_type"  |"get_attr_pa_combine_type"
                   |in file libbackend.a[pa.o]  |in file libbackend.a[pa.o]


------- Additional Comments From pinskia at physics dot uc dot edu  2003-07-14 01:56 -------
I think this is caused by Keating's patch for intermodule optimizations.
I could not reproduce this with a cross-compiler from powerpc-apple-darwin6.6 with the mainline.  
I also do not have access to HP-UX. Does the file insn-attrtab.c have the functions 
get_attr_pa_combine_type and get_attr_type defined in there?  Also does the line building the 
library libbackend.a have insn-attrtab.o included?  Also what does nm say for insn-attrtab.o, are 
get_attr_pa_combine_type and get_attr_type defined?

[Bug bootstrap/11516] [3.4 egression] ld: Unsatisfied symbol "get_attr_pa_combine_type" in file libbackend.a[pa.o]

[dave at hiauly1 dot hia dot nrc dot ca]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11516



------- Additional Comments From dave at hiauly1 dot hia dot nrc dot ca  2003-07-14 02:06 -------
Subject: Re:  [3.4 egression] ld: Unsatisfied symbol "get

> I also do not have access to HP-UX. Does the file insn-attrtab.c have the
> functions 
> get_attr_pa_combine_type and get_attr_type defined in there?  Also does the

The functions are present in insn-attrtab.c in stage 1 but not stage 2.

> line building the 
> library libbackend.a have insn-attrtab.o included?  Also what does nm say

Yes.

> for insn-attrtab.o, are 
> get_attr_pa_combine_type and get_attr_type defined?

They are in stage 1 but not stage 2.

Thanks for the suggestion as to which patch may have introduced the problem.
The port hasn't been buildable for the last several weeks due to one problem
after another, so it was going to be difficult to determine which patch
caused the regression.

Dave

[Bug bootstrap/11516] [3.4 egression] ld: Unsatisfied symbol "get_attr_pa_combine_type" in file libbackend.a[pa.o]

[pinskia at physics dot uc dot edu]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11516


pinskia at physics dot uc dot edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2003-07-14 02:11:58
               date|                            |


------- Additional Comments From pinskia at physics dot uc dot edu  2003-07-14 02:11 -------
Actually it does not look like his patch caused this because if it was his patch, then they would be 
present. It looks like genattrtab.c is being miscompiled.  Thanks for looking into the files because 
that narrowed down the search on what is going wrong.

[Bug bootstrap/11516] [3.4 egression] ld: Unsatisfied symbol "get_attr_pa_combine_type" in file libbackend.a[pa.o]

[dave at hiauly1 dot hia dot nrc dot ca]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11516



------- Additional Comments From dave at hiauly1 dot hia dot nrc dot ca  2003-07-14 04:32 -------
Subject: Re:  [3.4 egression] ld: Unsatisfied symbol "get

> present. It looks like genattrtab.c is being miscompiled.  Thanks for

Yes, the problem is limited to the 64-bit hpux port.

Dave

[Bug target/11516] [3.4 regression] miscompiled of genattrtab.c

[pinskia at physics dot uc dot edu]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11516


pinskia at physics dot uc dot edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |wrong-code
           Priority|P3                          |P1
            Summary|[3.4 regression] ld:        |[3.4 regression] miscompiled
                   |Unsatisfied symbol          |of genattrtab.c
                   |"get_attr_pa_combine_type"  |
                   |in file libbackend.a[pa.o]  |

[Bug target/11516] [3.4 regression] miscompiled of genattrtab.c in stage2

[pinskia at physics dot uc dot edu]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11516



------- Additional Comments From pinskia at physics dot uc dot edu  2003-07-15 20:13 -------
Can you try a bootstrap with the following patch reverted (it is also causing problems on 
sparc-sun-solaris2.8)?
2003-07-13  Kazu Hirata

        * combine.c (simplify_comparison): Convert (ne (and (not X) 1) 0)
        to (eq (and X 1) 0).
<http://gcc.gnu.org/ml/gcc-patches/2003-07/msg01358.html>
If that fixes it can you report to him that he also broke hppa64-hppa-hpux11.11 and 
pointing him to this bug report.

[Bug target/11516] [3.4 regression] miscompiled of genattrtab.c in stage2

[dave at hiauly1 dot hia dot nrc dot ca]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11516



------- Additional Comments From dave at hiauly1 dot hia dot nrc dot ca  2003-07-16 06:51 -------
Subject: Re:  [3.4 regression] miscompiled of genattrtab.c i

> Can you try a bootstrap with the following patch reverted (it is also
> causing problems on 
> sparc-sun-solaris2.8)?
> 2003-07-13  Kazu Hirata
> 
>         * combine.c (simplify_comparison): Convert (ne (and (not X) 1) 0)
>         to (eq (and X 1) 0).
> <http://gcc.gnu.org/ml/gcc-patches/2003-07/msg01358.html>
> If that fixes it can you report to him that he also broke
> hppa64-hppa-hpux11.11 and 
> pointing him to this bug report.

Reversing the patch seemed to have some effect on the problem.
get_attr_pa_combine_type is now generated in the stage2 version of
insn-attrtab.c.  However, get_attr_type is still missing:

ld: Unsatisfied symbol "get_attr_type" in file libbackend.a[pa.o]

Dave

[Bug target/11516] [3.4 regression] miscompiled of genattrtab.c in stage2

[danglin at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11516


danglin at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ghazi at caip dot rutgers
                   |                            |dot edu


------- Additional Comments From danglin at gcc dot gnu dot org  2003-07-20 07:29 -------
The regression was introduced by the following patch:

2003-07-08  Kaveh R. Ghazi  <ghazi@caip.rutgers.edu>

        * genattrtab.h: Add new macros for attr `special' flags.
        * genattrtab.c (attr_desc): Reorder/resize fields better.
        Use attr `special' macros in all calls to make_internal_attr.
        * genautomata.c: Likewise.

[Bug target/11516] [3.4 regression] miscompiled of genattrtab.c in stage2

[ghazi at caip dot rutgers dot edu]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11516



------- Additional Comments From ghazi at caip dot rutgers dot edu  2003-07-21 16:09 -------
Subject: Re:  [3.4 regression] miscompiled of genattrtab.c in stage2

 > The regression was introduced by the following patch:
 > 
 > 2003-07-08  Kaveh R. Ghazi  <ghazi@caip.rutgers.edu>
 > 
 >         * genattrtab.h: Add new macros for attr `special' flags.
 >         * genattrtab.c (attr_desc): Reorder/resize fields better.
 >         Use attr `special' macros in all calls to make_internal_attr.
 >         * genautomata.c: Likewise.


Hmmm, while you may have first seen a problem after my patch was
introduced, I can't see how the patch could be the root cause of any
problem you have.  There must be something elsewhere where the bug
lies.  As you said, the problem is in stage2 so there is a deeper
miscompilation occuring IMHO.  I understand and support our policy
regarding one patch uncovering a latent bug elsewhere, but the changes
I introduce are so innocuous that I believe you should fix the root
cause rather than invoke the policy to remove my patch.

As a test I reverted these two patches:
http://gcc.gnu.org/ml/gcc-patches/2003-07/msg00653.html
http://gcc.gnu.org/ml/gcc-patches/2003-07/msg00575.html

and built insn-attrtab.c in a cross-configuration targetted to
hppa64-hppa-hpux11.11.  The differences in the generated file from the
reverted case and current CVS are all expected and simple.  Some
redundant prototypes are removed, `internal_dfa_insn_code' is made
static and `internal_reset' in made inline.  No other changes.

If I can be of assistance let me know, but I don't have access to hpux
so I can't investigate a stage2 miscompilation.


--- hpux-revert/build/gcc/insn-attrtab.c	2003-07-21 11:40:08.203855000 -0400
+++ hpux-current/build/gcc/insn-attrtab.c	2003-07-21 11:41:01.238773000 -0400
@@ -21,3 +21,2 @@ from the machine description file `md'. 
 
-extern int insn_current_length (rtx);
 int
@@ -584,3 +583,2 @@ insn_current_length (rtx insn ATTRIBUTE_
 
-extern int insn_variable_length_p (rtx);
 int
@@ -633,3 +631,2 @@ insn_variable_length_p (rtx insn ATTRIBU
 
-extern int insn_default_length (rtx);
 int
@@ -992,3 +989,2 @@ insn_default_length (rtx insn ATTRIBUTE_
 
-extern int bypass_p (rtx);
 int
@@ -1184,3 +1180,2 @@ bypass_p (rtx insn ATTRIBUTE_UNUSED)
 
-extern int insn_default_latency (rtx);
 int
@@ -1995,3 +1990,2 @@ insn_default_latency (rtx insn ATTRIBUTE
 #if AUTOMATON_ALTS
-extern int insn_alts (rtx);
 int
@@ -2673,4 +2667,3 @@ insn_alts (rtx insn ATTRIBUTE_UNUSED)
 
-extern int internal_dfa_insn_code (rtx);
-int
+static int
 internal_dfa_insn_code (rtx insn ATTRIBUTE_UNUSED)
@@ -4314,3 +4307,2 @@ internal_dfa_insn_code (rtx insn ATTRIBU
 
-extern int result_ready_cost (rtx);
 int
@@ -4330,3 +4322,2 @@ result_ready_cost (rtx insn ATTRIBUTE_UN
 
-extern int function_units_used (rtx);
 int
@@ -4346,3 +4337,2 @@ function_units_used (rtx insn ATTRIBUTE_
 
-extern int num_delay_slots (rtx);
 int
@@ -4432,3 +4422,2 @@ num_delay_slots (rtx insn ATTRIBUTE_UNUS
 
-extern enum attr_in_call_delay get_attr_in_call_delay (rtx);
 enum attr_in_call_delay
@@ -4646,3 +4635,2 @@ get_attr_in_call_delay (rtx insn ATTRIBU
 
-extern enum attr_in_nullified_branch_delay get_attr_in_nullified_branch_delay (rtx);
 enum attr_in_nullified_branch_delay
@@ -4870,3 +4858,2 @@ get_attr_in_nullified_branch_delay (rtx 
 
-extern enum attr_in_branch_delay get_attr_in_branch_delay (rtx);
 enum attr_in_branch_delay
@@ -5074,3 +5061,2 @@ get_attr_in_branch_delay (rtx insn ATTRI
 
-extern enum attr_pa_combine_type get_attr_pa_combine_type (rtx);
 enum attr_pa_combine_type
@@ -5116,3 +5102,2 @@ get_attr_pa_combine_type (rtx insn ATTRI
 
-extern enum attr_type get_attr_type (rtx);
 enum attr_type
@@ -12268,3 +12253,3 @@ state_size (void)
 
-static void
+static inline void
 internal_reset (struct DFA_chip *chip)

[Bug target/11516] [3.4 regression] miscompiled of genattrtab.c in stage2

[dave at hiauly1 dot hia dot nrc dot ca]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11516



------- Additional Comments From dave at hiauly1 dot hia dot nrc dot ca  2003-07-21 16:37 -------
Subject: Re:  [3.4 regression] miscompiled of genattrtab.c i

> Hmmm, while you may have first seen a problem after my patch was
> introduced, I can't see how the patch could be the root cause of any
> problem you have.  There must be something elsewhere where the bug

Yes, your patch is not the problem.  It's was a problem I introduced
a couple of days before :(  The main was a real mess at the time and
it was difficult to determine what the cause was.  Your patch just
changed the symptoms.  I'm testing a fix now.

Thanks for your comments.

Dave

[Bug target/11516] [3.4 regression] miscompiled of genattrtab.c in stage2

[cvs-commit at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11516



------- Additional Comments From cvs-commit at gcc dot gnu dot org  2003-07-23 15:18 -------
Subject: Bug 11516

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	gcc-3_3-branch
Changes by:	danglin@gcc.gnu.org	2003-07-23 15:18:38

Modified files:
	gcc            : ChangeLog 
	gcc/config/pa  : pa.md 

Log message:
	PR target/11607 and PR target/11516
	* pa.md (extzv, extv, insv): Revert latter half of last patch.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-3_3-branch&r1=1.16114.2.683&r2=1.16114.2.684
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/config/pa/pa.md.diff?cvsroot=gcc&only_with_tag=gcc-3_3-branch&r1=1.116.2.10&r2=1.116.2.11

[Bug target/11516] [3.4 regression] miscompiled of genattrtab.c in stage2

[cvs-commit at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11516



------- Additional Comments From cvs-commit at gcc dot gnu dot org  2003-07-23 15:53 -------
Subject: Bug 11516

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	danglin@gcc.gnu.org	2003-07-23 15:53:31

Modified files:
	gcc            : ChangeLog 
	gcc/config/pa  : pa.md 

Log message:
	PR target/11607 and PR target/11516
	* pa.md (extzv, extv, insv): Revert latter half of last patch.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&r1=2.600&r2=2.601
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/config/pa/pa.md.diff?cvsroot=gcc&r1=1.127&r2=1.128

[Bug target/11516] [3.4 regression] miscompiled of genattrtab.c in stage2

[danglin at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11516


danglin at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


------- Additional Comments From danglin at gcc dot gnu dot org  2003-07-23 16:11 -------
Fixed.
http://gcc.gnu.org/ml/gcc-patches/2003-07/msg02312.html

[Bug target/11516] [3.4 regression] miscompiled of genattrtab.c in stage2

[jbuck at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11516


jbuck at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|3.4                         |3.3.1