[Bug other/11673] New: libmudflap does not compile

[Bug other/11673] New: libmudflap does not compile

[lsjoberg at aland dot net]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11673

           Summary: libmudflap does not compile
           Product: gcc
           Version: tree-ssa
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: other
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: lsjoberg at aland dot net
                CC: gcc-bugs at gcc dot gnu dot org
 GCC build triplet: i386-unknown-freebsd4.8
  GCC host triplet: i386-unknown-freebsd4.8
GCC target triplet: i386-unknown-freebsd4.8

There are a numerous number of problems with libmudflap which break FreeBSD bootstrapping.

See http://gcc.gnu.org/ml/gcc/2003-06/msg02511.html for details.


Furthermore the current cvs-version also bangs with
/stuff/gcc.obj/gcc/xgcc -B/stuff/gcc.obj/gcc/ -B/stuff/gcc.install/i386-unknown-freebsd4.8/bin/ -B/stuff/gcc.install/i386-unknown-freebsd4.8/lib/ -isystem /stuff/gcc.install/i386-unknown-freebsd4.8/include -isystem /stuff/gcc.install/i386-unknown-freebsd4.8/sys-include -DHAVE_CONFIG_H -I. -I../../../gcc/libmudflap -I. -O2 -g -O2 -Wall -O2 -g -O2 -DLIBMUDFLAPTH -DWRAP_pthreadstuff -c ../../../gcc/libmudflap/mf-hooks3.c  -fPIC -DPIC -o pth/.libs/pthreadstuff-hook.o
../../../gcc/libmudflap/mf-hooks3.c: In function `pthread_create':
../../../gcc/libmudflap/mf-hooks3.c:404: error: `MAP_ANONYMOUS' undeclared (first use in this function)
../../../gcc/libmudflap/mf-hooks3.c:404: error: (Each undeclared identifier is reported only once
../../../gcc/libmudflap/mf-hooks3.c:404: error: for each function it appears in.)


[linus@hal9000 ~]$ uname -a
FreeBSD hal9000.alcom.aland.fi 4.8-STABLE FreeBSD 4.8-STABLE #5: Fri Jul  4 11:24:45 EEST 2003     root@hal9000.alcom.aland.fi:/usr/obj/usr/src/sys/HAL  i386
[linus@hal9000 ~]$

[Bug other/11673] libmudflap does not compile on other than *-*-linux-gnu

[pinskia at physics dot uc dot edu]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11673


pinskia at physics dot uc dot edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
 GCC target triplet|i386-unknown-freebsd4.8     |*-*-* except *-*-linux-gnu
           Keywords|                            |build
   Last reconfirmed|0000-00-00 00:00:00         |2003-07-25 14:34:53
               date|                            |
            Summary|libmudflap does not compile |libmudflap does not compile
                   |                            |on other than *-*-linux-gnu
   Target Milestone|3.4                         |tree-ssa


------- Additional Comments From pinskia at physics dot uc dot edu  2003-07-25 14:34 -------
Looks like libmudflap is only supported on GNU/Linux and does not have enough 
configure magic to support it on other targets because I have the same problem on 
powerpc-apple-darwin6.6.

[Bug other/11673] libmudflap does not compile on other than *-*-linux-gnu

[fche at redhat dot com]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11673


fche at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |fche at redhat dot com
                   |dot org                     |
             Status|NEW                         |ASSIGNED


------- Additional Comments From fche at redhat dot com  2003-07-25 15:03 -------
Created an attachment (id=4478)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=4478&action=view)
MAP_ANON support

[Bug other/11673] libmudflap does not compile on freebsd

[fche at redhat dot com]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11673


fche at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|libmudflap does not compile |libmudflap does not compile
                   |on other than *-*-linux-gnu |on freebsd


------- Additional Comments From fche at redhat dot com  2003-07-25 15:05 -------
The previous summary line was rather pessimistic.  The code is periodically
tested on other platforms, but clearly not all.  That's why we need the
help of people that try to build on oddball :-) hosts.
Please try the attached patch.

[Bug other/11673] libmudflap does not compile on freebsd

[lsjoberg at aland dot net]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11673



------- Additional Comments From lsjoberg at aland dot net  2003-07-25 15:47 -------
With the patch applied that specific wrapper compiles fine.

The remaining problems are:
* WRAP_stat64 failes since there is no syscall stat64
* WRAP_fseeko64 failes since there is no syscall fseeko64
* WRAP_ftello64 failes since there is no syscall ftello64
* WRAP_semctl gives a 'error: redefinition of `union semun''
* _POSIX_SOURCE introduces a problem with sa_family_t since u_char is undefined.

See 
http://gcc.gnu.org/ml/gcc/2003-06/msg02490.html
http://gcc.gnu.org/ml/gcc/2003-06/msg02490.html
for all the details.

[Bug other/11673] libmudflap does not compile on freebsd

[fche at redhat dot com]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11673



------- Additional Comments From fche at redhat dot com  2003-07-25 15:51 -------
Most of the remaining problems relate to the lack of Large File Support
in freebsd.  I'm investigating how to selectively leave these bits out
of libmudflap.

[Bug other/11673] libmudflap does not compile on freebsd

[pinskia at physics dot uc dot edu]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11673



------- Additional Comments From pinskia at physics dot uc dot edu  2003-07-25 15:54 -------
No it is not related to the Lack of Large File Support but rather the Large File Support is support is 
not need as the regular ones are the 64bit ones so there is no need for the extra 64bit ones. All 
*BSD are this way including Darwin.

[Bug other/11673] libmudflap does not compile on freebsd

[fche at redhat dot com]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11673



------- Additional Comments From fche at redhat dot com  2003-07-25 18:13 -------
Linux, how do you propose the _POSIX_SOURCE issue be solved?
Is there another bsd header worth #include'ing?
(I see how to autoconf the rest.)

[Bug other/11673] libmudflap does not compile on freebsd

[lsjoberg at aland dot net]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11673



------- Additional Comments From lsjoberg at aland dot net  2003-07-25 22:48 -------
Subject: Re:  libmudflap does not compile on freebsd

>From types.h:
#ifndef _POSIX_SOURCE
typedef unsigned char   u_char;
typedef unsigned short  u_short;
(...)
#endif

Not much to do there...

The code compiles with _POSIX_SOURCE undefined (that's how I have been solving
the problem temporarly), so an ugly fix is something like
diff -u -u -r1.1.2.1 mf-hooks2.c
--- mf-hooks2.c 4 Jul 2003 23:10:09 -0000       1.1.2.1
+++ mf-hooks2.c 25 Jul 2003 18:30:05 -0000
@@ -11,7 +11,9 @@
 
 /* These attempt to coax various unix flavours to declare all our
    needed tidbits in the system headers.  */
+#ifndef _FREEBSD  /* Or some other magic that detects FreeBSD (prob. *BSD) */
 #define _POSIX_SOURCE
+#endif
 #define _GNU_SOURCE 
 #define _XOPEN_SOURCE
 #define _BSD_TYPES

[Bug other/11673] libmudflap does not compile on freebsd

[gerald at pfeifer dot com]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11673


gerald at pfeifer dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gerald at pfeifer dot com


------- Additional Comments From gerald at pfeifer dot com  2003-07-29 13:39 -------
I experienced (and hack around) this before noticing this PR, so here are some
comments on suggested resolutions:

 1. The MAP_ANON patch looks good; would you mind applying it, Frank?
 2. The _POSIX issue should be resolved as in
     http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11673#c8
    but using __FreeBSD__ instead.
    Still, it would be good to note (in comments) which platforms require _POSIX.
 3. I agree that autoconf-ing the *64 functions is the best approach, 
 4. and similarly for union semun.

[Bug other/11673] libmudflap does not compile on freebsd

[fche at redhat dot com]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11673


fche at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |WAITING


------- Additional Comments From fche at redhat dot com  2003-07-29 18:13 -------
Please try out the patch just committed.

[Bug other/11673] libmudflap does not compile on freebsd

[cvs-commit at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11673



------- Additional Comments From cvs-commit at gcc dot gnu dot org  2003-07-29 19:32 -------
Subject: Bug 11673

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	tree-ssa-20020619-branch
Changes by:	gerald@gcc.gnu.org	2003-07-29 19:32:40

Modified files:
	libmudflap     : ChangeLog mf-hooks2.c 

Log message:
	PR other/11673
	* mf-hooks2.c [WRAP_semctl]: Fix check for HAVE_UNION_SEMUN.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libmudflap/ChangeLog.diff?cvsroot=gcc&only_with_tag=tree-ssa-20020619-branch&r1=1.1.2.69&r2=1.1.2.70
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libmudflap/mf-hooks2.c.diff?cvsroot=gcc&only_with_tag=tree-ssa-20020619-branch&r1=1.1.2.2&r2=1.1.2.3

[Bug other/11673] libmudflap does not compile on freebsd

[fche at redhat dot com]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11673


fche at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |RESOLVED
         Resolution|                            |FIXED


------- Additional Comments From fche at redhat dot com  2003-07-29 21:12 -------
WORKSFORGERALD

[Bug other/11673] libmudflap does not compile on freebsd

[lsjoberg at aland dot net]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11673



------- Additional Comments From lsjoberg at aland dot net  2003-07-29 21:19 -------
Confirmed.