[Bug optimization/11523] New: Intermodule Optimisation handles duplicate names wrong

[Bug optimization/11523] New: Intermodule Optimisation handles duplicate names wrong

[aj at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11523

           Summary: Intermodule Optimisation handles duplicate names wrong
           Product: gcc
           Version: 3.4
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: optimization
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: aj at gcc dot gnu dot org
                CC: gcc-bugs at gcc dot gnu dot org
 GCC build triplet: i686-linux-gnu
  GCC host triplet: i686-linux-gnu
GCC target triplet: i686-linux-gnu

compiling the two tiny test programs I get:

$ /opt/gcc/3.4-devel/bin/gcc -c t1.c t2.c -o t1.o
/tmp/ccANTFAe.s: Assembler messages:
/tmp/ccANTFAe.s:20: Error: symbol `func1' is already defined
/tmp/ccANTFAe.s:34: Error: symbol `dummy' is already defined
/tmp/ccANTFAe.s:34: Warning: rest of line ignored; first ignored character is `,'

[Bug optimization/11523] Intermodule Optimisation handles duplicate names wrong

[aj at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11523



------- Additional Comments From aj at gcc dot gnu dot org  2003-07-15 04:24 -------
Created an attachment (id=4404)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=4404&action=view)
First test program

[Bug optimization/11523] Intermodule Optimisation handles duplicate names wrong

[aj at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11523



------- Additional Comments From aj at gcc dot gnu dot org  2003-07-15 04:25 -------
Created an attachment (id=4405)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=4405&action=view)
second test program

[Bug optimization/11523] Intermodule Optimisation handles duplicate names wrong

[neroden at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11523


neroden at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2003-07-15 05:17:36
               date|                            |


------- Additional Comments From neroden at gcc dot gnu dot org  2003-07-15 05:17 -------
Confirmed.  Perhaps multiple-unit compiling should be discouraged.  :-)

[Bug optimization/11523] Intermodule Optimisation handles duplicate names wrong

[pinskia at physics dot uc dot edu]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11523


pinskia at physics dot uc dot edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mark at codesourcery dot com
           Keywords|                            |wrong-code


------- Additional Comments From pinskia at physics dot uc dot edu  2003-07-15 11:20 -------
Actually it is caused by a patch which tried to fix bootstrap failure caused by the multiple-unit 
compiling, it was not totally the right fix, as it causes this bug, the right fix is to fix PR 11498 and 
use asm name with crt.c.

2003-07-11  Mark Mitchell

        * varasm.c (make_decl_rtl): Treat decls with a DECL_CONTEXT of
        TRANSLATION_UNIT_DECL as top_level.

I undid this patch and your testcase worked.

[Bug optimization/11523] Intermodule Optimisation handles duplicate names wrong

[mmitchel at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11523


mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |geoffk at apple dot com
                   |dot org                     |
             Status|NEW                         |ASSIGNED


------- Additional Comments From mmitchel at gcc dot gnu dot org  2003-07-15 16:27 -------
I've assigned this bug to Geoff Keating.

While it was I broke the multiple-translation-unit stuff, I unbroke the x86
bootstrap which is more important.  We're still sorting out exactly what to do
about the multiple translation unit stuff, but in the meantime Geoff might want
to do the asm-name thing in crtstuff.c and remove my patch.

[Bug optimization/11523] Intermodule Optimisation handles duplicate names wrong

[pinskia at physics dot uc dot edu]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11523



------- Additional Comments From pinskia at physics dot uc dot edu  2003-07-18 16:04 -------
It still happens on the mainline (20030718) even after Keating's fix:
2003-07-17  Geoffrey Keating

        PR 11498
        * Makefile.in (c-opts.o): Add $(LANGHOOKS_DEF_H).
        (langhooks.o): Add $(GGC_H), gt-langhooks.h.
        (GTFILES): Add langhooks.c.
        (gt-langhooks.h): New.
        * c-common.h (c_static_assembler_name): Prototype.
        * c-lang.c (LANG_HOOKS_SET_DECL_ASSEMBLER_NAME): Define.
        * objc/objc-lang.c (LANG_HOOKS_SET_DECL_ASSEMBLER_NAME): Define.
        * c-opts.c: Include langhooks-def.h.
        (c_static_assembler_name): New.
        * langhooks.c: Include ggc.h.  Include gt-langhooks.h.
        (var_labelno): New.
        (lhd_set_decl_assembler_name): Give static objects with context
        unique names.
        * varasm.c (var_labelno): Delete.
        (make_decl_rtl): Don't change the assembler name once it's set.

        * c-opts.c (this_input_filename): New.
        (finish_options): Take new parameter, name of file being compiled.
        Update callers.  Set this_input_filename.
        (push_command_line_include): Use this_input_filename not
        main_input_filename.

[Bug optimization/11523] Intermodule Optimisation handles duplicate names wrong

[geoffk at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11523


geoffk at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |WAITING


------- Additional Comments From geoffk at gcc dot gnu dot org  2003-07-26 08:10 -------
Works for me on current powerpc-darwin.  I get:
_func1.2:
...
.lcomm _dummy.4,4,2
.lcomm _dummy.1,4,2

[Bug optimization/11523] Intermodule Optimisation handles duplicate names wrong

[pinskia at physics dot uc dot edu]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11523


pinskia at physics dot uc dot edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |RESOLVED
         Resolution|                            |FIXED


------- Additional Comments From pinskia at physics dot uc dot edu  2003-07-27 13:48 -------
I can confirm this is fixed on the mainline (20030727) on i686-pc-linux-gnu.