[Bug libgcj/11780] New: Method.invoke() is very slow and leaks memory

[Bug libgcj/11780] New: Method.invoke() is very slow and leaks memory

[bryce at mckinlay dot net dot nz]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11780

           Summary: Method.invoke() is very slow and leaks memory
           Product: gcc
           Version: 3.4
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: libgcj
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: bryce at mckinlay dot net dot nz
                CC: gcc-bugs at gcc dot gnu dot org

Good performance from Method.invoke() is very important for many reflective applications.

In previous versions of libgcj security checks were not perfomed, and our performance was only a 
little worse than the JRE. A recent patch added security checks and now:

- Method.invoke is now ~10 x slower than the JRE
- Method.invoke leaks memory every time it is called

Clearly there are some simple optimizations that can be made - security check is not needed if 
method is public or accessibility flag is true. Ideally however the security check implementation 
itself should be made much faster.

Test case w/ timers follows.


import java.lang.reflect.*;

public class RefTest2
{
  static int i = 0;
  public int increment(int value)
  {
    return ++i;
  }

  public static void main(String[] args) 
    throws Exception
  {
    Method method = RefTest2.class.getMethod ("increment", 
      new Class [] { int.class });
    Object[] arg = new Object[1];
    Object value = new Integer(0);
  
    RefTest2 testObj = new RefTest2();

    while (true)
    {
      long startTime = System.currentTimeMillis();
      for (int i = 0; i < 1000000; i++)
      {
	arg[0] = value;
	value = method.invoke(testObj, arg);
      }
      System.out.println (System.currentTimeMillis() - startTime + " ms");
    }
  }
}

[Bug libgcj/11780] Method.invoke() is very slow and leaks memory

[pinskia at physics dot uc dot edu]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11780


pinskia at physics dot uc dot edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2003-08-03 14:00:28
               date|                            |


------- Additional Comments From pinskia at physics dot uc dot edu  2003-08-03 14:00 -------
I can confirm the slowness on the mainline (20030802) on powerpc-apple-darwin6.6 but 
I do not see any leaks.

[Bug libgcj/11780] Method.invoke() is very slow and leaks memory

[bryce at mckinlay dot net dot nz]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11780



------- Additional Comments From bryce at mckinlay dot net dot nz  2003-08-03 21:12 -------
Interesting - the test case consumes all available memory on my 512MB RHL 9 x86 after around 
20M calls. Perhaps the leak is in system-dependent unwinder code.

[Bug libgcj/11780] Method.invoke() is very slow and leaks memory

[pinskia at physics dot uc dot edu]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11780



------- Additional Comments From pinskia at physics dot uc dot edu  2003-08-03 21:16 -------
I see the memory leak on i686-pc-linuc-gnu also.

[Bug libgcj/11780] Method.invoke() is very slow and leaks memory

[dhazeghi at yahoo dot com]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11780


dhazeghi at yahoo dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|3.4                         |---

[Bug libgcj/11780] Method.invoke() is very slow and leaks memory

[cvs-commit at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11780



------- Additional Comments From cvs-commit at gcc dot gnu dot org  2003-10-25 06:49 -------
Subject: Bug 11780

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	bryce@gcc.gnu.org	2003-10-25 06:49:20

Modified files:
	libjava        : ChangeLog 
	libjava/java/lang/reflect: natMethod.cc natField.cc 

Log message:
	PR libgcj/11780:
	* java/lang/reflect/natMethod.cc (invoke): Look up caller and
	perform accessibility check only if target is non-public and
	accessible flag is not set.
	* java/lang/reflect/natField.cc (getAddr): Likewise.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/ChangeLog.diff?cvsroot=gcc&r1=1.2295&r2=1.2296
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/java/lang/reflect/natMethod.cc.diff?cvsroot=gcc&r1=1.33&r2=1.34
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libjava/java/lang/reflect/natField.cc.diff?cvsroot=gcc&r1=1.14&r2=1.15

[Bug libgcj/11780] Method.invoke() is very slow

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-01-01 01:24 -------
It still is slow:
tin:~/src/gnu/gcctest>gij RefTest2
1574 ms
1596 ms
tin:~/src/gnu/gcctest>java RefTest2
335 ms
271 ms

But this no longer leaks so update summary.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|2003-08-03 14:00:28         |2004-01-01 01:24:31
               date|                            |
            Summary|Method.invoke() is very slow|Method.invoke() is very slow
                   |and leaks memory            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11780