[Bug libstdc++/11784] New: atomic __exchange_and_add() broken for ColdFire and 68000 targets.

[Bug libstdc++/11784] New: atomic __exchange_and_add() broken for ColdFire and 68000 targets.

[bernie at develer dot com]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11784

           Summary: atomic __exchange_and_add() broken for ColdFire and
                    68000 targets.
           Product: gcc
           Version: 3.4
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: libstdc++
        AssignedTo: bernie at develer dot com
        ReportedBy: bernie at develer dot com
                CC: gcc-bugs at gcc dot gnu dot org
GCC target triplet: m68k-elf

User apps linking with libstdc++ segfault on ColdFire targets because 
__exchange_and_add() for vxWorks/__embedded__ targets tries to disable 
interrupts with the "move #0,%sr" privileged opcode. 
 
Patch attached.

[Bug libstdc++/11784] atomic __exchange_and_add() broken for ColdFire and 68000 targets.

[bernie at develer dot com]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11784



------- Additional Comments From bernie at develer dot com  2003-08-04 01:17 -------
Created an attachment (id=4557)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=4557&action=view)
Fix PR11784 by using BSET instead of disabling interrupts on Coldfire targets.

[Bug libstdc++/11784] atomic __exchange_and_add() broken for ColdFire and 68000 targets.

[pinskia at physics dot uc dot edu]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11784


pinskia at physics dot uc dot edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2003-08-04 11:11:31
               date|                            |


------- Additional Comments From pinskia at physics dot uc dot edu  2003-08-04 11:11 -------
I can confirm the problem is there in the mainline (20030804).

[Bug libstdc++/11784] atomic __exchange_and_add() broken for ColdFire and 68000 targets.

[cvs-commit at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11784



------- Additional Comments From cvs-commit at gcc dot gnu dot org  2003-08-07 20:54 -------
Subject: Bug 11784

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	bkoz@gcc.gnu.org	2003-08-07 20:53:57

Modified files:
	libstdc++-v3   : ChangeLog 
	libstdc++-v3/config/cpu/m68k: atomicity.h 

Log message:
	2003-08-07  Bernardo Innocenti  <bernie@develer.com>
	
	PR libstdc++/11784
	* libstdc++-v3/config/cpu/m68k/atomicity.h (__exchange_and_add):
	Replace variants with new BSET-based version.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/ChangeLog.diff?cvsroot=gcc&r1=1.1921&r2=1.1922
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/config/cpu/m68k/atomicity.h.diff?cvsroot=gcc&r1=1.3&r2=1.4

[Bug libstdc++/11784] atomic __exchange_and_add() broken for ColdFire and 68000 targets.

[cvs-commit at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11784



------- Additional Comments From cvs-commit at gcc dot gnu dot org  2003-08-07 20:55 -------
Subject: Bug 11784

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	bkoz@gcc.gnu.org	2003-08-07 20:55:22

Modified files:
	libstdc++-v3/config/cpu/m68k: atomicity.h 

Log message:
	2003-08-07  Bernardo Innocenti  <bernie@develer.com>
	
	PR libstdc++/11784
	* libstdc++-v3/config/cpu/m68k/atomicity.h (__exchange_and_add):
	Replace variants with new BSET-based version.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/config/cpu/m68k/atomicity.h.diff?cvsroot=gcc&r1=1.4&r2=1.5

[Bug libstdc++/11784] atomic __exchange_and_add() broken for ColdFire and 68000 targets.

[cvs-commit at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11784



------- Additional Comments From cvs-commit at gcc dot gnu dot org  2003-08-07 20:58 -------
Subject: Bug 11784

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	gcc-3_3-branch
Changes by:	bkoz@gcc.gnu.org	2003-08-07 20:58:05

Modified files:
	libstdc++-v3   : ChangeLog 
	libstdc++-v3/config/cpu/m68k: atomicity.h 

Log message:
	2003-08-07  Bernardo Innocenti  <bernie@develer.com>
	
	PR libstdc++/11784
	* libstdc++-v3/config/cpu/m68k/atomicity.h (__exchange_and_add):
	Replace variants with new BSET-based version.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-3_3-branch&r1=1.1464.2.141&r2=1.1464.2.142
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/config/cpu/m68k/atomicity.h.diff?cvsroot=gcc&only_with_tag=gcc-3_3-branch&r1=1.1&r2=1.1.22.1

[Bug libstdc++/11784] atomic __exchange_and_add() broken for ColdFire and 68000 targets.

[pinskia at physics dot uc dot edu]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11784


pinskia at physics dot uc dot edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


------- Additional Comments From pinskia at physics dot uc dot edu  2003-08-07 21:08 -------
Fixed for 3.3.2 and 3.4.