[Bug c/11527] New: If an array "designated intializer" in a struct causes a segv.

[Bug c/11527] New: If an array "designated intializer" in a struct causes a segv.

[eamon at sonyoxford dot co dot uk]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11527

           Summary: If an array  "designated intializer" in a struct causes
                    a segv.
           Product: gcc
           Version: 3.3
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: c
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: eamon at sonyoxford dot co dot uk
                CC: gcc-bugs at gcc dot gnu dot org
 GCC build triplet: i386-slackware-linux
  GCC host triplet: i386-slackware-linux
GCC target triplet: i386-slackware-linux

The following (preprocessed) code causes a segv in 3.3 and 3.2.2

# 1 "t.c"
# 1 "<built-in>"
# 1 "<command line>"
# 1 "t.c"
typedef struct smrdd_memory_blocks_s {
        int blocks;
                int block[];
        } smrdd_memory_blocks_t;

const smrdd_memory_blocks_t smrdd_memory_blocks={
        (3),
            {
                [5] = 0,
                [1] = 2,
            }
        };

It only happens with the struct, changing it too an int array is okay.

The values of the index (5 and 1) do not matter, nor do the values assigned
(0 and 2).

Thanks
Eamon.
(This is not the original code that found the problem, just the
distilled essence.)

=====================
gcc -save-temps -v -Wall t.c
Reading specs from /usr/lib/gcc-lib/i386-slackware-linux/3.3/specs
Configured with: ../gcc-3.3/configure --prefix=/usr --enable-shared
--enable-threads=posix --enable-__cxa_atexit --disable-checking --with-gnu-ld
--verbose --target=i386-slackware-linux --host=i386-slackware-linux
Thread model: posix
gcc version 3.3
 /usr/lib/gcc-lib/i386-slackware-linux/3.3/cc1 -E -quiet -v -D__GNUC__=3
-D__GNUC_MINOR__=3 -D__GNUC_PATCHLEVEL__=0 t.c -Wall t.i
ignoring nonexistent directory "/usr/i386-slackware-linux/include"
#include "..." search starts here:
#include <...> search starts here:
 /usr/local/include
 /usr/lib/gcc-lib/i386-slackware-linux/3.3/include
 /usr/include
End of search list.
 /usr/lib/gcc-lib/i386-slackware-linux/3.3/cc1 -fpreprocessed t.i -quiet
-dumpbase t.c -auxbase t -Wall -version -o t.s
GNU C version 3.3 (i386-slackware-linux)
        compiled by GNU C version 3.3.
GGC heuristics: --param ggc-min-expand=98 --param ggc-min-heapsize=129115
t.c:11: internal compiler error: Segmentation fault
Please submit a full bug report,
with preprocessed source if appropriate.
See <URL:http://gcc.gnu.org/bugs.html> for instructions.

[Bug c/11527] If an array "designated intializer" in a struct causes a segv.

[pinskia at physics dot uc dot edu]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11527


pinskia at physics dot uc dot edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
 GCC target triplet|i386-slackware-linux        |*-*-*
   Last reconfirmed|0000-00-00 00:00:00         |2003-07-15 17:35:39
               date|                            |


------- Additional Comments From pinskia at physics dot uc dot edu  2003-07-15 17:35 -------
I can confirm this on the mainline (20030715), 3.0.4, 3.2.3, 3.3.1 (20030707).

0x0004b1d9 in output_pending_init_elements (all=1) at /home/gates/pinskia/src/gnu/gcc/src/
gcc/c-typeck.c:6370
6370          if (TREE_CODE (constructor_type) == ARRAY_TYPE)
(gdb) bt
#0  0x0004b1d9 in output_pending_init_elements (all=1) at /home/gates/pinskia/src/gnu/gcc/
src/gcc/c-typeck.c:6370
#1  0x00049086 in pop_init_level (implicit=0) at /home/gates/pinskia/src/gnu/gcc/src/gcc/c-
typeck.c:5523
#2  0x0000f944 in yyparse () at c-parse.y:1452
#3  0x00012f13 in c_parse_file () at c-parse.y:3028
#4  0x00068fa7 in c_common_parse_file (set_yydebug=0) at /home/gates/pinskia/src/gnu/gcc/
src/gcc/c-opts.c:1211
#5  0x003332e6 in compile_file () at /home/gates/pinskia/src/gnu/gcc/src/gcc/toplev.c:1930
#6  0x003387e9 in do_compile () at /home/gates/pinskia/src/gnu/gcc/src/gcc/toplev.c:4771
#7  0x00338901 in toplev_main (argc=15, argv=0xdfbfd698) at /home/gates/pinskia/src/gnu/
gcc/src/gcc/toplev.c:4812
(gdb) p constructor_type
$1 = 0x0

Even changing the "designated initializer" to other style (without the =, I forgot which style is what, 
C99 or GNU) gcc ICEs at the same spot.

[Bug c/11527] If an array "designated intializer" in a struct causes a segv.

[dhazeghi at yahoo dot com]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11527


dhazeghi at yahoo dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  GCC build triplet|i386-slackware-linux        |
   GCC host triplet|i386-slackware-linux        |
 GCC target triplet|*-*-*                       |
           Keywords|                            |ice-on-valid-code


------- Additional Comments From dhazeghi at yahoo dot com  2003-07-18 22:28 -------
Not target-specific...

[Bug c/11527] [3.3/3.4 Regression] If an array "designated intializer" in a struct causes a segv.

[pinskia at physics dot uc dot edu]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11527


pinskia at physics dot uc dot edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|If an array  "designated    |[3.3/3.4 Regression] If an
                   |intializer" in a struct     |array  "designated
                   |causes a segv.              |intializer" in a struct
                   |                            |causes a segv.
   Target Milestone|3.4                         |3.3.2


------- Additional Comments From pinskia at physics dot uc dot edu  2003-07-18 22:37 -------
Even though this was not accepted in 2.95 (as it did not accepted the C99 variable length arrays), 
this is a regression.

>From Phil's regression hunter: Search converges between 2000-12-31-trunk (#0) and 2001-01-
07-trunk (#1).

The first time I saw a regression that happened with the first and second cc1 from Phil.  Hopefully 
someone can narrow it down further as it is currently one week of patches (but usually a slow one 
though).

[Bug c/11527] [3.3/3.4 Regression] If an array "designated intializer" in a struct causes a segv.

[janis187 at us dot ibm dot com]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11527


janis187 at us dot ibm dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rth at redhat dot com


------- Additional Comments From janis187 at us dot ibm dot com  2003-08-05 19:30 -------
The test case for PR 11527 starts getting an ICE with this patch:

--- gcc/gcc/ChangeLog ---

2001-01-04  Richard Henderson  <rth@redhat.com>

        * c-decl.c (finish_struct): Detect flexible array members
        used in an inappropriate context.
        * c-typeck.c (really_start_incremental_init): Special case
        constructor_max_index for zero length arrays.
        (pop_init_level): Allow initialization of flexible array
        members.  Deprecate initialization of zero length arrays.
        Don't issue missing initializer warning for flexible array
        members or zero length arrays.
        (process_init_element): Don't dereference null DECL_SIZE.
        * varasm.c (array_size_for_constructor): Return a HOST_WIDE_INT.
        Don't abort for empty constructors.  Use size_binop
        (output_constructor): Add commentary regarding zero length
        array futures.  Abort if we try to initialize an array of
        unspecified length with a non-empty constructor in the middle
        of a structure.

        * extend.texi (Zero Length): Update and clarify documentation
        on static initialization.

The test case starts getting an error message with this patch:

--- gcc/gcc/ChangeLog ---

2000-01-03  Richard Henderson  <rth@redhat.com>

        * c-decl.c (grokdeclarator): Give zero-length arrays size zero.
        Remove dead code.
        * c-typeck.c (push_init_level): Move checks for flexible array
        members and zero length arrays ...
        (pop_init_level): ... here.  Silently discard empty initializations.
        Remove dead code.
        * varasm.c (output_constructor): Update for sizeof change to
        zero-length arrays.

        * extend.texi (Zero Length): Clarify semantics.

Before that change the test case compiled cleanly.  The error message
seen between the two patches is:

11527.c:11: initialization of a flexible array member
11527.c:11: (near initialization for `smrdd_memory_blocks.block')

The regression hunt took place on i686-pc-linux-gnu using the submitter's
test case.

[Bug c/11527] [3.3/3.4 Regression] If an array "designated intializer" in a struct causes a segv.

[mmitchel at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11527


mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |rth at redhat dot com
                   |dot org                     |
             Status|NEW                         |ASSIGNED


------- Additional Comments From mmitchel at gcc dot gnu dot org  2003-09-05 07:14 -------
This bug was caused by Richard's change.

[Bug c/11527] [3.3/3.4 Regression] If an array "designated intializer" in a struct causes a segv.

[mmitchel at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11527


mmitchel at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|3.3.2                       |3.3.3


------- Additional Comments From mmitchel at gcc dot gnu dot org  2003-10-16 09:43 -------
Postponed until GCC 3.3.3.

[Bug c/11527] [3.3/3.4 Regression] If an array "designated intializer" in a struct causes a segv.

[gdr at gcc dot gnu dot org]

------- Additional Comments From gdr at gcc dot gnu dot org  2003-12-21 20:28 -------
RTH --
Your patch mentioned in the audit trail is causing this regression.
Do you have plan to fix it for 3.3.3?

-- Gaby


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11527

[Bug c/11527] [3.3/3.4 Regression] If an array "designated intializer" in a struct causes a segv.

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |critical


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11527

[Bug c/11527] [3.3/3.4 Regression] If an array "designated intializer" in a struct causes a segv.

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-01-11 01:48 -------
Not either 3.3.3 holding back or 3.4 branch blocking (as this is invalid code) so moving to 
3.4.1.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|critical                    |normal
           Keywords|ice-on-valid-code           |ice-on-invalid-code
   Target Milestone|3.3.3                       |3.4.1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11527

[Bug c/11527] [3.3/3.4 Regression] If an array "designated intializer" in a struct causes a segv.

[steven at gcc dot gnu dot org]

------- Additional Comments From steven at gcc dot gnu dot org  2004-01-12 23:39 -------
Move back the target for all regressions from 3.4.1 to 3.4.0, as required by 
our bug management policy. 

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|3.4.1                       |3.4.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11527

[Bug c/11527] [3.3/3.4/3.5 Regression] If an array "designated intializer" in a struct causes a segv.

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-03-24 16:54 -------
*** Bug 14714 has been marked as a duplicate of this bug. ***

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |henryhack101 at netscape dot
                   |                            |net


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11527

[Bug c/11527] [3.3/3.4/3.5 Regression] If an array "designated intializer" in a struct causes a segv.

[rth at gcc dot gnu dot org]

------- Additional Comments From rth at gcc dot gnu dot org  2004-03-24 22:55 -------
Canonicalize me.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|rth at redhat dot com       |rth at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11527

[Bug c/11527] [3.3/3.4/3.5 Regression] If an array "designated intializer" in a struct causes a segv.

[rth at gcc dot gnu dot org]

------- Additional Comments From rth at gcc dot gnu dot org  2004-03-26 00:36 -------
Patch: http://gcc.gnu.org/ml/gcc-patches/2004-03/msg02134.html

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mark at codesourcery dot com
           Keywords|                            |patch


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11527

[Bug c/11527] [3.3/3.4/3.5 Regression] If an array "designated intializer" in a struct causes a segv.

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-03-26 00:46 -------
Subject: Bug 11527

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	rth@gcc.gnu.org	2004-03-26 00:46:53

Modified files:
	gcc            : ChangeLog c-typeck.c 
Added files:
	gcc/testsuite/gcc.dg: gnu89-init-3.c 

Log message:
	PR 11527
	* c-typeck.c (pop_init_level): Emit pending init elements earlier
	rather than later.
	* gcc.dg/gnu89-init-3.c: New.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&r1=2.3295&r2=2.3296
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/c-typeck.c.diff?cvsroot=gcc&r1=1.294&r2=1.295
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/gnu89-init-3.c.diff?cvsroot=gcc&r1=NONE&r2=1.1



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11527

[Bug c/11527] [3.3/3.4 Regression] If an array "designated intializer" in a struct causes a segv.

[rth at gcc dot gnu dot org]

------- Additional Comments From rth at gcc dot gnu dot org  2004-03-26 00:50 -------
Patch: http://gcc.gnu.org/ml/gcc-patches/2004-03/msg02134.html

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to work|2.95.3                      |2.95.3 3.5.0
            Summary|[3.3/3.4/3.5 Regression] If |[3.3/3.4 Regression] If an
                   |an array  "designated       |array  "designated
                   |intializer" in a struct     |intializer" in a struct
                   |causes a segv.              |causes a segv.


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11527

[Bug c/11527] [3.3/3.4 Regression] If an array "designated intializer" in a struct causes a segv.

[gdr at integrable-solutions dot net]

------- Additional Comments From gdr at integrable-solutions dot net  2004-03-26 06:45 -------
Subject: Re:  [3.3/3.4/3.5 Regression] If an array  "designated intializer" in a struct causes a segv.

"rth at gcc dot gnu dot org" <gcc-bugzilla@gcc.gnu.org> writes:

| Patch: http://gcc.gnu.org/ml/gcc-patches/2004-03/msg02134.html

This is OK for 3.3.4.

-- gaby


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11527

[Bug c/11527] [3.3/3.4 Regression] If an array "designated intializer" in a struct causes a segv.

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-03-26 22:37 -------
Subject: Bug 11527

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	gcc-3_3-branch
Changes by:	rth@gcc.gnu.org	2004-03-26 22:37:18

Modified files:
	gcc            : ChangeLog c-typeck.c 
Added files:
	gcc/testsuite/gcc.dg: gnu89-init-3.c 

Log message:
	PR 11527
	* c-typeck.c (pop_init_level): Emit pending init elements earlier
	rather than later.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-3_3-branch&r1=1.16114.2.954&r2=1.16114.2.955
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/c-typeck.c.diff?cvsroot=gcc&only_with_tag=gcc-3_3-branch&r1=1.213.2.14&r2=1.213.2.15
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/gnu89-init-3.c.diff?cvsroot=gcc&only_with_tag=gcc-3_3-branch&r1=NONE&r2=1.1.2.1



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11527

[Bug c/11527] [3.3/3.4 Regression] If an array "designated intializer" in a struct causes a segv.

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-03-26 23:04 -------
Subject: Bug 11527

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	gcc-3_4-branch
Changes by:	rth@gcc.gnu.org	2004-03-26 23:04:40

Modified files:
	gcc            : ChangeLog c-typeck.c 
Added files:
	gcc/testsuite/gcc.dg: gnu89-init-3.c 

Log message:
	PR 11527
	* c-typeck.c (pop_init_level): Emit pending init elements earlier
	rather than later.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=2.2326.2.371&r2=2.2326.2.372
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/c-typeck.c.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.272.2.5&r2=1.272.2.6
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gcc.dg/gnu89-init-3.c.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=NONE&r2=1.1.4.1



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11527

[Bug c/11527] If an array "designated intializer" in a struct causes a segv.

[rth at gcc dot gnu dot org]

------- Additional Comments From rth at gcc dot gnu dot org  2004-03-26 23:07 -------
Fixed.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
            Summary|[3.3/3.4 Regression] If an  |If an array  "designated
                   |array  "designated          |intializer" in a struct
                   |intializer" in a struct     |causes a segv.
                   |causes a segv.              |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11527

[Bug c/11527] If an array "designated intializer" in a struct causes a segv.

[rth at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|3.4.0                       |3.3.4


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11527