[Bug c++/11283] New: [3.4 regression]

[Bug c++/11283] New: [3.4 regression]

[falk at debian dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11283

           Summary: [3.4 regression]
           Product: gcc
           Version: 3.4
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: critical
          Priority: P2
         Component: c++
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: falk at debian dot org
                CC: gcc-bugs@gcc.gnu.org
 GCC build triplet: alphaev68-unknown-linux-gnu
  GCC host triplet: alphaev68-unknown-linux-gnu
GCC target triplet: alphaev68-unknown-linux-gnu

This was reported on gcc-bugs by James W. McKelvey (mckelvey at maskull com),
but I can't find it in the database. According to James, it also occurs on
Solaris 2.7.1. It does not occur with 3.3 or earlier.

Here's an unpreprocessed test case:

#include <vector>

namespace PatternMaster {
    struct SymbolTable {
	static const bool EMPTY_BOOLEAN = false;
    };
}

bool evaluate(std::vector<bool> value) {
    const unsigned long offset = 23;
    return (offset < value.size()
	    ? value[offset]
	    : PatternMaster::SymbolTable::EMPTY_BOOLEAN);
}

% g++ --version             
g++ (GCC) 3.4 20030614 (experimental)
% g++ -c bugs.cc            
bugs.cc: In function `bool evaluate(std::vector<bool, std::allocator<bool> >)':
bugs.cc:13: internal compiler error: in build_conditional_expr, at cp/call.c:
   3349
Please submit a full bug report,
with preprocessed source if appropriate.
See <URL:http://gcc.gnu.org/bugs.html> for instructions.

[Bug c++/11283] [3.4 regression]

[falk at debian dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11283



------- Additional Comments From falk at debian dot org  2003-06-22 12:52 -------
Created an attachment (id=4263)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=4263&action=view)
Test case

[Bug c++/11283] [3.4 regression] ICE in build_conditional_expr with vector<bool>

[falk at debian dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11283


falk at debian dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[3.4 regression]            |[3.4 regression] ICE in
                   |                            |build_conditional_expr with
                   |                            |vector<bool>

[Bug c++/11283] [3.4 regression] ICE in build_conditional_expr with vector<bool>

[giovannibajo at libero dot it]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11283


giovannibajo at libero dot it changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2003-06-22 17:40:23
               date|                            |


------- Additional Comments From giovannibajo at libero dot it  2003-06-22 17:40 -------
Confirmed, reduced snippet:

---------------------------------------------
struct Bar
{
  operator bool();
};

struct Foo
{
  Bar func(void);
};

const bool blabla(void);

bool evaluate(Foo foo) 
{
  return (0 ? foo.func() : blabla());
}
---------------------------------------------
pr11283.cpp: In function `bool evaluate(Foo)':
pr11283.cpp:15: internal compiler error: in build_conditional_expr, at 
cp/call.c:3349

Regression on mainline only.

[Bug c++/11283] [3.4 regression] ICE in build_conditional_expr with vector<bool>

[giovannibajo at libero dot it]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11283


giovannibajo at libero dot it changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |giovannibajo@libero.it
         AssignedTo|unassigned at gcc dot gnu   |jason at gcc dot gnu dot org
                   |dot org                     |


------- Additional Comments From giovannibajo at libero dot it  2003-06-22 17:41 -------
Regression introduced with this patch by Jason Merill:
http://gcc.gnu.org/ml/gcc-patches/2003-05/msg00461.html

[Bug c++/11283] [3.4 regression] ICE in build_conditional_expr

[giovannibajo at libero dot it]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11283


giovannibajo at libero dot it changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[3.4 regression] ICE in     |[3.4 regression] ICE in
                   |build_conditional_expr with |build_conditional_expr
                   |vector<bool>                |


------- Additional Comments From giovannibajo at libero dot it  2003-06-22 17:44 -------
This seems to fix it:


Index: call.c
===================================================================
RCS file: /cvsroot/gcc/gcc/gcc/cp/call.c,v
retrieving revision 1.386
diff -c -p -r1.386 call.c
*** call.c      15 May 2003 22:25:51 -0000      1.386
--- call.c      22 Jun 2003 17:42:12 -0000
*************** build_conditional_expr (tree arg1, tree
*** 3345,3351 ****
        {
          arg2 = convert_like (conv2, arg2);
          arg2 = convert_from_reference (arg2);
!         if (!same_type_p (TREE_TYPE (arg2), arg3_type))
            abort ();
          arg2_type = TREE_TYPE (arg2);
        }
--- 3345,3353 ----
        {
          arg2 = convert_like (conv2, arg2);
          arg2 = convert_from_reference (arg2);
!         if (!same_type_ignoring_top_level_qualifiers_p
!             (TREE_TYPE (arg2), arg3_type)
!             || !at_least_as_qualified_p (arg3_type, TREE_TYPE (arg2)))
            abort ();
          arg2_type = TREE_TYPE (arg2);
        }
*************** build_conditional_expr (tree arg1, tree
*** 3353,3359 ****
        {
          arg3 = convert_like (conv3, arg3);
          arg3 = convert_from_reference (arg3);
!         if (!same_type_p (TREE_TYPE (arg3), arg2_type))
            abort ();
          arg3_type = TREE_TYPE (arg3);
        }
--- 3355,3363 ----
        {
          arg3 = convert_like (conv3, arg3);
          arg3 = convert_from_reference (arg3);
!         if (!same_type_ignoring_top_level_qualifiers_p
!             (TREE_TYPE (arg3), arg2_type)
!             || !at_least_as_qualified_p (arg2_type, TREE_TYPE (arg3)))
            abort ();
          arg3_type = TREE_TYPE (arg3);
        }

[Bug c++/11283] [3.4 regression] ICE in build_conditional_expr

[jason at redhat dot com]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11283



------- Additional Comments From jason at redhat dot com  2003-06-23 22:16 -------
Subject: Re:  [3.4 regression] ICE in build_conditional_expr

No, we need the types to be the same at this point.  The conversion code
should have done the complete conversion; apparently it isn't.  I'll try
to look at this soon.

Jason

[Bug c++/11283] [3.4 regression] ICE in build_conditional_expr

[pinskia at physics dot uc dot edu]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11283


pinskia at physics dot uc dot edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pinskia at physics dot uc
                   |                            |dot edu
 GCC target triplet|alphaev68-unknown-linux-gnu |*-*-*


------- Additional Comments From pinskia at physics dot uc dot edu  2003-07-15 00:56 -------
Also happens on powerpc-apple-darwin6.6 so target indpendent.

[Bug c++/11283] [3.4 regression] ICE in build_conditional_expr

[cvs-commit at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11283



------- Additional Comments From cvs-commit at gcc dot gnu dot org  2003-08-21 22:02 -------
Subject: Bug 11283

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	jason@gcc.gnu.org	2003-08-21 22:02:27

Modified files:
	gcc/cp         : ChangeLog call.c 
Added files:
	gcc/testsuite/g++.dg/conversion: cond6.C 

Log message:
	PR c++/11283
	* call.c (build_conditional_expr): Ignore cv-qual differences for
	non-class types.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/ChangeLog.diff?cvsroot=gcc&r1=1.3617&r2=1.3618
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/call.c.diff?cvsroot=gcc&r1=1.422&r2=1.423
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/g++.dg/conversion/cond6.C.diff?cvsroot=gcc&r1=NONE&r2=1.1

[Bug c++/11283] [3.4 regression] ICE in build_conditional_expr

[pinskia at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11283


pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


------- Additional Comments From pinskia at gcc dot gnu dot org  2003-08-21 22:48 -------
Fixed by the above patch.