public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
* [Bug optimization/11873] New: inefficient use of registers induces size and time overhead @ 2003-08-10 8:39 willy at w dot ods dot org 2003-08-10 13:52 ` [Bug optimization/11873] " pinskia at gcc dot gnu dot org ` (5 more replies) 0 siblings, 6 replies; 7+ messages in thread From: willy at w dot ods dot org @ 2003-08-10 8:39 UTC (permalink / raw) To: gcc-bugs PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org. http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11873 Summary: inefficient use of registers induces size and time overhead Product: gcc Version: 3.3.1 Status: UNCONFIRMED Severity: enhancement Priority: P2 Component: optimization AssignedTo: unassigned at gcc dot gnu dot org ReportedBy: willy at w dot ods dot org CC: gcc-bugs at gcc dot gnu dot org GCC build triplet: i586-linux-gnu GCC host triplet: i586-linux-gnu GCC target triplet: i586-linux-gnu I wrote a simple test function which uses an unsigned long long arg and returns its integer part + 1 if not 0, otherwise 0. GCC 3.3.1 passes some intermediate values through several registers while it's unneeded. Here comes all my analysis. I hope this can help improving the optimizer. The following code : int test(unsigned long long x) { if (x) { return (int)x + 1; } else { return (int)x; } } processed this way : # 1 "bool.c" # 1 "<built-in>" # 1 "<command line>" # 1 "bool.c" int test(unsigned long long x) { if (x) { return (int)x + 1; } else { return (int)x; } } produces the following code when compiled with gcc 2.95.3 : (gcc -c -O2 -fomit-frame-pointer bool.c) 00000000 <test>: 0: 8b 54 24 04 mov 0x4(%esp,1),%edx 4: 8b 4c 24 08 mov 0x8(%esp,1),%ecx 8: 89 d0 mov %edx,%eax a: 09 c8 or %ecx,%eax c: 75 03 jne 11 <test+0x11> e: 89 d0 mov %edx,%eax 10: c3 ret 11: 8d 42 01 lea 0x1(%edx),%eax 14: c3 ret 15: 8d 76 00 lea 0x0(%esi),%esi 18: and this one with gcc-3.3.1 : (gcc-3.3.1 -c -O2 -fomit-frame-pointer bool.c) 00000000 <test>: 0: 53 push %ebx 1: 8b 4c 24 0c mov 0xc(%esp,1),%ecx 5: 8b 54 24 08 mov 0x8(%esp,1),%edx 9: 89 cb mov %ecx,%ebx b: 89 d0 mov %edx,%eax d: 09 d3 or %edx,%ebx f: 74 03 je 14 <test+0x14> 11: 8d 42 01 lea 0x1(%edx),%eax 14: 5b pop %ebx 15: c3 ret 16: 8d 76 00 lea 0x0(%esi),%esi 19: 8d bc 27 00 00 00 00 lea 0x0(%edi,1),%edi 20: the EBX register is used and clobbered for nothing here. The same code could be written this way, which is fully equivalent and saves some cycles and bytes : 00000000 <test>: 0: 8b 4c 24 0c mov 0xc(%esp,1),%ecx 4: 8b 54 24 08 mov 0x8(%esp,1),%edx 8: 89 d0 mov %edx,%eax a: 09 d1 or %edx,%ecx c: 74 03 je 11 <test+0x11> e: 8d 42 01 lea 0x1(%edx),%eax 11: c3 ret 12: Now we can also save EDX and some more bytes : 00000000 <test>: 0: 8b 4c 24 0c mov 0xc(%esp,1),%ecx 4: 8b 54 24 08 mov 0x8(%esp,1),%eax a: 09 c1 or %eax,%ecx c: 74 01 je f <test+0xf> e: 41 inc %eax f: c3 ret 10: Here are the compilers versions : wtap:~/dev$ gcc -v Reading specs from /usr/lib/gcc-lib/i586-pc-linux-gnu/2.95.3/specs gcc version 2.95.3 20010315 (release) wtap:~/dev$ gcc-3.3.1 -v Reading specs from /usr/lib/gcc-lib/i586-pc-linux-gnu/3.3.1/specs Configured with: ./configure --prefix=/usr --with-cpu=i386 --host=i586-pc-linux-gnu --enable-languages=c,c++ --disable-nls --disable-locale --enable-shared --enable-target-optspace --enable-version-specific-runtime-libs --program-suffix=-3.3.1 --enable-threads Thread model: posix gcc version 3.3.1 ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug optimization/11873] inefficient use of registers induces size and time overhead 2003-08-10 8:39 [Bug optimization/11873] New: inefficient use of registers induces size and time overhead willy at w dot ods dot org @ 2003-08-10 13:52 ` pinskia at gcc dot gnu dot org 2003-08-23 1:15 ` dhazeghi at yahoo dot com ` (4 subsequent siblings) 5 siblings, 0 replies; 7+ messages in thread From: pinskia at gcc dot gnu dot org @ 2003-08-10 13:52 UTC (permalink / raw) To: gcc-bugs PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org. http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11873 pinskia at gcc dot gnu dot org changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed| |1 Keywords| |pessimizes-code Last reconfirmed|0000-00-00 00:00:00 |2003-08-10 13:52:01 date| | ------- Additional Comments From pinskia at gcc dot gnu dot org 2003-08-10 13:52 ------- I can confirm this on the mainline (20030809). GCC is not really good at optimizing long long's, I have some improvements but it seems not to help in this case. ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug optimization/11873] inefficient use of registers induces size and time overhead 2003-08-10 8:39 [Bug optimization/11873] New: inefficient use of registers induces size and time overhead willy at w dot ods dot org 2003-08-10 13:52 ` [Bug optimization/11873] " pinskia at gcc dot gnu dot org @ 2003-08-23 1:15 ` dhazeghi at yahoo dot com 2004-06-03 4:27 ` [Bug rtl-optimization/11873] " pinskia at gcc dot gnu dot org ` (3 subsequent siblings) 5 siblings, 0 replies; 7+ messages in thread From: dhazeghi at yahoo dot com @ 2003-08-23 1:15 UTC (permalink / raw) To: gcc-bugs PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org. http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11873 dhazeghi at yahoo dot com changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|3.4 |--- ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug rtl-optimization/11873] inefficient use of registers induces size and time overhead 2003-08-10 8:39 [Bug optimization/11873] New: inefficient use of registers induces size and time overhead willy at w dot ods dot org 2003-08-10 13:52 ` [Bug optimization/11873] " pinskia at gcc dot gnu dot org 2003-08-23 1:15 ` dhazeghi at yahoo dot com @ 2004-06-03 4:27 ` pinskia at gcc dot gnu dot org 2004-06-03 4:29 ` pinskia at gcc dot gnu dot org ` (2 subsequent siblings) 5 siblings, 0 replies; 7+ messages in thread From: pinskia at gcc dot gnu dot org @ 2004-06-03 4:27 UTC (permalink / raw) To: gcc-bugs -- What |Removed |Added ---------------------------------------------------------------------------- BugsThisDependsOn| |15792 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11873 ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug rtl-optimization/11873] inefficient use of registers induces size and time overhead 2003-08-10 8:39 [Bug optimization/11873] New: inefficient use of registers induces size and time overhead willy at w dot ods dot org ` (2 preceding siblings ...) 2004-06-03 4:27 ` [Bug rtl-optimization/11873] " pinskia at gcc dot gnu dot org @ 2004-06-03 4:29 ` pinskia at gcc dot gnu dot org 2004-11-08 23:44 ` pinskia at gcc dot gnu dot org 2004-11-13 6:01 ` pinskia at gcc dot gnu dot org 5 siblings, 0 replies; 7+ messages in thread From: pinskia at gcc dot gnu dot org @ 2004-06-03 4:29 UTC (permalink / raw) To: gcc-bugs ------- Additional Comments From pinskia at gcc dot gnu dot org 2004-06-03 04:29 ------- I filed 15792 to track part of this bug. -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11873 ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug rtl-optimization/11873] inefficient use of registers induces size and time overhead 2003-08-10 8:39 [Bug optimization/11873] New: inefficient use of registers induces size and time overhead willy at w dot ods dot org ` (3 preceding siblings ...) 2004-06-03 4:29 ` pinskia at gcc dot gnu dot org @ 2004-11-08 23:44 ` pinskia at gcc dot gnu dot org 2004-11-13 6:01 ` pinskia at gcc dot gnu dot org 5 siblings, 0 replies; 7+ messages in thread From: pinskia at gcc dot gnu dot org @ 2004-11-08 23:44 UTC (permalink / raw) To: gcc-bugs -- What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |WAITING http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11873 ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug rtl-optimization/11873] inefficient use of registers induces size and time overhead 2003-08-10 8:39 [Bug optimization/11873] New: inefficient use of registers induces size and time overhead willy at w dot ods dot org ` (4 preceding siblings ...) 2004-11-08 23:44 ` pinskia at gcc dot gnu dot org @ 2004-11-13 6:01 ` pinskia at gcc dot gnu dot org 5 siblings, 0 replies; 7+ messages in thread From: pinskia at gcc dot gnu dot org @ 2004-11-13 6:01 UTC (permalink / raw) To: gcc-bugs ------- Additional Comments From pinskia at gcc dot gnu dot org 2004-11-13 06:01 ------- I don't know why this was put in waiting but it should not have been. -- What |Removed |Added ---------------------------------------------------------------------------- Status|WAITING |NEW Last reconfirmed|2004-11-03 18:17:06 |2004-11-13 06:01:18 date| | http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11873 ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2004-11-13 6:01 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2003-08-10 8:39 [Bug optimization/11873] New: inefficient use of registers induces size and time overhead willy at w dot ods dot org 2003-08-10 13:52 ` [Bug optimization/11873] " pinskia at gcc dot gnu dot org 2003-08-23 1:15 ` dhazeghi at yahoo dot com 2004-06-03 4:27 ` [Bug rtl-optimization/11873] " pinskia at gcc dot gnu dot org 2004-06-03 4:29 ` pinskia at gcc dot gnu dot org 2004-11-08 23:44 ` pinskia at gcc dot gnu dot org 2004-11-13 6:01 ` pinskia at gcc dot gnu dot org
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).