[Bug optimization/12028] New: powerpc-eabispe: ICE building __divdi3.o: in ccr_bit, at config/rs6000/rs6000.c:8136

[Bug optimization/12028] New: powerpc-eabispe: ICE building __divdi3.o: in ccr_bit, at config/rs6000/rs6000.c:8136

[dhazeghi at yahoo dot com]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12028

           Summary: powerpc-eabispe: ICE building __divdi3.o: in ccr_bit, at
                    config/rs6000/rs6000.c:8136
           Product: gcc
           Version: 3.4
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P2
         Component: optimization
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: dhazeghi at yahoo dot com
                CC: gcc-bugs at gcc dot gnu dot org
GCC target triplet: powerpc-eabispe

Building gcc for powerpc-eabispe target on mainline (combined tree):
../combined/configure --target=powerpc-eabispe --enable-languages=c,c++,objc
fails with:
./xgcc -B./ -B/usr/local/powerpc-eabispe/bin/ -isystem /usr/local/powerpc-eabispe/include -
isystem /usr/local/powerpc-eabispe/sys-include -L/home/dara/mainline/objdir/gcc/../ld -O2  -
DIN_GCC -DCROSS_COMPILE   -W -Wall -Wwrite-strings -Wstrict-prototypes -Wmissing-
prototypes -isystem ./include   -g  -DIN_LIBGCC2 -D__GCC_FLOAT_NOT_NEEDED -Dinhibit_libc -I. 
-I. -I../../combined/gcc -I../../combined/gcc/. -I../../combined/gcc/config -I../../combined/gcc/
../include   -DL_divdi3 -c ../../combined/gcc/libgcc2.c -fexceptions -fnon-call-exceptions -o 
libgcc/./_divdi3.o
../../combined/gcc/libgcc2.c: In function `__divdi3':

../../combined/gcc/libgcc2.c:1066: internal compiler error: in ccr_bit, at config/rs6000/
rs6000.c:8136
Please submit a full bug report,
with preprocessed source if appropriate.
See <URL:http://gcc.gnu.org/bugs.html> for instructions.
make[1]: *** [libgcc/./_divdi3.o] Error 1
make[1]: Leaving directory `/home/dara/mainline/objdir/gcc'
make: *** [stmp-multilib] Error 2

The testcase does not ICE if -O1 or lower is specified.

[Bug optimization/12028] powerpc-eabispe: ICE building __divdi3.o: in ccr_bit, at config/rs6000/rs6000.c:8136

[dhazeghi at yahoo dot com]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12028



------- Additional Comments From dhazeghi at yahoo dot com  2003-08-21 23:34 -------
Created an attachment (id=4638)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=4638&action=view)
unreduced testcase

fails with cross cc1 to powerpc-easbispe with -O2 or higher optimization.

[Bug optimization/12028] [3.4 Regression] powerpc-eabispe: ICE building __divdi3.o: in ccr_bit, at config/rs6000/rs6000.c:8136

[pinskia at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12028


pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |critical
           Priority|P2                          |P1
            Summary|powerpc-eabispe: ICE        |[3.4 Regression] powerpc-
                   |building __divdi3.o: in     |eabispe: ICE building
                   |ccr_bit, at                 |__divdi3.o: in ccr_bit, at
                   |config/rs6000/rs6000.c:8136 |config/rs6000/rs6000.c:8136


------- Additional Comments From pinskia at gcc dot gnu dot org  2003-08-23 17:25 -------
I think this is a regression from 3.3.

[Bug optimization/12028] [3.4 Regression] powerpc-eabispe: ICE building __divdi3.o: in ccr_bit, at config/rs6000/rs6000.c:8136

[rakdver at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12028


rakdver at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
Attachment #4638 is|0                           |1
           obsolete|                            |


------- Additional Comments From rakdver at gcc dot gnu dot org  2003-09-17 13:34 -------
Created an attachment (id=4774)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=4774&action=view)
Reduced testcase

[Bug target/12028] [3.4 Regression] powerpc-eabispe: ICE building __divdi3.o: in ccr_bit, at config/rs6000/rs6000.c:8136

[pinskia at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12028


pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
          Component|optimization                |target
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2003-09-18 06:37:52
               date|                            |


------- Additional Comments From pinskia at gcc dot gnu dot org  2003-09-18 06:37 -------
Since  Zdenek reduced this, I am marking as confirmed.

[Bug target/12028] [3.4 Regression] powerpc-eabispe: ICE building __divdi3.o: in ccr_bit, at config/rs6000/rs6000.c:8136

[janis187 at us dot ibm dot com]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12028


janis187 at us dot ibm dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |geoffk at apple dot com


------- Additional Comments From janis187 at us dot ibm dot com  2003-09-18 20:46 -------
The regression in PR 12028 was introduced or exposed by this patch:

--- gcc/gcc/ChangeLog ---

2003-05-03  Geoffrey Keating  <geoffk@apple.com>

        * config/rs6000/rs6000.c (scc_comparison_operator): Make equivalent
        to branch_positive_comparison_operator.
        (ccr_bit): Check that sCOND conditions are actually a positive bit.
        (print_operand): Remove %D substitution.
        (rs6000_emit_sCOND): Generate complement operation to ensure that
        sCOND input is a positive bit.
        * config/rs6000/rs6000.md: Rearrange sCOND templates to be in the
        same order as bCOND, and add the missing ones.  Remove the %D
        substitutions from the scc patterns.

        * simplify-rtx.c (simplify_relational_operation): Add case for
        ! (fabs(x) < 0.0).

(http://gcc.gnu.org/ml/gcc-patches/2003-05/msg00338.html)

The regression hunt took place on i686-pc-linux-gnu with a cross compiler
for powerpc-eabispe, using the reduced test case from comment #3 with -O2.

[Bug target/12028] [3.4 Regression] powerpc-eabispe: ICE building __divdi3.o: in ccr_bit, at config/rs6000/rs6000.c:8136

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2003-11-09 21:41 -------
The problem is part of the patch:
  /* When generating a sCOND operation, only positive conditions are
     allowed.  */
  if (scc_p && code != EQ && code != GT && code != LT && code != UNORDERED
      && code != GTU && code != LTU)
    abort ();
Down below that, there is case for NE (which is the code at this point).

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|2003-09-18 06:37:52         |2003-11-09 21:41:30
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12028

[Bug target/12028] [3.4 Regression] powerpc-eabispe: ICE building __divdi3.o: in ccr_bit, at config/rs6000/rs6000.c:8136

[geoffk at geoffk dot org]

------- Additional Comments From geoffk at geoffk dot org  2003-11-10 01:01 -------
Subject: Re:  [3.4 Regression] powerpc-eabispe: ICE building __divdi3.o: in ccr_bit, at config/rs6000/rs6000.c:8136

"pinskia at gcc dot gnu dot org" <gcc-bugzilla@gcc.gnu.org> writes:

> ------- Additional Comments From pinskia at gcc dot gnu dot org  2003-11-09 21:41 -------
> The problem is part of the patch:
>   /* When generating a sCOND operation, only positive conditions are
>      allowed.  */
>   if (scc_p && code != EQ && code != GT && code != LT && code != UNORDERED
>       && code != GTU && code != LTU)
>     abort ();
> Down below that, there is case for NE (which is the code at this point).

The check is clearly correct.  In the SPE case, both 'EQ' and 'NE' are
'base_bit + 1', but for a sCOND operation the bit must be set when the
condition is true, and EQ and NE are mutually exclusive.  So the
problem must be somewhere else, and removing the check would only
guarantee bad code generation.



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12028

[Bug target/12028] [3.4/3.5 Regression] powerpc-eabispe: ICE building __divdi3.o: in ccr_bit, at config/rs6000/rs6000.c:8136

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-02-10 02:00 -------
This was caused by your patch are you going to fix it?

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |geoffk at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12028

[Bug target/12028] [3.4/3.5 Regression] powerpc-eabispe: ICE building __divdi3.o: in ccr_bit, at config/rs6000/rs6000.c:8136

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-02-10 03:45 -------
Subject: Bug 12028

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	gcc-3_4-branch
Changes by:	geoffk@gcc.gnu.org	2004-02-10 03:45:04

Modified files:
	gcc            : ChangeLog 
	gcc/config/rs6000: rs6000.c 

Log message:
	PR 12028
	* config/rs6000/rs6000.c (ccr_bit): Don't let consistency check
	failure stop compilation, just print helpful message.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=2.2326.2.170&r2=2.2326.2.171
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/config/rs6000/rs6000.c.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.576.2.6&r2=1.576.2.7



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12028

[Bug target/12028] [3.5 Regression] powerpc-eabispe produces bad sCOND operation

[geoffk at gcc dot gnu dot org]

------- Additional Comments From geoffk at gcc dot gnu dot org  2004-02-10 03:50 -------
The previous patch suppresses the build failure on the 3.4 branch.  However, the underlying problem is 
still there.  I believe it has been there since the e500 port was added.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|geoffk at apple dot com     |
         AssignedTo|geoffk at gcc dot gnu dot   |unassigned at gcc dot gnu
                   |org                         |dot org
             Status|ASSIGNED                    |NEW
           Keywords|ice-on-valid-code           |ice-checking, wrong-code
      Known to work|3.3                         |
            Summary|[3.4/3.5 Regression]        |[3.5 Regression] powerpc-
                   |powerpc-eabispe: ICE        |eabispe produces bad sCOND
                   |building __divdi3.o: in     |operation
                   |ccr_bit, at                 |
                   |config/rs6000/rs6000.c:8136 |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12028

[Bug target/12028] [3.5 Regression] powerpc-eabispe produces bad sCOND operation

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|3.4.0                       |3.5.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12028

[Bug target/12028] [3.5 Regression] powerpc-eabispe produces bad sCOND operation

[aldyh at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |aldyh at gcc dot gnu dot org
                   |dot org                     |
             Status|NEW                         |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12028

[Bug target/12028] [3.4 Regression] powerpc-eabispe produces bad sCOND operation

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-04-20 14:51 -------
Should be fixed in 3.5.0 by Aldy's rewrite.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to fail|                            |3.4.0
      Known to work|                            |3.5.0
            Summary|[3.5 Regression] powerpc-   |[3.4 Regression] powerpc-
                   |eabispe produces bad sCOND  |eabispe produces bad sCOND
                   |operation                   |operation
   Target Milestone|3.5.0                       |3.4.1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12028

[Bug target/12028] [3.4 Regression] powerpc-eabispe produces bad sCOND operation

[aldyh at gcc dot gnu dot org]

------- Additional Comments From aldyh at gcc dot gnu dot org  2004-04-29 19:09 -------
Fixed on 3.4 branch by http://gcc.gnu.org/ml/gcc-patches/2004-04/msg01926.html

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12028