[Bug bootstrap/11640] New: 3.4: bootstrap ICE in rtl_verify_flow_info, at cfgrtl.c:2151

[Bug bootstrap/11640] New: 3.4: bootstrap ICE in rtl_verify_flow_info, at cfgrtl.c:2151

[olh at suse dot de]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11640

           Summary: 3.4: bootstrap ICE in  rtl_verify_flow_info, at
                    cfgrtl.c:2151
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: bootstrap
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: olh at suse dot de
                CC: gcc-bugs at gcc dot gnu dot org
 GCC build triplet: powerpc64-unknown-linux
  GCC host triplet: powerpc64-unknown-linux
GCC target triplet: powerpc64-unknown-linux

I have not tried a native powerpc64-linux build in the last 4 weeks.

LAST_UPDATED 
Wed Jul 23 05:06:55 UTC 2003

olh@mandarine:~/obj-gcc/gcc> /usr/bin/time stage1/xgcc -Bstage1/ -B/usr/powerpc64-unknown-linux-gnu/bin/   -g -O2 -DIN_GCC   -W -Wall -Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes -pedantic -Wno-long-long -Werror -fno-common   -DHAVE_CONFIG_H    -I. -I. -I/home/olh/gcc-head/gcc -I/home/olh/gcc-head/gcc/. -I/home/olh/gcc-head/gcc/config -I/home/olh/gcc-head/gcc/../include  -c insn-attrtab.c   -o insn-attrtab.o -v -v --save-temps
Reading specs from stage1/specs
Configured with: /home/olh/gcc-head/configure --prefix=/usr --disable-nls --enable-threads=posix --enable-languages=c,c++,f77,objc
Thread model: posix
gcc version 3.4 20030723 (experimental)
 stage1/cc1 -E -quiet -v -v -I. -I. -I/home/olh/gcc-head/gcc -I/home/olh/gcc-head/gcc/. -I/home/olh/gcc-head/gcc/config -I/home/olh/gcc-head/gcc/../include -iprefix /home/olh/obj-gcc/gcc/stage1/../lib/gcc-lib/powerpc64-unknown-linux-gnu/3.4/ -isystem include -isystem stage1/include -isystem /usr/powerpc64-unknown-linux-gnu/bin/include -D__unix__ -D__gnu_linux__ -D__linux__ -Dunix -D__unix -Dlinux -D__linux -Asystem=unix -Asystem=posix -DIN_GCC -DHAVE_CONFIG_H insn-attrtab.c -W -Wall -Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes -pedantic -Wno-long-long -Werror -fno-common -O2 -o insn-attrtab.i
ignoring nonexistent directory "stage1/include"
ignoring nonexistent directory "/usr/powerpc64-unknown-linux-gnu/bin/include"
ignoring nonexistent directory "/home/olh/obj-gcc/gcc/lib/gcc-lib/powerpc64-unknown-linux-gnu/3.4/include"
ignoring nonexistent directory "/home/olh/obj-gcc/gcc/lib/gcc-lib/powerpc64-unknown-linux-gnu/3.4/../../../../powerpc64-unknown-linux-gnu/include"
ignoring nonexistent directory "/usr/lib/gcc-lib/powerpc64-unknown-linux-gnu/3.4/include"
ignoring nonexistent directory "/usr/powerpc64-unknown-linux-gnu/include"
ignoring duplicate directory "."
ignoring duplicate directory "/home/olh/gcc-head/gcc"
#include "..." search starts here:
#include <...> search starts here:
 .
 /home/olh/gcc-head/gcc
 /home/olh/gcc-head/gcc/config
 /home/olh/gcc-head/include
 include
 /usr/local/include
 /usr/include
End of search list.
 stage1/cc1 -fpreprocessed insn-attrtab.i -quiet -dumpbase insn-attrtab.c -auxbase-strip insn-attrtab.o -g -O2 -W -Wall -Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes -pedantic -Wno-long-long -Werror -version -fno-common -o insn-attrtab.s
GNU C version 3.4 20030723 (experimental) (powerpc64-unknown-linux-gnu)
        compiled by GNU C version 3.2.3 (SuSE Linux).
GGC heuristics: --param ggc-min-expand=100 --param ggc-min-heapsize=131072
insn-attrtab.c: In function `internal_insn_latency':
insn-attrtab.c:100057: error: return not followed by barrier
(jump_insn 671 672 180 17 (return) -1 (nil)
    (nil))
insn-attrtab.c:100057: internal compiler error: in rtl_verify_flow_info, at cfgrtl.c:2151
Please submit a full bug report,
with preprocessed source if appropriate.
See <URL:http://gcc.gnu.org/bugs.html> for instructions.
Command exited with non-zero status 1
156.49user 3.78system 3:06.44elapsed 85%CPU (0avgtext+0avgdata 0maxresident)k
0inputs+0outputs (2396major+168498minor)pagefaults 0swaps
olh@mandarine:~/obj-gcc/gcc> ld -v
GNU ld version 2.14.90 20030701

[Bug bootstrap/11640] 3.4: bootstrap ICE in rtl_verify_flow_info, at cfgrtl.c:2151

[olh at suse dot de]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11640



------- Additional Comments From olh at suse dot de  2003-07-23 06:40 -------
Created an attachment (id=4463)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=4463&action=view)
insn-attrtab.i.bz2

preprocessed insn-attrtab.c

[Bug bootstrap/11640] p3.4 Regression]: bootstrap ICE in rtl_verify_flow_info, at cfgrtl.c:2151

[pinskia at physics dot uc dot edu]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11640


pinskia at physics dot uc dot edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |critical
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
           Keywords|                            |ice-on-valid-code
           Priority|P2                          |P1
   Last reconfirmed|0000-00-00 00:00:00         |2003-07-23 18:25:30
               date|                            |
            Summary|3.4: bootstrap ICE in       |p3.4 Regression]: bootstrap
                   |rtl_verify_flow_info, at    |ICE in
                   |cfgrtl.c:2151               |rtl_verify_flow_info, at
                   |                            |cfgrtl.c:2151
            Version|unknown                     |3.4


------- Additional Comments From pinskia at physics dot uc dot edu  2003-07-23 18:25 -------
Confirmed on the mainline (20030723).
Reduced source (34):
int
internal_insn_latency (int insn_code, int insn2_code )
{
  switch (insn_code)
    {
    case 256:
      switch (insn2_code)
        {
        case 267:
          return 8;
        case 266:
          return 8;
        case 265:
          return 8;
        case 264:
          return 8;
        case 263:
          return 8;
        }
      break;
    case 273:
      switch (insn2_code)
        {
        case 267:
          return 5;
        case 266:
          return 5;
        case 277:
          return 3;
        }
      break;
    }
  return 0;
}

[Bug bootstrap/11640] p3.4 Regression]: bootstrap ICE in rtl_verify_flow_info, at cfgrtl.c:2151

[janis187 at us dot ibm dot com]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11640


janis187 at us dot ibm dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rth at redhat dot com


------- Additional Comments From janis187 at us dot ibm dot com  2003-07-24 23:31 -------
The regression in PR 11640 was introduced or exposed by this patch:

--- gcc/gcc/ChangeLog ---

2003-03-23  Richard Henderson  <rth@redhat.com>

        * cfgcleanup.c (try_optimize_cfg): Allow merging of tablejumps
        before flow2.
        * cfgrtl.c (try_redirect_by_replacing_jump): Similarly.

The regression hunt took place on i686-pc-linux-gnu with a cross cc1
for powerpc64-linux, using the test case in comment #2 with "-g -O2".

[Bug bootstrap/11640] [3.4 Regression]: bootstrap ICE in rtl_verify_flow_info, at cfgrtl.c:2151

[pinskia at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11640



------- Additional Comments From pinskia at gcc dot gnu dot org  2003-08-24 14:53 -------
It works for the -m32 case.

[Bug bootstrap/11640] [3.4 Regression]: bootstrap ICE in rtl_verify_flow_info, at cfgrtl.c:2151

[olh at suse dot de]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11640



------- Additional Comments From olh at suse dot de  2003-09-08 08:36 -------
Who gets the beer?

http://gcc.gnu.org/ml/gcc-testresults/2003-09/msg00220.html

[Bug bootstrap/11640] [3.4 Regression]: bootstrap ICE in rtl_verify_flow_info, at cfgrtl.c:2151

[pinskia at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11640


pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


------- Additional Comments From pinskia at gcc dot gnu dot org  2003-09-08 12:52 -------
I do not know who gets the beer.
Closing as it is reported fixed by the submitter.

[Bug bootstrap/11640] [3.4 Regression]: bootstrap ICE in rtl_verify_flow_info, at cfgrtl.c:2151

[olh at suse dot de]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11640


olh at suse dot de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |


------- Additional Comments From olh at suse dot de  2003-09-08 13:58 -------
Sorry, testcase does still fail, just bootstrap is ok again.

olh@mandarine:~> PATH=~/obj-gcc/gcc obj-gcc/gcc/xgcc -Wall -O2 -c pr11640.c  -v 
Using built-in specs.
Configured with: '/home/olh/gcc-head/configure' '--prefix=/usr '--disable-nls '--enable-threads=posix '--enable-languages=c,c++,f77,objc
Thread model: posix
gcc version 3.4 20030906 (experimental)
 cc1 -quiet -v -iprefix /home/olh/obj-gcc/gcc/../lib/gcc/powerpc64-unknown-linux-gnu/3.4/ -D__unix__ -D__gnu_linux__ -D__linux__ -Dunix -D__unix -Dlinux -D__linux -Asystem=unix -Asystem=posix pr11640.c -quiet -dumpbase pr11640.c -auxbase pr11640 -O2 -Wall -version -o /tmp/ccdgRmbc.s
ignoring nonexistent directory "/home/olh/obj-gcc/gcc/../lib/gcc/powerpc64-unknown-linux-gnu/3.4/include"
ignoring nonexistent directory "/home/olh/obj-gcc/gcc/../lib/gcc/powerpc64-unknown-linux-gnu/3.4/../../../../powerpc64-unknown-linux-gnu/include"
ignoring nonexistent directory "/usr/lib/gcc/powerpc64-unknown-linux-gnu/3.4/include"
ignoring nonexistent directory "/usr/lib/../powerpc64-unknown-linux-gnu/include"
#include "..." search starts here:
#include <...> search starts here:
 /usr/local/include
 /usr/include
End of search list.
GNU C version 3.4 20030906 (experimental) (powerpc64-unknown-linux-gnu)
        compiled by GNU C version 3.4 20030906 (experimental).
GGC heuristics: --param ggc-min-expand=30 --param ggc-min-heapsize=4096
pr11640.c: In function `internal_insn_latency':

pr11640.c:34: error: return not followed by barrier
(jump_insn 177 53 71 4 (return) -1 (nil)
    (nil))
pr11640.c:34: internal compiler error: in rtl_verify_flow_info, at cfgrtl.c:2151
Please submit a full bug report,
with preprocessed source if appropriate.
See <URL:http://gcc.gnu.org/bugs.html> for instructions.

[Bug bootstrap/11640] [3.4 Regression]: bootstrap ICE in rtl_verify_flow_info, at cfgrtl.c:2151

[zlomek at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11640


zlomek at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |ASSIGNED
   Last reconfirmed|2003-08-24 14:52:36         |2003-09-08 15:59:16
               date|                            |

[Bug bootstrap/11640] [3.4 Regression]: bootstrap ICE in rtl_verify_flow_info, at cfgrtl.c:2151

[zlomek at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11640


zlomek at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|zlomekj at suse dot cz      |unassigned at gcc dot gnu
                   |                            |dot org
             Status|ASSIGNED                    |NEW

[Bug bootstrap/11640] [3.4 Regression]: bootstrap ICE in rtl_verify_flow_info, at cfgrtl.c:2151

[zlomek at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11640


zlomek at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|2003-09-08 15:59:16         |2003-09-09 12:35:17
               date|                            |


------- Additional Comments From zlomek at gcc dot gnu dot org  2003-09-09 12:35 -------
The bug occurs on 3.3 branch with checking enabled too.

I was analyzing the bug, the problem is that when try_redirect_by_replacing_jump 
changes the tablejump to a simple jump the label is not completelly deleted
because it is still used in code. When merging blocks the return is copied to
place where the tablejump was, the barrier is not directly after the (return)
jump and it causes the ICE. I hope this description helps to fix the bug (by
someone else).

(insn 110 69 49 2 (set (reg:DI 66 ctr [136])
        (reg:DI 0 r0)) 326 {*movdi_internal64} (insn_list 69 (nil))
    (expr_list:REG_DEAD (reg:DI 0 r0)
        (nil)))

(note 49 110 53 2 ("/suse/zlomekj/a.c") 18)

(insn 53 49 112 2 /suse/zlomekj/a.c:18 (set (reg:DI 3 r3 [orig:118 <result> ] [118])
        (const_int 8 [0x8])) 326 {*movdi_internal64} (nil)
    (nil))

(jump_insn 112 53 132 2 (return) -1 (nil)
    (nil))

(note/s 71 132 73 "" NOTE_INSN_DELETED_LABEL 10)

(barrier 73 71 17)

(note 17 73 25 13 ("/suse/zlomekj/a.c") 10)


Although the following patch fixes the testcase it does NOT bootstrap.

Index: cfgrtl.c
===================================================================
RCS file: /cvs/gcc-cvs/gcc/gcc/cfgrtl.c,v
retrieving revision 1.97
diff -c -3 -p -r1.97 cfgrtl.c
*** cfgrtl.c    22 Aug 2003 06:45:12 -0000      1.97
--- cfgrtl.c    9 Sep 2003 05:56:33 -0000
*************** try_redirect_by_replacing_jump (edge e, 
*** 790,796 ****
        if (tablejump_p (insn, &label, &table))
        delete_insn_chain (label, table);

!       barrier = next_nonnote_insn (src->end);
        if (!barrier || GET_CODE (barrier) != BARRIER)
        emit_barrier_after (src->end);
      }
--- 790,796 ----
        if (tablejump_p (insn, &label, &table))
        delete_insn_chain (label, table);

!       barrier = NEXT_INSN (src->end);
        if (!barrier || GET_CODE (barrier) != BARRIER)
        emit_barrier_after (src->end);
      }


It causes the barrier to be emmitted but leaves the other one there:


(insn 53 49 112 2 /suse/zlomekj/a.c:18 (set (reg:DI 3 r3 [orig:118 <result> ] [118])
        (const_int 8 [0x8])) 326 {*movdi_internal64} (nil)
    (nil))

(jump_insn 112 53 132 2 (return) -1 (nil)
    (nil))

(barrier 132 112 71)

(note/s 71 132 73 "" NOTE_INSN_DELETED_LABEL 10)

(barrier 73 71 17)

[Bug bootstrap/11640] [3.4 Regression]: bootstrap ICE in rtl_verify_flow_info, at cfgrtl.c:2151

[olh at suse dot de]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11640


olh at suse dot de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED


------- Additional Comments From olh at suse dot de  2003-10-05 08:14 -------

olh@mandarine:~> cat pr11640.c
int
internal_insn_latency (int insn_code, int insn2_code )
{
  switch (insn_code)
    {
    case 256:
      switch (insn2_code)
        {
        case 267:
          return 8;
        case 266:
          return 8;
        case 265:
          return 8;
        case 264:
          return 8;
        case 263:
          return 8;
        }
      break;
    case 273:
      switch (insn2_code)
        {
        case 267:
          return 5;
        case 266:
          return 5;
        case 277:
          return 3;
        }
      break;
    }
  return 0;
}

olh@mandarine:~> install-gcc-head/bin/gcc -v -Wall -c pr11640.c
Reading specs from /home/olh/install-gcc-head/lib/gcc/powerpc64-unknown-linux-gnu/3.4/specs
Configured with: /home/olh/gcc-head/configure --prefix=/home/olh/install-gcc-head --disable-nls --enable-threads=posix --enable-__cxa_atexit --enable-languages=c,c++,f77,objc
Thread model: posix
gcc version 3.4 20031004 (experimental)
 /home/olh/install-gcc-head/libexec/gcc/powerpc64-unknown-linux-gnu/3.4/cc1 -quiet -v -D__unix__ -D__gnu_linux__ -D__linux__ -Dunix -D__unix -Dlinux -D__linux -Asystem=unix -Asystem=posix pr11640.c -quiet -dumpbase pr11640.c -auxbase pr11640 -Wall -version -o /tmp/cc2Zgeju.s
ignoring nonexistent directory "/home/olh/install-gcc-head/lib/gcc/powerpc64-unknown-linux-gnu/3.4/../../../../powerpc64-unknown-linux-gnu/include"
#include "..." search starts here:
#include <...> search starts here:
 /usr/local/include
 /home/olh/install-gcc-head/include
 /home/olh/install-gcc-head/lib/gcc/powerpc64-unknown-linux-gnu/3.4/include
 /usr/include
End of search list.
GNU C version 3.4 20031004 (experimental) (powerpc64-unknown-linux-gnu)
        compiled by GNU C version 3.4 20031004 (experimental).
GGC heuristics: --param ggc-min-expand=30 --param ggc-min-heapsize=4096
 as -a64 -mppc64 -V -Qy -o pr11640.o /tmp/cc2Zgeju.s
GNU assembler version 2.14.90 (powerpc64-suse-linux) using BFD version 2.14.90 20030701

[Bug optimization/11640] [3.4 Regression]: bootstrap ICE in rtl_verify_flow_info, at cfgrtl.c:2151

[zlomek at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11640


zlomek at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
          Component|bootstrap                   |optimization
         Resolution|FIXED                       |


------- Additional Comments From zlomek at gcc dot gnu dot org  2003-10-30 08:27 -------
Olaf, the bug was fixed only in hammer-3_3-branch (by me),
mainline (and 3.3 branch) still contain this bug. So I'm reopening the bug report.

[Bug optimization/11640] [3.4 Regression]: bootstrap ICE in rtl_verify_flow_info, at cfgrtl.c:2151

[pinskia at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11640


pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |zlomek at gcc dot gnu dot
                   |dot org                     |org
             Status|REOPENED                    |ASSIGNED

[Bug optimization/11640] [3.4 Regression]: bootstrap ICE in rtl_verify_flow_info, at cfgrtl.c:2151

[zlomek at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11640



------- Additional Comments From zlomek at gcc dot gnu dot org  2003-10-30 08:37 -------
Proposed fix:

http://gcc.gnu.org/ml/gcc-patches/2003-09/msg00905.html

[Bug optimization/11640] [3.4 Regression]: bootstrap ICE in rtl_verify_flow_info, at cfgrtl.c:2151

[zlomek at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=11640


zlomek at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


------- Additional Comments From zlomek at gcc dot gnu dot org  2003-10-31 14:19 -------
I have commited http://gcc.gnu.org/ml/gcc-patches/2003-09/msg00905.html