[Bug target/12021] New: warning "cpu" and "machine" reasserted for every file

[Bug target/12021] New: warning "cpu" and "machine" reasserted for every file

[dhazeghi at yahoo dot com]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12021

           Summary: warning "cpu" and "machine" reasserted for every file
           Product: gcc
           Version: 3.4
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: target
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: dhazeghi at yahoo dot com
                CC: gcc-bugs at gcc dot gnu dot org
GCC target triplet: m68k-netbsdelf

With gcc mainline and a cross-compiler to m68k-netbsdelf, compiling any file yields:

bash-2.04$ m68k-netbsdelf1.6.1-gcc foo.c 
<built-in>:72:9: warning: "cpu" re-asserted
<built-in>:73:13: warning: "machine" re-asserted

bash-2.04$ cat foo.i 
# 1 "foo.c"
# 1 "<built-in>"
# 1 "<command line>"
# 1 "foo.c"
int main()
{ return 0;}

Aside from being annoying, this means native bootstraps will fail with -Werror.

[Bug target/12021] warning "cpu" and "machine" reasserted for every file

[pinskia at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12021


pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |WAITING


------- Additional Comments From pinskia at gcc dot gnu dot org  2003-08-22 21:32 -------
Dara,
Can you try this patch (which should fix it, the problem is that m68k.h asserts it in 
TARGET_CPU_CPP_BUILTINS while netbsd(-elf).h asserts it also in TARGET_OS_CPP_BUILTINS which 
is wrong):
Index: netbsd-elf.h
============================================================
=======
RCS file: /cvs/gcc/gcc/gcc/config/m68k/netbsd-elf.h,v
retrieving revision 1.16
diff -u -d -b -w -u -p -r1.16 netbsd-elf.h
--- netbsd-elf.h        21 Aug 2003 01:03:37 -0000      1.16
+++ netbsd-elf.h        22 Aug 2003 21:30:33 -0000
@@ -31,8 +31,6 @@ Boston, MA 02111-1307, USA.  */
       builtin_define ("__m68k__");             \
       builtin_define ("__SVR4_ABI__");         \
       builtin_define ("__motorola__");         \
-      builtin_assert ("cpu=m68k");             \
-      builtin_assert ("machine=m68k");         \
     }                                          \
   while (0)
 
Index: netbsd.h
============================================================
=======
RCS file: /cvs/gcc/gcc/gcc/config/m68k/netbsd.h,v
retrieving revision 1.14
diff -u -d -b -w -u -p -r1.14 netbsd.h
--- netbsd.h    21 Aug 2003 17:27:23 -0000      1.14
+++ netbsd.h    22 Aug 2003 21:30:33 -0000
@@ -6,8 +6,6 @@
       builtin_define_std ("m68k");             \
       builtin_define_std ("mc68000");          \
       builtin_define_std ("mc68020");          \
-      builtin_assert ("cpu=m68k");             \
-      builtin_assert ("machine=m68k");         \
     }                                          \
   while (0)

[Bug target/12021] [3.4 Regression] warning "cpu" and "machine" reasserted for every file

[pinskia at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12021


pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |critical
           Keywords|                            |diagnostic
           Priority|P2                          |P1
            Summary|warning "cpu" and "machine" |[3.4 Regression] warning
                   |reasserted for every file   |"cpu" and "machine"
                   |                            |reasserted for every file


------- Additional Comments From pinskia at gcc dot gnu dot org  2003-08-23 17:44 -------
This is a regresion when the m68k config files where rewritten to use define_assert and such.

[Bug target/12021] [3.4 Regression] warning "cpu" and "machine" reasserted for every file

[dhazeghi at yahoo dot com]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12021



------- Additional Comments From dhazeghi at yahoo dot com  2003-08-24 21:19 -------
Yes, the patch fixes the warning, and the target (and some trivial test programs) build fine. 
Thanks.

[Bug target/12021] [3.4 Regression] warning "cpu" and "machine" reasserted for every file

[pinskia at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12021


pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |pinskia at gcc dot gnu dot
                   |dot org                     |org
             Status|WAITING                     |ASSIGNED


------- Additional Comments From pinskia at gcc dot gnu dot org  2003-08-24 23:13 -------
I will submit this next week.

[Bug target/12021] [3.4 Regression] warning "cpu" and "machine" reasserted for every file

[pinskia at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12021



------- Additional Comments From pinskia at gcc dot gnu dot org  2003-09-08 06:05 -------
Patch: submitted <http://gcc.gnu.org/ml/gcc-patches/2003-09/msg00453.html>.

[Bug target/12021] [3.4 Regression] warning "cpu" and "machine" reasserted for every file

[pinskia at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12021



------- Additional Comments From pinskia at gcc dot gnu dot org  2003-09-11 19:42 -------
This one has been approved I will commit later today.

[Bug target/12021] [3.4 Regression] warning "cpu" and "machine" reasserted for every file

[cvs-commit at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12021



------- Additional Comments From cvs-commit at gcc dot gnu dot org  2003-09-14 04:43 -------
Subject: Bug 12021

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	pinskia@gcc.gnu.org	2003-09-14 04:43:10

Modified files:
	gcc            : ChangeLog 
	gcc/config/m68k: netbsd-elf.h netbsd.h 

Log message:
	2003-09-13  Andrew Pinski <pinskia@physics.uc.edu>
	
	PR target/12021
	* config/m68k/netbsd-elf.h (TARGET_OS_CPP_BUILTINS): Remove the asserts
	as they already are done in config/m68k/m68k.h.
	* config/m68k/netbsd.h (TARGET_OS_CPP_BUILTINS): Likewise

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&r1=2.1047&r2=2.1048
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/config/m68k/netbsd-elf.h.diff?cvsroot=gcc&r1=1.16&r2=1.17
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/config/m68k/netbsd.h.diff?cvsroot=gcc&r1=1.14&r2=1.15

[Bug target/12021] [3.4 Regression] warning "cpu" and "machine" reasserted for every file

[pinskia at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12021


pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


------- Additional Comments From pinskia at gcc dot gnu dot org  2003-09-14 04:44 -------
Fixed for 3.4.