[Bug c++/12161] New: ICE during bootstrap, locale-inst.c, cp/call.c: 4571

[Bug c++/12161] New: ICE during bootstrap, locale-inst.c, cp/call.c: 4571

[mec at shout dot net]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12161

           Summary: ICE during bootstrap, locale-inst.c, cp/call.c: 4571
           Product: gcc
           Version: 3.4
            Status: UNCONFIRMED
          Severity: critical
          Priority: P2
         Component: c++
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: mec at shout dot net
                CC: gcc-bugs at gcc dot gnu dot org
 GCC build triplet: i686-pc-linux-gnu
  GCC host triplet: i686-pc-linux-gnu
GCC target triplet: i686-pc-linux-gnu

gcc ICE's during bootstrap while compiling locale-inst.c.

This is a regression from gcc 3.3.1.
This happens with gcc HEAD 2003-09-03 17:51:23 UTC.

I pre-processed locale-inst.c into locale-inst.ii and renamed it to z6.ii.  I
will attach z6.ii so that you can reproduce the bug.

The full ICE is:

GGC heuristics: --param ggc-min-expand=38 --param ggc-min-heapsize=15575
z6.ii: In member function `std::money_base::pattern std::moneypunct<_CharT,
_Intl>::neg_format() const [with _CharT = char, bool _Intl =  true]':
z6.ii:26531:   instantiated from here
z6.ii:20295: internal compiler error: tree check: expected tree_list, have
goto_stmt in build_over_call, at cp/call.c:4571

The ICE is sensitive to the size of ggc-min-heapsize.  If I set ggc-min-heapsize
to 12000, the ICE goes away.  If I set ggc-min-heapsize to 16384, the ICE goes
away.  15575 happens to be the "natural" value of ggc-min-heapsize reported by
"gcc -v" on my machine (128 MB memory with some memory stolen for video).

Compile with:

 
/berman/fsf/_today_/berman/build/target/native/gcc/gcc-HEAD-binutils-2.14/gcc/xgcc
-v -B
/berman/fsf/_today_/berman/build/target/native/gcc/gcc-HEAD-binutils-2.14/gcc/
-O2 -g -fno-implicit-templates -S --param ggc-min-expand=38 --param
ggc-min-heapsize=15575 z6.ii

I did some date-searching and came up with these dates:

2003-08-29 18:00:00 UTC  works fine
2003-08-29 23:00:00 UTC  ICE, "segment violation"
2003-08-29 23:30:00 UTC  ICE, cp/call.c: 4571

The 23:00 ICE is a different ICE that happens earlier and is not sensitive to
heap size.  It looks like a bug that has already been fixed.

The 23:30 ICE is sensitive to heap size.  This version of gcc works fine with
ggc-min-heapsize equal to 65536, 32768, 16384, or 12000.  It ICEs out with
ggc-min-heapsize equal to 15575.

[Bug c++/12161] ICE during bootstrap, locale-inst.c, cp/call.c: 4571

[geoffk at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12161


geoffk at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2003-09-03 23:53:48
               date|                            |

[Bug c++/12161] ICE during bootstrap, locale-inst.c, cp/call.c: 4571

[mec at shout dot net]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12161



------- Additional Comments From mec at shout dot net  2003-09-04 17:28 -------
Note: this is still happening after rth's addition of push_ggc_context /
pup_ggc_context in optimize_function.

I rebuilt gcc with

  --enable-checking=misc,tree,gc,rtl,rtlflag,fold,gcac

And the same ICE happens earlier during the bootstrap, in fstream-inst.cc.  The
compiler still ICEs at the same point in the attachment z6.ii.

This feels like another garbage collection bug lurking in this patch:

2003-08-29  Richard Henderson  <rth@redhat.com>
            Jason Merrill <jason@redhat.com>

        * cp-lang.c (LANG_HOOKS_RTL_EXPAND_START): New.
        (LANG_HOOKS_RTL_EXPAND_STMT): New.
        * cp-tree.h (cxx_expand_function_start): Declare.
        * decl.c (start_function): Use allocate_struct_function.
        Move stmts_are_full_exprs_p assertion from expand_body.
        Do not free_after_parsing or free_after_compilation.
        (cxx_push_function_context): Move code to set struct function
        data from genrtl_start_function.
        * optimize.c (optimize_function): Don't inc/dec function_depth.
        * semantics.c (expand_body): Use tree_rest_of_compilation.
        (cxx_expand_function_start): Rename from genrtl_start_function,
        omit bits done by tree_rest_of_compilation.
        (genrtl_finish_function): Remove.
        (clear_decl_rtl): Move to ../tree-optimize.c.

Of course it could be anything, but that's what it feels like.

[Bug c++/12161] ICE during bootstrap, locale-inst.c, cp/call.c: 4571

[mec at shout dot net]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12161



------- Additional Comments From mec at shout dot net  2003-09-04 19:23 -------
Here's a stack trace in ggc_collect.  ggc_collect gets called about 2000 times
because I turned on --enable-check=everything, but only one call makes it past
the "if memory has not grown then just return" check at the beginning.  So if
it's a gc bug, it's probably in this call.

#0  ggc_collect ()
    at /berman/fsf/_today_/source/gcc/HEAD/gcc/gcc/ggc-page.c:1750
#1  0x0860cce7 in rest_of_compilation (decl=0x40f53870)
    at /berman/fsf/_today_/source/gcc/HEAD/gcc/gcc/toplev.c:3212
#2  0x08671a5e in tree_rest_of_compilation (fndecl=0x40f53870)
    at /berman/fsf/_today_/source/gcc/HEAD/gcc/gcc/tree-optimize.c:173
#3  0x0812f3b4 in expand_body (fn=0x40f53870)
    at /berman/fsf/_today_/source/gcc/HEAD/gcc/gcc/cp/semantics.c:2892
#4  0x080b0b07 in instantiate_decl (d=0x40f53870, defer_ok=1089812592)
    at /berman/fsf/_today_/source/gcc/HEAD/gcc/gcc/cp/pt.c:10955
#5  0x080dd236 in mark_used (decl=0x40f53870)
    at /berman/fsf/_today_/source/gcc/HEAD/gcc/gcc/cp/decl2.c:4229
#6  0x0805465b in build_over_call (cand=0x41709050, flags=3)
    at /berman/fsf/_today_/source/gcc/HEAD/gcc/gcc/cp/call.c:4567
#7  0x0805661d in build_new_method_call (instance=0x417058d4, fns=0x0,
    args=0x0, conversion_path=0x40f4b280, flags=3)
    at /berman/fsf/_today_/source/gcc/HEAD/gcc/gcc/cp/call.c:5071
#8  0x080a71bd in tsubst_copy_and_build (t=0x40f2cb58, args=0x40f4dde0,
    complain=3, in_decl=0x40f333cc, function_p=false)
    at /berman/fsf/_today_/source/gcc/HEAD/gcc/gcc/cp/pt.c:8142
#9  0x080a4d44 in tsubst_expr (t=0x40f2cb58, args=0x40f4dde0, complain=3,
    in_decl=0x40f333cc)
    at /berman/fsf/_today_/source/gcc/HEAD/gcc/gcc/cp/pt.c:7498
#10 0x080a425b in tsubst_expr (t=0x40f3cab4, args=0x40f4dde0, complain=3,
    in_decl=0x40f333cc)
    at /berman/fsf/_today_/source/gcc/HEAD/gcc/gcc/cp/pt.c:7511
#11 0x080a39bc in tsubst_expr (t=0x40f3ca8c, args=0x40f4dde0, complain=3,
    in_decl=0x40f333cc)
    at /berman/fsf/_today_/source/gcc/HEAD/gcc/gcc/cp/pt.c:7679
#12 0x080a39bc in tsubst_expr (t=0x40f3ca78, args=0x40f4dde0, complain=3,
    in_decl=0x40f333cc)
    at /berman/fsf/_today_/source/gcc/HEAD/gcc/gcc/cp/pt.c:7679
#13 0x080b0adb in instantiate_decl (d=0x40f51a8c, defer_ok=0)
    at /berman/fsf/_today_/source/gcc/HEAD/gcc/gcc/cp/pt.c:10946
#14 0x080b1440 in instantiate_pending_templates ()
    at /berman/fsf/_today_/source/gcc/HEAD/gcc/gcc/cp/pt.c:11031
#15 0x080d8eb5 in finish_file ()
    at /berman/fsf/_today_/source/gcc/HEAD/gcc/gcc/cp/decl2.c:2675
#16 0x0860a04a in compile_file ()
    at /berman/fsf/_today_/source/gcc/HEAD/gcc/gcc/toplev.c:1737
#17 0x0860e9ce in do_compile ()
    at /berman/fsf/_today_/source/gcc/HEAD/gcc/gcc/toplev.c:4412
#18 0x0860eac5 in toplev_main (argc=21954848, argv=0x1)
    at /berman/fsf/_today_/source/gcc/HEAD/gcc/gcc/toplev.c:4452
#19 0x0817923b in main (argc=21954848, argv=0x14f0120)
    at /berman/fsf/_today_/source/gcc/HEAD/gcc/gcc/main.c:35
#20 0x420158d4 in __libc_start_main () from /lib/i686/libc.so.6

[Bug c++/12161] ICE during bootstrap, locale-inst.c, cp/call.c: 4571

[mec at shout dot net]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12161



------- Additional Comments From mec at shout dot net  2003-09-04 19:45 -------
This patch makes pr gcc/12161 stop happening.  This may not be
the right fix.  It's just there to point people in the right
direction, and I use it so I can build my gcc.

Michael C

2003-09-04  Michael Chastain  <mec@shout.net>

        * cp/semantics.c (expand_body): Push/pop ggc context around
        the call to tree_rest_of_compilation.

Index: cp/semantics.c
===================================================================
RCS file: /cvsroot/gcc/gcc/gcc/cp/semantics.c,v
retrieving revision 1.354
diff -u -r1.354 semantics.c
--- cp/semantics.c      2 Sep 2003 17:32:28 -0000       1.354
+++ cp/semantics.c      4 Sep 2003 19:29:39 -0000
@@ -2889,7 +2889,9 @@
   optimize_function (fn);
   timevar_pop (TV_INTEGRATION);

+  ggc_push_context ();
   tree_rest_of_compilation (fn);
+  ggc_pop_context ();

   current_function_decl = saved_function;
   input_location = saved_loc;

[Bug c++/12161] ICE during bootstrap, locale-inst.c, cp/call.c: 4571

[cvs-commit at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12161



------- Additional Comments From cvs-commit at gcc dot gnu dot org  2003-09-04 19:48 -------
Subject: Bug 12161

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	geoffk@gcc.gnu.org	2003-09-04 19:48:23

Modified files:
	gcc/cp         : ChangeLog decl2.c tree.c 

Log message:
	PR 12161
	* decl2.c (mark_used): Use ggc_push_context/ggc_pop_context.
	* tree.c (cp_cannot_inline_tree_fn): Likewise.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/ChangeLog.diff?cvsroot=gcc&r1=1.3644&r2=1.3645
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/decl2.c.diff?cvsroot=gcc&r1=1.664&r2=1.665
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/tree.c.diff?cvsroot=gcc&r1=1.343&r2=1.344

[Bug c++/12161] ICE during bootstrap, locale-inst.c, cp/call.c: 4571

[geoffk at geoffk dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12161



------- Additional Comments From geoffk at geoffk dot org  2003-09-04 22:44 -------
Subject: Re:  ICE during bootstrap, locale-inst.c, cp/call.c: 4571

> Date: 4 Sep 2003 19:23:48 -0000
> From: "mec at shout dot net" <gcc-bugzilla@gcc.gnu.org>

> Here's a stack trace in ggc_collect.  ggc_collect gets called about 2000 times
> because I turned on --enable-check=everything, but only one call makes it past
> the "if memory has not grown then just return" check at the beginning.  So if
> it's a gc bug, it's probably in this call.
> 
> #0  ggc_collect ()
>     at /berman/fsf/_today_/source/gcc/HEAD/gcc/gcc/ggc-page.c:1750
> #1  0x0860cce7 in rest_of_compilation (decl=0x40f53870)
>     at /berman/fsf/_today_/source/gcc/HEAD/gcc/gcc/toplev.c:3212
> #2  0x08671a5e in tree_rest_of_compilation (fndecl=0x40f53870)
>     at /berman/fsf/_today_/source/gcc/HEAD/gcc/gcc/tree-optimize.c:173
> #3  0x0812f3b4 in expand_body (fn=0x40f53870)
>     at /berman/fsf/_today_/source/gcc/HEAD/gcc/gcc/cp/semantics.c:2892
> #4  0x080b0b07 in instantiate_decl (d=0x40f53870, defer_ok=1089812592)
>     at /berman/fsf/_today_/source/gcc/HEAD/gcc/gcc/cp/pt.c:10955
> #5  0x080dd236 in mark_used (decl=0x40f53870)
>     at /berman/fsf/_today_/source/gcc/HEAD/gcc/gcc/cp/decl2.c:4229

This should be fixed by my recent patch.  Please try it again...

[Bug c++/12161] ICE during bootstrap, locale-inst.c, cp/call.c: 4571

[mec at shout dot net]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12161



------- Additional Comments From mec at shout dot net  2003-09-05 02:25 -------
Subject: Re:  ICE during bootstrap, locale-inst.c, cp/call.c: 4571

It works for me.

I configured gcc with all the --enable-check turned on and
--enable-languages=c,c++.  'make all' worked just fine.
locale-inst.cc took 96 minutes to compile, 10 times as long as anything
else.  I assume this is normal with all the checks turned on.

The specific file z6.ii compiles now (and it doesn't take 96
minutes).

This PR can be closed.  Thanks!

Michael C

[Bug c++/12161] ICE during bootstrap, locale-inst.c, cp/call.c: 4571

[pinskia at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12161


pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


------- Additional Comments From pinskia at gcc dot gnu dot org  2003-09-05 14:02 -------
Fixed by Keating's patch.

[Bug c++/12161] ICE during bootstrap, locale-inst.c, cp/call.c: 4571

[cvs-commit at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12161



------- Additional Comments From cvs-commit at gcc dot gnu dot org  2003-09-08 13:55 -------
Subject: Bug 12161

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	tree-ssa-20020619-branch
Changes by:	law@gcc.gnu.org	2003-09-08 13:55:12

Modified files:
	gcc/cp         : ChangeLog decl2.c tree.c 

Log message:
	PR 12161
	* decl2.c (mark_used): Use ggc_push_context/ggc_pop_context.
	* tree.c (cp_cannot_inline_tree_fn): Likewise.
	
	Bring over from the mainline sources.  Fixes compiler abort building jni.cc

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/ChangeLog.diff?cvsroot=gcc&only_with_tag=tree-ssa-20020619-branch&r1=1.2849.2.51&r2=1.2849.2.52
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/decl2.c.diff?cvsroot=gcc&only_with_tag=tree-ssa-20020619-branch&r1=1.540.2.33&r2=1.540.2.34
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/cp/tree.c.diff?cvsroot=gcc&only_with_tag=tree-ssa-20020619-branch&r1=1.286.2.31&r2=1.286.2.32

[Bug c++/12161] ICE during bootstrap, locale-inst.c, cp/call.c: 4571

[pinskia at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12161


pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |3.4