From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugs-return-70937-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 29215 invoked by alias); 21 Sep 2003 08:55:44 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Received: (qmail 29208 invoked by uid 48); 21 Sep 2003 08:55:43 -0000
Date: Sun, 21 Sep 2003 10:36:00 -0000
From: "suckfish at ihug dot co dot nz" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Message-ID: <20030921085536.12350.suckfish@ihug.co.nz>
Reply-To: gcc-bugzilla@gcc.gnu.org
Subject: [Bug libgcj/12350] New: StringBuffer.substring handles shared flag incorrected.
X-Bugzilla-Reason: CC
X-SW-Source: 2003-09/txt/msg01638.txt.bz2
List-Id: <gcc-bugs.sourceware.org>

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12350

           Summary: StringBuffer.substring handles shared flag incorrected.
           Product: gcc
           Version: 3.4
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: libgcj
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: suckfish at ihug dot co dot nz
                CC: gcc-bugs at gcc dot gnu dot org

The substring method of java.lang.StringBuffer can clear the boolean shared
field of the object.  This is incorrect.  The value may be shared for some
reason other than the current call to substring.

Test case and patch inline below.

-----------------test case------------------
public class test
{
    static public void main (String[] ignored) throws Throwable
    {
	StringBuffer b = new StringBuffer ("Good string.  More than 16 chars.");

	// Should cause sharing.
	String s = b.toString();

	// Take a char by char unshared copy of s.
	String t = new String (s.toCharArray());

	b.substring (0, 4);	// BUG: Clears shared flag.
	b.replace (0, 4, "Bad "); // Modifies shared data.

	System.out.println (s);
	assert s.equals (t);
    }

}
-------------------patch---------------------
Index: libjava/java/lang/StringBuffer.java
===================================================================
RCS file: /cvsroot/gcc/gcc/libjava/java/lang/StringBuffer.java,v
retrieving revision 1.15
diff -u -r1.15 StringBuffer.java
--- libjava/java/lang/StringBuffer.java 24 Mar 2003 00:50:18 -0000      1.15
+++ libjava/java/lang/StringBuffer.java 21 Sep 2003 08:53:19 -0000
@@ -565,7 +565,9 @@
     if (len == 0)
       return "";
     // Share the char[] unless 3/4 empty.
-    shared = (len << 2) >= value.length;
+    boolean shared = (len << 2) >= value.length;
+    if (shared)
+      this.shared = true;
     // Package constructor avoids an array copy.
     return new String(value, beginIndex, len, shared);
   }