public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug c/12466] New: -Wold-style-definition incorrectly warns with ellipsises.
@ 2003-09-30 17:59 kcook at gcc dot gnu dot org
  2003-09-30 18:14 ` [Bug c/12466] " kcook at gcc dot gnu dot org
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: kcook at gcc dot gnu dot org @ 2003-09-30 17:59 UTC (permalink / raw)
  To: gcc-bugs

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12466

           Summary: -Wold-style-definition incorrectly warns with
                    ellipsises.
           Product: gcc
           Version: 3.4
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: c
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: kcook at gcc dot gnu dot org
                CC: gcc-bugs at gcc dot gnu dot org

In attempting to compile GCC with -Wold-style-definition, I ran into many of the
following errors, which are false positives due to the ellipsis.

>From gengtype.c:70

/* Wrapper for xvasprintf.  */
char *
xasprintf (const char *format, ...)
{
  char *result;
  va_list ap;

  va_start (ap, format);
  xvasprintf (&result, format, ap);
  va_end (ap);
  return result;
}

This warns with:

../../gcc-snapshot/gcc/gengtype.c: In function `xasprintf':
../../gcc-snapshot/gcc/gengtype.c:73: warning: old-style parameter declaration

Reduced Testcase and suggested patch coming shortly


^ permalink raw reply	[flat|nested] 5+ messages in thread
* [Bug c/12466] -Wold-style-definition incorrectly warns with ellipsises.
  2003-09-30 17:59 [Bug c/12466] New: -Wold-style-definition incorrectly warns with ellipsises kcook at gcc dot gnu dot org
@ 2003-09-30 18:14 ` kcook at gcc dot gnu dot org
  2003-09-30 18:23 ` kcook at gcc dot gnu dot org
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: kcook at gcc dot gnu dot org @ 2003-09-30 18:14 UTC (permalink / raw)
  To: gcc-bugs

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12466



------- Additional Comments From kcook at gcc dot gnu dot org  2003-09-30 17:45 -------
Created an attachment (id=4866)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=4866&action=view)
Reduced testcase

Compiling this with -Wold-style-definition will show the bug


^ permalink raw reply	[flat|nested] 5+ messages in thread
* [Bug c/12466] -Wold-style-definition incorrectly warns with ellipsises.
  2003-09-30 17:59 [Bug c/12466] New: -Wold-style-definition incorrectly warns with ellipsises kcook at gcc dot gnu dot org
  2003-09-30 18:14 ` [Bug c/12466] " kcook at gcc dot gnu dot org
@ 2003-09-30 18:23 ` kcook at gcc dot gnu dot org
  2003-09-30 21:43 ` pinskia at gcc dot gnu dot org
  2003-10-02  0:11 ` pinskia at gcc dot gnu dot org
  3 siblings, 0 replies; 5+ messages in thread
From: kcook at gcc dot gnu dot org @ 2003-09-30 18:23 UTC (permalink / raw)
  To: gcc-bugs

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12466



------- Additional Comments From kcook at gcc dot gnu dot org  2003-09-30 17:53 -------
Created an attachment (id=4868)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=4868&action=view)
Proposed Patch

http://gcc.gnu.org/ml/gcc-patches/2003-09/msg02134.html


^ permalink raw reply	[flat|nested] 5+ messages in thread
* [Bug c/12466] -Wold-style-definition incorrectly warns with ellipsises.
  2003-09-30 17:59 [Bug c/12466] New: -Wold-style-definition incorrectly warns with ellipsises kcook at gcc dot gnu dot org
  2003-09-30 18:14 ` [Bug c/12466] " kcook at gcc dot gnu dot org
  2003-09-30 18:23 ` kcook at gcc dot gnu dot org
@ 2003-09-30 21:43 ` pinskia at gcc dot gnu dot org
  2003-10-02  0:11 ` pinskia at gcc dot gnu dot org
  3 siblings, 0 replies; 5+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2003-09-30 21:43 UTC (permalink / raw)
  To: gcc-bugs

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12466


pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2003-09-30 19:56:18
               date|                            |


------- Additional Comments From pinskia at gcc dot gnu dot org  2003-09-30 19:56 -------
I can confirm this on the mainline (20030930).


^ permalink raw reply	[flat|nested] 5+ messages in thread
* [Bug c/12466] -Wold-style-definition incorrectly warns with ellipsises.
  2003-09-30 17:59 [Bug c/12466] New: -Wold-style-definition incorrectly warns with ellipsises kcook at gcc dot gnu dot org
                   ` (2 preceding siblings ...)
  2003-09-30 21:43 ` pinskia at gcc dot gnu dot org
@ 2003-10-02  0:11 ` pinskia at gcc dot gnu dot org
  3 siblings, 0 replies; 5+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2003-10-02  0:11 UTC (permalink / raw)
  To: gcc-bugs

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12466


pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
           Keywords|                            |diagnostic
         Resolution|                            |FIXED
   Target Milestone|---                         |3.4


------- Additional Comments From pinskia at gcc dot gnu dot org  2003-10-02 00:11 -------
Closing as fixed as  the patch went in: <http://gcc.gnu.org/ml/gcc-cvs/2003-10/
msg00040.html>


^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2003-10-02  0:11 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-09-30 17:59 [Bug c/12466] New: -Wold-style-definition incorrectly warns with ellipsises kcook at gcc dot gnu dot org
2003-09-30 18:14 ` [Bug c/12466] " kcook at gcc dot gnu dot org
2003-09-30 18:23 ` kcook at gcc dot gnu dot org
2003-09-30 21:43 ` pinskia at gcc dot gnu dot org
2003-10-02  0:11 ` pinskia at gcc dot gnu dot org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).