[Bug libobjc/12035] New: Path for libobjc/gc.c that fixes compilation error of Objective-C with garbage collector enabled

[Bug libobjc/12035] New: Path for libobjc/gc.c that fixes compilation error of Objective-C with garbage collector enabled

[v dot haisman at sh dot cvut dot cz]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12035

           Summary: Path for libobjc/gc.c that fixes compilation error of
                    Objective-C with garbage collector enabled
           Product: gcc
           Version: 3.4
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: libobjc
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: v dot haisman at sh dot cvut dot cz
                CC: gcc-bugs at gcc dot gnu dot org,v dot haisman at sh dot
                    cvut dot cz
 GCC build triplet: i686-pc-cygwin
  GCC host triplet: i686-pc-cygwin
GCC target triplet: i686-pc-cygwin

I had to make this small change to libobjc/gc.c to be able to compile it. There
was missing definition for BITS_PER_WORD.

[Bug libobjc/12035] Path for libobjc/gc.c that fixes compilation error of Objective-C with garbage collector enabled

[v dot haisman at sh dot cvut dot cz]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12035



------- Additional Comments From v dot haisman at sh dot cvut dot cz  2003-08-22 20:29 -------
Created an attachment (id=4643)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=4643&action=view)
The patch.

[Bug libobjc/12035] Patch for libobjc/gc.c that fixes compilation error of Objective-C with garbage collector enabled

[v dot haisman at sh dot cvut dot cz]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12035


v dot haisman at sh dot cvut dot cz changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Path for libobjc/gc.c that  |Patch for libobjc/gc.c that
                   |fixes compilation error of  |fixes compilation error of
                   |Objective-C with garbage    |Objective-C with garbage
                   |collector enabled           |collector enabled

[Bug libobjc/12035] Patch for libobjc/gc.c that fixes compilation error of Objective-C with garbage collector enabled

[pinskia at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12035


pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2003-08-22 20:40:23
               date|                            |


------- Additional Comments From pinskia at gcc dot gnu dot org  2003-08-22 20:40 -------
Can you post this to gcc-patches@ after reading <http://gcc.gnu.org/contribute.html> and make 
a changelog for it?

[Bug libobjc/12035] Patch for libobjc/gc.c that fixes compilation error of Objective-C with garbage collector enabled

[v dot haisman at sh dot cvut dot cz]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12035



------- Additional Comments From v dot haisman at sh dot cvut dot cz  2003-08-22 21:03 -------
http://gcc.gnu.org/ml/gcc-patches/2003-08/msg01385.html

[Bug libobjc/12035] Patch for libobjc/gc.c that fixes compilation error of Objective-C with garbage collector enabled

[dhazeghi at yahoo dot com]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12035


dhazeghi at yahoo dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|3.4                         |---

[Bug libobjc/12035] Patch for libobjc/gc.c that fixes compilation error of Objective-C with garbage collector enabled

[pinskia at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12035


pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch
   Target Milestone|---                         |3.4

[Bug libobjc/12035] Patch for libobjc/gc.c that fixes compilation error of Objective-C with garbage collector enabled

[zack at gcc dot gnu dot org]

------- Additional Comments From zack at gcc dot gnu dot org  2003-12-01 22:39 -------
This patch is wrong.  coretypes.h and tm.h are not to be referenced outside of
the gcc directory -- I realize that some files in libobjc already do that, but
that's not a reason to do it more.

See if you can't include <limits.h> and use CHAR_BIT * sizeof(void *) or a
similar construct.

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12035

[Bug libobjc/12035] Patch for libobjc/gc.c that fixes compilation error of Objective-C with garbage collector enabled

[gdr at integrable-solutions dot net]

------- Additional Comments From gdr at integrable-solutions dot net  2003-12-01 22:56 -------
Subject: Re:  Patch for libobjc/gc.c that fixes compilation error of Objective-C with garbage collector enabled

"zack at gcc dot gnu dot org" <gcc-bugzilla@gcc.gnu.org> writes:

| This patch is wrong.  coretypes.h and tm.h are not to be referenced
| outside of the gcc directory -- I realize that some files in libobjc
| already do that, but that's not a reason to do it more.

I completely agree.  For that matter, something similar was proposed
for V3 and I strongly disagreed with doing so.

-- Gaby


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12035

[Bug libobjc/12035] Patch for libobjc/gc.c that fixes compilation error of Objective-C with garbage collector enabled

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2003-12-02 16:35 -------
I was going to clean up libobjc one of these days to remove the references to GCC's internal header 
files but it is going to be hard because libobjc needs to find the layout of a struct.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|2003-08-22 20:40:23         |2003-12-02 16:35:28
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12035

[Bug libobjc/12035] Patch for libobjc/gc.c that fixes compilation error of Objective-C with garbage collector enabled

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|3.4.0                       |---


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12035

[Bug libobjc/12035] Patch for libobjc/gc.c that fixes compilation error of Objective-C with garbage collector enabled

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-01-25 06:49 -------
I am doing the cleanup.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |pinskia at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12035

[Bug libobjc/12035] [3.4/4.0 Regression] Patch for libobjc/gc.c that fixes compilation error of Objective-C with garbage collector enabled

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-12-20 21:55 -------
I think there is a better patch:
Index: gc.c
===============================================================
====
RCS file: /cvs/gcc/gcc/libobjc/gc.c,v
retrieving revision 1.6
diff -u -p -r1.6 gc.c
--- gc.c	23 May 2003 20:04:58 -0000	1.6
+++ gc.c	20 Dec 2004 21:51:20 -0000
@@ -40,18 +40,6 @@ Boston, MA 02111-1307, USA.  */
 typedef GC_word word;
 typedef GC_signed_word signed_word;
 
-#if BITS_PER_WORD == 32
-# define LOGWL	5
-# define modWORDSZ(n) ((n) & 0x1f)        /* n mod size of word
	    */
-#endif
-
-#if BITS_PER_WORD == 64
-# define LOGWL 6
-# define modWORDSZ(n) ((n) & 0x3f)        /* n mod size of word
	    */
-#endif
-
-#define divWORDSZ(n) ((n) >> LOGWL)	   /* divide n by size of word      */
-
 #include <gc_typed.h>
 
 /* The following functions set up in `mask` the corresponding pointers.


Which just removes the use of BITS_PER_WORD which are not used anywhere else.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Patch for libobjc/gc.c that |[3.4/4.0 Regression] Patch
                   |fixes compilation error of  |for libobjc/gc.c that fixes
                   |Objective-C with garbage    |compilation error of
                   |collector enabled           |Objective-C with garbage
                   |                            |collector enabled
   Target Milestone|---                         |3.4.4


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12035

[Bug libobjc/12035] [3.4/4.0 Regression] Patch for libobjc/gc.c that fixes compilation error of Objective-C with garbage collector enabled

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-12-20 22:32 -------
Subject: Bug 12035

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	pinskia@gcc.gnu.org	2004-12-20 22:32:42

Modified files:
	libobjc        : ChangeLog gc.c 

Log message:
	2004-12-20  Andrew Pinski  <pinskia@physics.uc.edu>
	
	PR libobjc/12035
	* gc.c: Remove definition of LOGWL, modWORDSZ, and divWORDSZ since
	they are not used.  Include limits.h and stdlib.h.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libobjc/ChangeLog.diff?cvsroot=gcc&r1=1.155&r2=1.156
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libobjc/gc.c.diff?cvsroot=gcc&r1=1.6&r2=1.7



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12035

[Bug libobjc/12035] [3.4/4.0 Regression] Patch for libobjc/gc.c that fixes compilation error of Objective-C with garbage collector enabled

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-12-20 22:34 -------
Subject: Bug 12035

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	gcc-3_4-branch
Changes by:	pinskia@gcc.gnu.org	2004-12-20 22:34:18

Modified files:
	libobjc        : ChangeLog gc.c 

Log message:
	2004-12-20  Andrew Pinski  <pinskia@physics.uc.edu>
	
	PR libobjc/12035
	* gc.c: Remove definition of LOGWL, modWORDSZ, and divWORDSZ since
	they are not used.
	Include limits.h and stdlib.h.
	Define BITS_PER_WORD.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libobjc/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.106.2.6&r2=1.106.2.7
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libobjc/gc.c.diff?cvsroot=gcc&only_with_tag=gcc-3_4-branch&r1=1.6&r2=1.6.16.1



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12035

[Bug libobjc/12035] [3.4/4.0 Regression] Patch for libobjc/gc.c that fixes compilation error of Objective-C with garbage collector enabled

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-12-20 22:35 -------
Subject: Bug 12035

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	pinskia@gcc.gnu.org	2004-12-20 22:35:08

Modified files:
	libobjc        : ChangeLog 

Log message:
	change the changelog entry to:
	2004-12-20  Andrew Pinski  <pinskia@physics.uc.edu>
	
	PR libobjc/12035
	* gc.c: Remove definition of LOGWL, modWORDSZ, and divWORDSZ since
	they are not used.
	Include limits.h and stdlib.h.
	Define BITS_PER_WORD.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libobjc/ChangeLog.diff?cvsroot=gcc&r1=1.156&r2=1.157



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12035

[Bug libobjc/12035] [3.4/4.0 Regression] Patch for libobjc/gc.c that fixes compilation error of Objective-C with garbage collector enabled

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-12-20 22:37 -------
Fixed with a slightly different patch that I added before.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12035