public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug other/12969] New: Including sys/byteorder.h on Sun Solaris 2.9 breaks configure checks
@ 2003-11-08 22:11 pkw at austin dot rr dot com
2003-11-08 22:34 ` [Bug other/12969] [3.3 Regression] " pinskia at gcc dot gnu dot org
` (5 more replies)
0 siblings, 6 replies; 7+ messages in thread
From: pkw at austin dot rr dot com @ 2003-11-08 22:11 UTC (permalink / raw)
To: gcc-bugs
In gcc 3.3.2, the following change was made from gcc 3.3.1:
diff -ru gcc-3.3.1/gcc/fixinc/inclhack.def gcc-3.3.2/gcc/fixinc/inclhack.def
--- gcc-3.3.1/gcc/fixinc/inclhack.def Wed Jul 2 01:47:05 2003
+++ gcc-3.3.2/gcc/fixinc/inclhack.def Tue Oct 14 06:42:40 2003
@@ -297,19 +297,10 @@
/*
* Completely replace <sys/byteorder.h>; with a file that implements gcc's
- * optimized byteswapping. Restricted to "SVR4" machines until either
- * it is shown to be safe to replace this file always, or we get bolder ;-)
+ * optimized byteswapping.
*/
fix = {
hackname = AAB_svr4_replace_byteorder;
-#ifndef SVR5
- mach = "*-*-sysv4*";
- mach = "i[34567]86-*-sysv5*";
- mach = "i[34567]86-*-udk*";
- mach = "i[34567]86-*-solaris2.[0-4]";
- mach = "powerpcle-*-solaris2.[0-4]";
- mach = "sparc-*-solaris2.[0-4]";
-#endif /* SVR5 */
files = sys/byteorder.h;
replace = '#ifndef _SYS_BYTEORDER_H
\#define _SYS_BYTEORDER_H
so a new sys/byteorder.h is now generated by fixincludes. However, several
configure checks for common software, like openssh, use the c preprocessor to
determine if a header file exists. If you run the c-preprocessor on the
following file in gcc 3.3.1, you get:
pkw@hedwig:~$ cpp --version
cpp (GCC) 3.3.1
Copyright (C) 2003 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
pkw@hedwig:~$ echo "#include <netdb.h>" > test.c
pkw@hedwig:~$ cpp test.c > /dev/null
pkw@hedwig:~$ echo $?
0
With gcc 3.3.2, you get:
pkw@hedwig:~$ /opt/csw/gcc3/bin/cpp --version
cpp (GCC) 3.3.2
Copyright (C) 2003 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
pkw@hedwig:~$ echo "#include <netdb.h>" > test.c
pkw@hedwig:~$ /opt/csw/gcc3/bin/cpp test.c > /dev/null
In file included from /usr/include/netinet/in.h:48,
from /usr/include/netdb.h:98,
from test.c:1:
/opt/csw/gcc3/lib/gcc-lib/sparc-sun-solaris2.8/3.3.2/include/sys/byteorder.h:26:2:
#error You lose! This file is only useful with GNU compilers.
pkw@hedwig:~$ echo $?
1
--
Summary: Including sys/byteorder.h on Sun Solaris 2.9 breaks
configure checks
Product: gcc
Version: 3.3.2
Status: UNCONFIRMED
Severity: normal
Priority: P2
Component: other
AssignedTo: unassigned at gcc dot gnu dot org
ReportedBy: pkw at austin dot rr dot com
CC: gcc-bugs at gcc dot gnu dot org
GCC build triplet: sparc-sun-solaris2.9
GCC host triplet: sparc-sun-solaris2.9
GCC target triplet: sparc-sun-solaris2.9
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12969
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug other/12969] [3.3 Regression] Including sys/byteorder.h on Sun Solaris 2.9 breaks configure checks
2003-11-08 22:11 [Bug other/12969] New: Including sys/byteorder.h on Sun Solaris 2.9 breaks configure checks pkw at austin dot rr dot com
@ 2003-11-08 22:34 ` pinskia at gcc dot gnu dot org
2003-11-09 18:25 ` neroden at gcc dot gnu dot org
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: pinskia at gcc dot gnu dot org @ 2003-11-08 22:34 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From pinskia at gcc dot gnu dot org 2003-11-08 22:33 -------
This was cause by (but was only applied to the 3.3 branch):
2003-08-11 Kean Johnston <jkj@sco.com>
* fixinc/inclhack.def (sco_math): Updated test text and select trigger
according to bkorb's review.
* fixinc/inclhack.def (sco_regset): Ditto.
* fixinc/inclhack.def (AAB_svr4_replace_byteorder): Remove all mach
lines so that this file is unconditionally replaced.
A different patch was applied to the mainline:
2003-08-24 Nathanael Nerode <neroden@gcc.gnu.org>
* fixinc/inclhack.def (AAB_svr4_replace_byteorder): Enhance
comment. Enable for DYNIX/ptx systems (when they switch to
regular fixincludes).
* fixinc/fixincl.x: Regenerate.
Can someone fix this problem?
--
What |Removed |Added
----------------------------------------------------------------------------
CC| |neroden at gcc dot gnu dot
| |org, jkj at sco dot com
Status|UNCONFIRMED |NEW
Ever Confirmed| |1
Last reconfirmed|0000-00-00 00:00:00 |2003-11-08 22:33:59
date| |
Summary|Including sys/byteorder.h on|[3.3 Regression] Including
|Sun Solaris 2.9 breaks |sys/byteorder.h on Sun
|configure checks |Solaris 2.9 breaks configure
| |checks
Target Milestone|--- |3.3.3
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12969
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug other/12969] [3.3 Regression] Including sys/byteorder.h on Sun Solaris 2.9 breaks configure checks
2003-11-08 22:11 [Bug other/12969] New: Including sys/byteorder.h on Sun Solaris 2.9 breaks configure checks pkw at austin dot rr dot com
2003-11-08 22:34 ` [Bug other/12969] [3.3 Regression] " pinskia at gcc dot gnu dot org
@ 2003-11-09 18:25 ` neroden at gcc dot gnu dot org
2003-12-01 9:14 ` [Bug other/12969] [3.3.2 regression] Including sys/byteorder.h " ebotcazou at gcc dot gnu dot org
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: neroden at gcc dot gnu dot org @ 2003-11-09 18:25 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From neroden at gcc dot gnu dot org 2003-11-09 18:25 -------
My patch was of course correct. :-)
The question of whether to enable byteorder.h replacement on *all* systems as
opposed to a select list is interesting. However, the discussion does not
clearly conclude that it's a good idea. Accordingly, I think that was a
mistaken change. The "#ifndef SVR5" lines are unnecessary and bogus, of course
(note that SVR5 is undefined by default). I suggest that 3.3-branch be reverted
to the state before this most recent patch (where there is still a list of
machines); meanwhile mainline should simply have the #ifndef SVR5 / #endif lines
removed, retaining the list of machines.
The fixes to sco_math and sco_regset belong on mainline, and were not put there.
Kean, please put them there. :-) (*Don't* copy any other 3.3-branch changes
to mainline, these are the only two which are missing and belong there.)
--
What |Removed |Added
----------------------------------------------------------------------------
CC| |bkorb at veritas dot com
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12969
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug other/12969] [3.3.2 regression] Including sys/byteorder.h breaks configure checks
2003-11-08 22:11 [Bug other/12969] New: Including sys/byteorder.h on Sun Solaris 2.9 breaks configure checks pkw at austin dot rr dot com
2003-11-08 22:34 ` [Bug other/12969] [3.3 Regression] " pinskia at gcc dot gnu dot org
2003-11-09 18:25 ` neroden at gcc dot gnu dot org
@ 2003-12-01 9:14 ` ebotcazou at gcc dot gnu dot org
2003-12-03 20:10 ` cvs-commit at gcc dot gnu dot org
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: ebotcazou at gcc dot gnu dot org @ 2003-12-01 9:14 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From ebotcazou at gcc dot gnu dot org 2003-12-01 09:14 -------
As per Nathanael suggestion, I'll revert the faulty patch on the 3.3 branch on
12/08 if no progress is made before that date.
--
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|unassigned at gcc dot gnu |ebotcazou at gcc dot gnu dot
|dot org |org
Severity|normal |critical
Status|NEW |ASSIGNED
Summary|[3.3 Regression] Including |[3.3.2 regression] Including
|sys/byteorder.h on Sun |sys/byteorder.h breaks
|Solaris 2.9 breaks configure|configure checks
|checks |
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12969
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug other/12969] [3.3.2 regression] Including sys/byteorder.h breaks configure checks
2003-11-08 22:11 [Bug other/12969] New: Including sys/byteorder.h on Sun Solaris 2.9 breaks configure checks pkw at austin dot rr dot com
` (2 preceding siblings ...)
2003-12-01 9:14 ` [Bug other/12969] [3.3.2 regression] Including sys/byteorder.h " ebotcazou at gcc dot gnu dot org
@ 2003-12-03 20:10 ` cvs-commit at gcc dot gnu dot org
2003-12-03 20:11 ` jkj at sco dot com
2003-12-04 7:00 ` ebotcazou at gcc dot gnu dot org
5 siblings, 0 replies; 7+ messages in thread
From: cvs-commit at gcc dot gnu dot org @ 2003-12-03 20:10 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From cvs-commit at gcc dot gnu dot org 2003-12-03 20:10 -------
Subject: Bug 12969
CVSROOT: /cvs/gcc
Module name: gcc
Branch: gcc-3_3-branch
Changes by: jkj@gcc.gnu.org 2003-12-03 20:10:44
Modified files:
gcc : ChangeLog
gcc/fixinc : inclhack.def fixincl.x
gcc/fixinc/tests/base/ansi: string.h
Log message:
2003-12-03 Kean Johnston <jkj@sco.com>
PR 12969
* fixinc/inclhack.def (AAB_svr4_replace_byteorder): Revert the
change I made on 2003-08-11 that removes the mach lines.
Restore them to the same list thats in the head, as per
Nathanael Nerode's changes.
* fixinc/fixincl.x: Regenerated
* fixinc/tests/base/ansi/string.h: Fix test case
Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-3_3-branch&r1=1.16114.2.820&r2=1.16114.2.821
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/fixinc/inclhack.def.diff?cvsroot=gcc&only_with_tag=gcc-3_3-branch&r1=1.139.4.15&r2=1.139.4.16
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/fixinc/fixincl.x.diff?cvsroot=gcc&only_with_tag=gcc-3_3-branch&r1=1.132.4.14&r2=1.132.4.15
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/fixinc/tests/base/ansi/string.h.diff?cvsroot=gcc&only_with_tag=gcc-3_3-branch&r1=1.1.2.2&r2=1.1.2.3
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12969
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug other/12969] [3.3.2 regression] Including sys/byteorder.h breaks configure checks
2003-11-08 22:11 [Bug other/12969] New: Including sys/byteorder.h on Sun Solaris 2.9 breaks configure checks pkw at austin dot rr dot com
` (3 preceding siblings ...)
2003-12-03 20:10 ` cvs-commit at gcc dot gnu dot org
@ 2003-12-03 20:11 ` jkj at sco dot com
2003-12-04 7:00 ` ebotcazou at gcc dot gnu dot org
5 siblings, 0 replies; 7+ messages in thread
From: jkj at sco dot com @ 2003-12-03 20:11 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From jkj at sco dot com 2003-12-03 20:11 -------
I just checked in the fix for this that Nate suggested. Sorry it took so long.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12969
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug other/12969] [3.3.2 regression] Including sys/byteorder.h breaks configure checks
2003-11-08 22:11 [Bug other/12969] New: Including sys/byteorder.h on Sun Solaris 2.9 breaks configure checks pkw at austin dot rr dot com
` (4 preceding siblings ...)
2003-12-03 20:11 ` jkj at sco dot com
@ 2003-12-04 7:00 ` ebotcazou at gcc dot gnu dot org
5 siblings, 0 replies; 7+ messages in thread
From: ebotcazou at gcc dot gnu dot org @ 2003-12-04 7:00 UTC (permalink / raw)
To: gcc-bugs
------- Additional Comments From ebotcazou at gcc dot gnu dot org 2003-12-04 07:00 -------
Many thanks Kean!
--
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12969
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2003-12-04 7:00 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-11-08 22:11 [Bug other/12969] New: Including sys/byteorder.h on Sun Solaris 2.9 breaks configure checks pkw at austin dot rr dot com
2003-11-08 22:34 ` [Bug other/12969] [3.3 Regression] " pinskia at gcc dot gnu dot org
2003-11-09 18:25 ` neroden at gcc dot gnu dot org
2003-12-01 9:14 ` [Bug other/12969] [3.3.2 regression] Including sys/byteorder.h " ebotcazou at gcc dot gnu dot org
2003-12-03 20:10 ` cvs-commit at gcc dot gnu dot org
2003-12-03 20:11 ` jkj at sco dot com
2003-12-04 7:00 ` ebotcazou at gcc dot gnu dot org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).