[Bug libstdc++/12882] New: Large file support not complete

[Bug libstdc++/12882] New: Large file support not complete

[peturr02 at ru dot is]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12882

           Summary: Large file support not complete
           Product: gcc
           Version: 3.4
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: libstdc++
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: peturr02 at ru dot is
                CC: gcc-bugs at gcc dot gnu dot org
 GCC build triplet: i686-pc-linux-gnu
  GCC host triplet: i686-pc-linux-gnu
GCC target triplet: i686-pc-linux-gnu

stdio_sync_filebuf::seekoff doesn't have large file support:

 virtual std::streampos
      seekoff(std::streamoff __off, std::ios_base::seekdir __dir,
              std::ios_base::openmode = std::ios_base::in | std::ios_base::out)
      {
[...]
        
        if (!fseek(_M_file, __off, __whence))
          __ret = std::streampos(std::ftell(_M_file));
        return __ret;
      }

Here, fseeko64/ftello64 should be used if available, else fseeko/ftello
if available, else fseek/ftell.

[Bug libstdc++/12882] Large file support not complete

[pinskia at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12882


pinskia at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2003-11-03 15:58:25
               date|                            |


------- Additional Comments From pinskia at gcc dot gnu dot org  2003-11-03 15:58 -------
Confirmed.

[Bug libstdc++/12882] Large file support not complete

[paolo at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12882


paolo at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |paolo at gcc dot gnu dot org
                   |dot org                     |
             Status|NEW                         |ASSIGNED


------- Additional Comments From paolo at gcc dot gnu dot org  2003-11-03 17:43 -------
Will fix it next week! 
Thanks for pointing it out soon! 
Paolo.

[Bug libstdc++/12882] Large file support not complete

[paolo at gcc dot gnu dot org]

PLEASE REPLY TO gcc-bugzilla@gcc.gnu.org ONLY, *NOT* gcc-bugs@gcc.gnu.org.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12882



------- Additional Comments From paolo at gcc dot gnu dot org  2003-11-03 20:35 -------
By the way, showmanyc must be fixed too, both for stdio_filebuf and  
stdio_sync_filebuf, to use fstat64 and lseek64.

[Bug libstdc++/12882] Large file support not complete

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2003-11-21 20:30 -------
Subject: Bug 12882

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	paolo@gcc.gnu.org	2003-11-21 20:30:12

Modified files:
	libstdc++-v3   : ChangeLog acinclude.m4 aclocal.m4 configure 
	libstdc++-v3/include/ext: stdio_sync_filebuf.h 

Log message:
	2003-11-21  Paolo Carlini  <pcarlini@suse.de>
	
	PR libstdc++/12882 (partial)
	* acinclude.m4 (GLIBCXX_CHECK_LFS): Check fseeko64
	and ftello64 too.
	* include/ext/stdio_sync_filebuf.h (seekoff): Use fseeko64
	and ftello64 if available.
	* aclocal.m4: Regenerate.
	* configure: Ditto.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/ChangeLog.diff?cvsroot=gcc&r1=1.2097&r2=1.2098
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/acinclude.m4.diff?cvsroot=gcc&r1=1.276&r2=1.277
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/aclocal.m4.diff?cvsroot=gcc&r1=1.290&r2=1.291
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/configure.diff?cvsroot=gcc&r1=1.366&r2=1.367
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/include/ext/stdio_sync_filebuf.h.diff?cvsroot=gcc&r1=1.5&r2=1.6



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12882

[Bug libstdc++/12882] Large file support not complete

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-01-01 22:26 -------
stdio_sync_filebuf uses fstat still:
      virtual std::streamsize
      showmanyc()
      { 
#if defined(_GLIBCXX_HAVE_S_ISREG) || defined(_GLIBCXX_HAVE_S_IFREG)
        // Regular files.
        struct stat __buffer; 
        int __ret = fstat(fileno(_M_file), &__buffer);
        if (!__ret && _GLIBCXX_ISREG(__buffer.st_mode)) 
          return __buffer.st_size - ftell(_M_file);
#endif 
...

And in basic_file_stdio.h, fstat:
  streamsize
  __basic_file<char>::showmanyc()
  {
...
#if defined(_GLIBCXX_HAVE_S_ISREG) || defined(_GLIBCXX_HAVE_S_IFREG)
    // Regular files.
    struct stat __buffer;
    int __ret = fstat(this->fd(), &__buffer);
    if (!__ret && _GLIBCXX_ISREG(__buffer.st_mode))
        return __buffer.st_size - lseek(this->fd(), 0, ios_base::cur);
#endif

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|2003-11-03 15:58:25         |2004-01-01 22:26:01
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12882

[Bug libstdc++/12882] Large file support not complete

[pcarlini at suse dot de]

------- Additional Comments From pcarlini at suse dot de  2004-07-07 21:39 -------
*** Bug 16410 has been marked as a duplicate of this bug. ***

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |amu at alum dot mit dot edu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12882

[Bug libstdc++/12882] Large file support not complete

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2004-08-18 19:28 -------
*** Bug 17086 has been marked as a duplicate of this bug. ***

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |scrimr at louisville dot
                   |                            |stortek dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12882

[Bug libstdc++/12882] Large file support not complete

[scrimr at louisville dot stortek dot com]

------- Additional Comments From scrimr at louisville dot stortek dot com  2004-08-18 19:58 -------
Subject: RE:  Large file support not complete


That's fine but I am using 3.4.1 not 3.4.0. I already saw this bug before I
submitted it.  What version or timeframe do you expect it to be fixed in? 
 
Thank you,
Robert

-----Original Message-----
From: pinskia at gcc dot gnu dot org [mailto:gcc-bugzilla@gcc.gnu.org] 
Sent: Wednesday, August 18, 2004 1:29 PM
To: scrimr@louisville.stortek.com
Subject: [Bug libstdc++/12882] Large file support not complete


------- Additional Comments From pinskia at gcc dot gnu dot org  2004-08-18
19:28 -------
*** Bug 17086 has been marked as a duplicate of this bug. ***

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |scrimr at louisville dot
                   |                            |stortek dot com


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12882

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12882

[Bug libstdc++/12882] Large file support not complete

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2004-09-21 09:06 -------
Subject: Bug 12882

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	paolo@gcc.gnu.org	2004-09-21 09:06:08

Modified files:
	libstdc++-v3   : ChangeLog acinclude.m4 configure 
	libstdc++-v3/config/io: basic_file_stdio.cc 

Log message:
	2004-09-21  Paolo Carlini  <pcarlini@suse.de>
	
	PR libstdc++/12882 (cont)
	* acinclude.m4 (GLIBCXX_CHECK_LFS): Check for fstat64 too.
	* configure: Regenerate.
	* config/io/basic_file_stdio.cc (__basic_file<>::showmanyc): When
	_GLIBCXX_USE_LFS use fstat64 and lseek64, thus providing a non
	trivial showmanyc for large files too.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/ChangeLog.diff?cvsroot=gcc&r1=1.2665&r2=1.2666
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/acinclude.m4.diff?cvsroot=gcc&r1=1.295&r2=1.296
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/configure.diff?cvsroot=gcc&r1=1.405&r2=1.406
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libstdc++-v3/config/io/basic_file_stdio.cc.diff?cvsroot=gcc&r1=1.34&r2=1.35



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12882

[Bug libstdc++/12882] Large file support not complete

[pcarlini at suse dot de]

------- Additional Comments From pcarlini at suse dot de  2004-09-21 09:31 -------
Completely fixed (showmanyc too) for 4.0.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.0.0


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=12882