[Bug fortran/13257] New: [gfortran] Error instead of warning for missing comma in format string

[Bug fortran/13257] New: [gfortran] Error instead of warning for missing comma in format string

[dann at godzilla dot ics dot uci dot edu]

With: gcc version 3.5-tree-ssa 20031130 (merged 20031123)

test.f90
      subroutine mysub
      dimension ibar(5)
      write (3,1001) ( ibar(m), m = 1, 5 )

 1001 format (/5x,' ',i4' '/ )
      return
      end

gfortran -c test.f90 -ffixed-form                                              
                                               In file test.f90:5

 1001 format (/5x,' ',i4' '/ )
                           1
Error: Missing comma in format string at (1)
 In file test.f90:3

      write (3,1001) ( ibar(m), m = 1, 5 )
                  1
Error: FORMAT label 1001 at (1) not defined

g77 gives a warning, but still compiles the code.

Intel's compiler compiles the above code.

Code like this appears in SPEC95

-- 
           Summary: [gfortran] Error instead of warning for missing comma in
                    format string
           Product: gcc
           Version: tree-ssa
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: fortran
        AssignedTo: unassigned at gcc dot gnu dot org
        ReportedBy: dann at godzilla dot ics dot uci dot edu
                CC: gcc-bugs at gcc dot gnu dot org
 GCC build triplet: i686-pc-linux-gnu
  GCC host triplet: i686-pc-linux-gnu
GCC target triplet: i686-pc-linux-gnu


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13257

[Bug fortran/13257] [gfortran] Error instead of warning for missing comma in format string

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |diagnostic, rejects-valid
   Target Milestone|---                         |tree-ssa


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13257

[Bug fortran/13257] [gfortran] Error instead of warning for missing comma in format string

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2003-12-02 15:43 -------
Confirmed.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|                            |1
   Last reconfirmed|0000-00-00 00:00:00         |2003-12-02 15:43:53
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13257

[Bug fortran/13257] [gfortran] Error instead of warning for missing comma in format string

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement
   Last reconfirmed|2004-01-25 17:58:01         |2004-04-26 04:02:04
               date|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13257

[Bug fortran/13257] [gfortran] Error instead of warning for missing comma in format string

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |15502
              nThis|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13257

[Bug fortran/13257] [gfortran] Error instead of warning for missing comma in format string

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|3.5.0                       |---


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13257

[Bug fortran/13257] Error instead of warning for missing comma in format string

[tobi at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
OtherBugsDependingO|                            |19292
              nThis|                            |


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13257

[Bug fortran/13257] Error instead of warning for missing comma in format string

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-01-08 20:38 -------
This also appears in SPEC 2000 also in galgel (why we don't reject it on x86 I have no idea).

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pinskia at gcc dot gnu dot
                   |                            |org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13257

[Bug fortran/13257] Error instead of warning for missing comma in format string

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-04-08 14:27 -------
I have a fix which I am testing right now.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot gnu   |pinskia at gcc dot gnu dot
                   |dot org                     |org
             Status|NEW                         |ASSIGNED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13257

[Bug fortran/13257] Error instead of warning for missing comma in format string

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-04-08 17:07 -------
Patch here: <http://gcc.gnu.org/ml/gcc-patches/2005-04/msg00874.html>.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13257

[Bug fortran/13257] Error instead of warning for missing comma in format string

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-04-09 18:44 -------
Subject: Bug 13257

CVSROOT:	/cvs/gcc
Module name:	gcc
Changes by:	pinskia@gcc.gnu.org	2005-04-09 18:44:07

Modified files:
	gcc/testsuite  : ChangeLog 
	libgfortran    : ChangeLog 
	libgfortran/io : format.c 
	gcc/fortran    : ChangeLog io.c 
Added files:
	gcc/testsuite/gfortran.dg: comma_format_extension_1.f 
	                           comma_format_extension_2.f 
	                           comma_format_extension_3.f 
	                           comma_format_extension_4.f 

Log message:
	PR fortran/13257
	
	fortran/ChangeLog:
	* io.c (check_format): Allow an optional comma
	between descriptors.
	
	libgfortran/ChangeLog:
	* format.c (parse_format_list): Allow an optional comma
	between descriptors.
	
	testsuite/ChangeLog:
	* comma_format_extension_[1234].f: New tests.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&r1=1.5311&r2=1.5312
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/ChangeLog.diff?cvsroot=gcc&r1=1.184&r2=1.185
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/io/format.c.diff?cvsroot=gcc&r1=1.10&r2=1.11
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/fortran/ChangeLog.diff?cvsroot=gcc&r1=1.384&r2=1.385
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/fortran/io.c.diff?cvsroot=gcc&r1=1.20&r2=1.21
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gfortran.dg/comma_format_extension_1.f.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gfortran.dg/comma_format_extension_2.f.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gfortran.dg/comma_format_extension_3.f.diff?cvsroot=gcc&r1=NONE&r2=1.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gfortran.dg/comma_format_extension_4.f.diff?cvsroot=gcc&r1=NONE&r2=1.1



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13257

[Bug fortran/13257] [4.0 only] Error instead of warning for missing comma in format string

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-04-09 18:46 -------
Fixed on the mainline waiting for 4.0 branch to reopen to apply there.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|rejects-valid               |
      Known to work|                            |4.1.0
            Summary|Error instead of warning for|[4.0 only] Error instead of
                   |missing comma in format     |warning for missing comma in
                   |string                      |format string
   Target Milestone|---                         |4.0.1


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13257

[Bug fortran/13257] [4.0 only] Error instead of warning for missing comma in format string

[giovannibajo at libero dot it]

------- Additional Comments From giovannibajo at libero dot it  2005-06-06 10:45 -------
ping this, it looks like Andrew just missed 4.0.1 too for this bug :)

-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13257

[Bug fortran/13257] [4.0 only] Error instead of warning for missing comma in format string

[pinskia at gcc dot gnu dot org]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.0.1                       |4.0.2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13257

[Bug fortran/13257] [4.0 only] Error instead of warning for missing comma in format string

[pinskia at gcc dot gnu dot org]

------- Additional Comments From pinskia at gcc dot gnu dot org  2005-07-16 20:46 -------
Fixed.

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13257

[Bug fortran/13257] [4.0 only] Error instead of warning for missing comma in format string

[cvs-commit at gcc dot gnu dot org]

------- Additional Comments From cvs-commit at gcc dot gnu dot org  2005-07-16 20:46 -------
Subject: Bug 13257

CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	gcc-4_0-branch
Changes by:	pinskia@gcc.gnu.org	2005-07-16 20:46:23

Modified files:
	gcc/fortran    : ChangeLog io.c 
	gcc/testsuite  : ChangeLog 
	libgfortran    : ChangeLog 
	libgfortran/io : format.c 
Added files:
	gcc/testsuite/gfortran.dg: comma_format_extension_1.f 
	                           comma_format_extension_2.f 
	                           comma_format_extension_3.f 
	                           comma_format_extension_4.f 

Log message:
	2005-07-16  Andrew Pinski  <pinskia@physics.uc.edu>
	
	PR fortran/13257
	* io.c (check_format): Allow an optional comma
	between descriptors.
	
	2005-07-16  Andrew Pinski  <pinskia@physics.uc.edu>
	
	PR fortran/13257
	* format.c (parse_format_list): Allow an optional comma
	between descriptors.
	
	2005-07-16  Andrew Pinski  <pinskia@physics.uc.edu>
	
	PR fortran/13257
	* comma_format_extension_[1234].f: New tests.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/fortran/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.335.2.91&r2=1.335.2.92
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/fortran/io.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.19.10.6&r2=1.19.10.7
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.5084.2.282&r2=1.5084.2.283
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gfortran.dg/comma_format_extension_1.f.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.10.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gfortran.dg/comma_format_extension_2.f.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.10.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gfortran.dg/comma_format_extension_3.f.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.10.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/gcc/testsuite/gfortran.dg/comma_format_extension_4.f.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=NONE&r2=1.1.10.1
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/ChangeLog.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.163.2.63&r2=1.163.2.64
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/libgfortran/io/format.c.diff?cvsroot=gcc&only_with_tag=gcc-4_0-branch&r1=1.9.12.2&r2=1.9.12.3



-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=13257